From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08F9AC2D0A8 for ; Tue, 29 Sep 2020 00:37:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 830342193E for ; Tue, 29 Sep 2020 00:37:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Bz78DTcw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="v69NAAku" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 830342193E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QemEs5N4PyoxZj24q/WyFtmC4AUpQ4vq9KkDJVI0Ckk=; b=Bz78DTcw3wEtBFPd8peBDw5g4 GBZ/L9xyIh8KEyo6X9KRPPU4h31tjm9gWlmdty1BtK+Hz7kI0dZzSjt1od8CIORPWZPT9yGRtcPtY YAF7k/PjOmwq12DcLnW+EricJWSh0h0ZTDsxQCczf00Y29WbGa1mSn6SHr31DpwxkQ9Vvl4dv+uFD RJdwvXZYgqThG47SRdyx2Cw1qLgz6Osj10ejIYM/lb1z6T7d7nO3TVwAuPF7CYgYFYPJtx3d9FKer 61GDGKIQyu77tXI96WYvghptBxoC7Q5vOfLUODBO4iz0VTHYQLt7CbF3ENVurJ7DYzKpZ+dQp3u9L xMhfTTwQg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kN3cf-0003tS-EN; Tue, 29 Sep 2020 00:36:01 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kN3cc-0003sE-6C for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2020 00:35:59 +0000 Received: by mail-pj1-x1041.google.com with SMTP id kk9so1696570pjb.2 for ; Mon, 28 Sep 2020 17:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=uaAgCWaphNg4XUpNx4joWU1xUSe7LvQcJOGZWvIHnHc=; b=v69NAAkuCTEr7hg3phUdSwS/jRxtb9RhagIGnDoxmqRXRs2S6C/CmnrYbXfDPrKmM7 QKjikJoR6KEdqOFIQ0BMA2SDVoq2ov6NBMoBRH42AjSEXXz+zca8AQjnpe+FciLxsMNS mTm0/iSB/gGJ4zkbRi+9IGT69J067NB76CdJmDnGwpZ/eZqCO8nZ6G77J0x6C6sZn2Tf sarRvQVDFOV4eSjr1zdVf9CA+EwfAUiXpEjL+jpMGujhWiuo7JMxdHoy6SCk+CbR09Q3 u8QlDxiw3bRifR3UEMb1QX9f82B+GzxbIkCVeaMBS+mMYhLjSMIZFQFQCl6DcBSG+mhW HwHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=uaAgCWaphNg4XUpNx4joWU1xUSe7LvQcJOGZWvIHnHc=; b=rXrAH/aTGVoMGxd+ZWqqowxRI46C+lQsLGG6AkYCnxAiivVNZCNVALybp+OAjAvZmG YaFcthMZU1/07XtDyHuBpPv83oIz44okre/U9DskTpt8AOp/QJNhtcF4acFRlZfR1xSq UKYcMcndSmJSnX+YRjJ7uSZpTQyNL/FyO+eM3zvazVmEh2bQTkrEzCqpuClIyd/Ypj3E stbrT/i6j4JhqdrhvLV0tMrIMWNPFX998rQkiefLb4yTYsCxZDf2QdhxgdyviTmIgv5Z 4ztumf1M1rTB1hMc2ARn7mXXk/D1NQDCywTg+F00K119DN/+1bnZHlpwdxoDAidumWtW J2cA== X-Gm-Message-State: AOAM530Q0g3z4Imxl65p/xp6C6gNyMh3nFRhKGX/g45RUsnc0vveIWaJ 1EMLOc9/d22JKpckcN0xIJE5KA== X-Google-Smtp-Source: ABdhPJw4qd17QzT6F2MmDcBshvhH/7FLRINF+lgsSnB4r4uMssLfw33w1g4TzP14kOgM0kQATT3GoA== X-Received: by 2002:a17:90a:fc1:: with SMTP id 59mr1653722pjz.156.1601339753340; Mon, 28 Sep 2020 17:35:53 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id q16sm3127759pfj.117.2020.09.28.17.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2020 17:35:52 -0700 (PDT) From: Kevin Hilman To: Brad Harper , linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH v2 1/1] mmc: host: meson-gx-mmc: fix possible deadlock condition for preempt_rt In-Reply-To: <20200927025418.12382-2-bjharper@gmail.com> References: <20200927025418.12382-1-bjharper@gmail.com> <20200927025418.12382-2-bjharper@gmail.com> Date: Mon, 28 Sep 2020 17:35:50 -0700 Message-ID: <7hwo0dmnbt.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_203558_232486_DFA6128C X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brad Harper , linux-rt-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Brad Harper writes: > --- > drivers/mmc/host/meson-gx-mmc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) This patch still needs changelog summarizing the problem and what is being fixed by the patch. Most of what's in the cover letter belongs here. The cover letter can be used to describe the history/background that you don't want in the patch itself. Alternatviely, you could include that information in the a single patch email also because everything after the "---" line does not end up in git history. > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > index 08a3b1c05..3ba8f988d 100644 > --- a/drivers/mmc/host/meson-gx-mmc.c > +++ b/drivers/mmc/host/meson-gx-mmc.c > @@ -146,6 +146,7 @@ struct sd_emmc_desc { > }; > > struct meson_host { > + spinlock_t lock; > struct device *dev; > struct meson_mmc_data *data; > struct mmc_host *mmc; > @@ -1051,6 +1052,7 @@ static int meson_mmc_probe(struct platform_device *pdev) > host->mmc = mmc; > host->dev = &pdev->dev; > dev_set_drvdata(&pdev->dev, host); > + spin_lock_init(&host->lock); I'm confused about what this lock is intended to do. You init it here, but it's never used anywhere. > /* The G12A SDIO Controller needs an SRAM bounce buffer */ > host->dram_access_quirk = device_property_read_bool(&pdev->dev, > @@ -1139,7 +1141,7 @@ static int meson_mmc_probe(struct platform_device *pdev) > host->regs + SD_EMMC_IRQ_EN); > > ret = request_threaded_irq(host->irq, meson_mmc_irq, > - meson_mmc_irq_thread, IRQF_ONESHOT, > + meson_mmc_irq_thread, 0, > dev_name(&pdev->dev), host); > if (ret) > goto err_init_clk; Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel