From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF07AC4646C for ; Mon, 24 Jun 2019 23:20:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9301720674 for ; Mon, 24 Jun 2019 23:20:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SXc6x+KE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="dLg/cSRk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9301720674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6qkfKlt/aPMq1er2lNJQn3QPm/3aBe+s1VnjED+pDCU=; b=SXc6x+KEt+57lU LZ27/wx0QZn7JjD+wqUXkQEjV2KuRi+3cc81Yra7upcIxWVbeeScDF44L1Q0arWBP8NZejHL05a+r XBWo00Qiri3hQgxwi6NSYzVbiiix3i5Pq5LazOtwUgweC15NORoKVEGBYz32tbjlqnsfeEHrhYUPh s+oEo1fTFF4slZobmRUka8Srj0y+7anyHdFw+vpZJna3YUMNXRZM6pZFpA99CCaC88Wrwa0HgSkap k1/Qnw3RDydWEUupwAn37HuC1RdPltfgoPzOqkGY3nDmq5IDfQOKyFON/ucnRkVT1wGhT7nbNQqQ1 Y5ixZ07RbudKGEL1sSQQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfYGR-0006eO-B8; Mon, 24 Jun 2019 23:20:43 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfYGH-0006am-6y for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2019 23:20:34 +0000 Received: by mail-pf1-x442.google.com with SMTP id t16so8349567pfe.11 for ; Mon, 24 Jun 2019 16:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=CLMq9SkPZ0LrpMbu6uM6UrnywucO78/fC+4xJdWuUjU=; b=dLg/cSRkJPUZwFWpsP5zrU6X5hseY4oEeFd0LoCR7LGMnXqC0nzPoFAzqz9Y7u/41c PVqSleEbaPIgcPu0aCXcvA8ErwL0FqzRVDuGb0m2YwMJ9cLF7LbUaVxZP6q/2kesoXRK /jWxwhBmthWot8HMFhTMtiLMF/eWvtwCGW/6JkkiTuKr3iAewjAgK3i9kIFHThWf575k 4wEOAr5iRNfUAvL3Xq4eB6rRA+mjQFjipz3E7czZd/g0cvHAaH3Btayr9Z60UV90p37m CkV51ozzeK7L+hUT1HzMKJCGHN2tVbrbHL8lyYsoK6oeRmrOC9eKXS9fiv1ZYUi9XD+Z 9m5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=CLMq9SkPZ0LrpMbu6uM6UrnywucO78/fC+4xJdWuUjU=; b=UKDI88jM8ifBlWA/ynXiRupjvc1CekrJo57zVTOoQrPeuwR7GKJb25NEqa/5bGJOQ8 5gLrZpwZzmNr366xvvs3E1yvgNCe41458RblFMIN/dWxDAyQLGLNLBM/l0GmU5O/s48O 4Wmbul+SI92GQRWP0GTa9maShwTIlWVfIBUem73HjmRN7jrN+iUwRtlj9/O4uq/3LokO 0yJM/LLLUPAcRpFPsedhpiTwTzmlQI+qa16yWvzqX4aA9VkkmMWQYaZyQczZn/aOOQk3 4mDuovVYDezU4mPT44XFQiRWcjXHVxQxetmXy7wMyLiAWSjdWj7Af5seiAx8IY/vTUKX 8A7A== X-Gm-Message-State: APjAAAVhp2gz01btqVUa4wcgG7miJUkaR+RSHH9Wgpv54sbD89ATplKW 88VDZVPGTcj8B0CG1dySLs/vJw== X-Google-Smtp-Source: APXvYqw0AZKgg6EjKTiDXtbpUIU8qcxoTXpR5EwI5qJzAJRAtq9DzupQa5ZaWWS4hAxfXE0scVi4uw== X-Received: by 2002:a63:c60:: with SMTP id 32mr13363428pgm.42.1561418431055; Mon, 24 Jun 2019 16:20:31 -0700 (PDT) Received: from localhost ([2601:602:9200:a1a5:559b:6f10:667f:4354]) by smtp.googlemail.com with ESMTPSA id m19sm1137712pjn.3.2019.06.24.16.20.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jun 2019 16:20:30 -0700 (PDT) From: Kevin Hilman To: 86zhm782g5.fsf@baylibre.com, Neil Armstrong Subject: Re: [PATCH 8/9] drm: meson: add macro used to enable HDMI PLL In-Reply-To: <86o92n82e1.fsf@baylibre.com> References: <86zhm782g5.fsf@baylibre.com> <86o92n82e1.fsf@baylibre.com> Date: Mon, 24 Jun 2019 16:20:29 -0700 Message-ID: <7hwohawoxu.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_162033_249021_4CF3C469 X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julien Masson , linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Julien Masson writes: > This patch add new macro HHI_HDMI_PLL_CNTL_EN which is used to enable > HDMI PLL. > > Signed-off-by: Julien Masson > --- > drivers/gpu/drm/meson/meson_vclk.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/meson/meson_vclk.c b/drivers/gpu/drm/meson/meson_vclk.c > index e7c2b439d0f7..be6e152fc75a 100644 > --- a/drivers/gpu/drm/meson/meson_vclk.c > +++ b/drivers/gpu/drm/meson/meson_vclk.c > @@ -96,6 +96,7 @@ > #define HHI_VDAC_CNTL1 0x2F8 /* 0xbe offset in data sheet */ > > #define HHI_HDMI_PLL_CNTL 0x320 /* 0xc8 offset in data sheet */ > +#define HHI_HDMI_PLL_CNTL_EN BIT(30) > #define HHI_HDMI_PLL_CNTL2 0x324 /* 0xc9 offset in data sheet */ > #define HHI_HDMI_PLL_CNTL3 0x328 /* 0xca offset in data sheet */ > #define HHI_HDMI_PLL_CNTL4 0x32C /* 0xcb offset in data sheet */ > @@ -468,7 +469,7 @@ void meson_hdmi_pll_set_params(struct meson_drm *priv, unsigned int m, > > /* Enable and unreset */ > regmap_update_bits(priv->hhi, HHI_HDMI_PLL_CNTL, > - 0x7 << 28, 0x4 << 28); > + 0x7 << 28, HHI_HDMI_PLL_CNTL_EN); still using a magic const for the mask. Can use GENMASK() for this? Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel