From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90E18C52D7B for ; Tue, 13 Aug 2024 22:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aL3ypITUp89KlV2kP9EV/LgQKSjWAesVMfZkvBn3ycM=; b=yr0pZIR5/cFjYsilerYOmVYOES SGJn1h4/XuYnQu572eeM5x2mdIolxy6njm8WL6NoqzdxVVJGUJatrxuLTvLJjVeQKlhUYrQstM1W0 c+kAPDFnstzcH5XiVaKSYV/wKGQm6hDNGI7lCfqmuqOX6/YAzLC8vhsM1XGwSCojsORWng2gMc1iC PRmW61iqd0Km+iY/NU+MtWxRpdJJsFhCMMzh7Rsx5cmOU2xttlWCn9Y5apouH9srTX+JgdjY3R0cN m9t/M9znz7VWd3JyvAON77SnU5jHc2o69RcZJzun2Gps+EkgwWCDHDVhwonTfV4Tgl/aYZBrQmBru oC+Xf8HQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdzsZ-000000054XT-0n3P; Tue, 13 Aug 2024 22:20:35 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdzru-000000054RJ-1vN9 for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2024 22:19:57 +0000 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-70d1a74a43bso4407626b3a.1 for ; Tue, 13 Aug 2024 15:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1723587592; x=1724192392; darn=lists.infradead.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=aL3ypITUp89KlV2kP9EV/LgQKSjWAesVMfZkvBn3ycM=; b=Fd/bC/ZErogzHm2Rfmo4igqru+O4XWz7kNOknjqu+ZxL7SROs6NVCdfduIHzXubcqr pvNW8qjWJQF1gilRQj8/360/F4BUKtCQLZEfzXcSXzv0qihtmBYXGE/VaN5ff1Dc+2xe AgAaKnXR3uxhO7JbQZPYkp587h+RYTkip9Gv7kJyo5X3M5rpsKVnWjuyHYPiD2YGtnZH xclaFM21R6Jdz6ReOVIKsxe4baJaRYy6oVgkKR7Z7xHn0vyS5rltbja72QCylZ5IL9pO e/6d0U0Sgli9HSgxSHh70+8mWRp5yYZPuC318AOUByUixInX3MPcACVKb/jixdH0R/hM 7tiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723587592; x=1724192392; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aL3ypITUp89KlV2kP9EV/LgQKSjWAesVMfZkvBn3ycM=; b=snkfES3DZjIo1nCT6UFi446Vj4XLUpiv96rlvBgn8V7x32BW9BExrx8r2yB0KELzrZ jVyFQHlv9mKBailtaAMEZDtCzooOPWFzvADXLICY/t/b6qakuX7tPx+Gsji8Yj783cEi d+xSEuPFF4r3xLRoMij1ferwHkLE6OIH0vKcdINSqj67v5CkhWTwPJwsKOez2kmsKUAW 9bAkGLLYlF9i4obD0Qm63l5L86uC+i1jMkOhXg0+Js2x0Wl9Iqao6tAT+JjRwkJbK0k/ Z34vivkDWAfndDHVOKT0Cxk2qPHnI4Xw8R4BCp81Ul4xYlEapAhVqa/ZKWIrVjBdVUys Gn2g== X-Forwarded-Encrypted: i=1; AJvYcCVOrkUBhXppnvFqQ8ykosjOSkCQ4/lhQt5rb4oa5/2gFdWITOSxmbBtBA6IDXFVIRtKR1T6RWDWV1UqT2jrZf8KbwjHF2V8lojiysvVVCyiO9VAhI4= X-Gm-Message-State: AOJu0YwN/DyjkEgr6pdLW0zcrXzsIDpzIs4PzmIKh5VE1S1HX1XsWL3P Rx0/JnDxlQtgnitQeB/4JrZHfsfiGGRkn9TzQy+WXfO7ioMw4ATV0CxOLUwHE1r9zHR/wRy8Bat f X-Google-Smtp-Source: AGHT+IERf4X277E5hrGy/fd9rT+i98XPhrp8RywcLeI1O0XYaGkfZEZ9GcdyAmWodd41BiVUfiR2YA== X-Received: by 2002:a05:6a00:1151:b0:70d:2e24:af73 with SMTP id d2e1a72fcca58-712673ac8fcmr1029398b3a.24.1723587592549; Tue, 13 Aug 2024 15:19:52 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-712681419d3sm258449b3a.13.2024.08.13.15.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 15:19:52 -0700 (PDT) From: Kevin Hilman To: a0230503 , Dhruva Gole Cc: Markus Schneider-Pargmann , Nishanth Menon , Tero Kristo , Santosh Shilimkar , Vibhore Vardhan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Gerlach , Georgi Vlaev Subject: Re: [PATCH v9 3/4] firmware: ti_sci: Introduce Power Management Ops In-Reply-To: <5f6093e5-cf67-4516-b5b8-929987b05a2e@ti.com> References: <20240809135347.2112634-1-msp@baylibre.com> <20240809135347.2112634-4-msp@baylibre.com> <20240812054717.6lzkt3lxclzec3zy@lcpd911> <7hcymdphky.fsf@baylibre.com> <20240813034935.wqehblov3e5gur3r@lcpd911> <5f6093e5-cf67-4516-b5b8-929987b05a2e@ti.com> Date: Tue, 13 Aug 2024 15:19:51 -0700 Message-ID: <7hy150njzs.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240813_151954_682114_046B74A7 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org a0230503 writes: > On 13/08/24 09:19, Dhruva Gole wrote: >> On Aug 12, 2024 at 14:16:45 -0700, Kevin Hilman wrote: >> [...] >>>>> +/** >>>>> + * struct ti_sci_msg_resp_lpm_wake_reason - Response for TI_SCI_MSG_LPM_WAKE_REASON. >>>>> + * >>>>> + * @hdr: Generic header. >>>>> + * @wake_source: The wake up source that woke soc from LPM. >>>>> + * @wake_timestamp: Timestamp at which soc woke. >>>>> + * >>>>> + * Response to a generic message with message type TI_SCI_MSG_LPM_WAKE_REASON, >>>>> + * used to query the wake up source from low power mode. >>>>> + */ >>>>> +struct ti_sci_msg_resp_lpm_wake_reason { >>>>> + struct ti_sci_msg_hdr hdr; >>>>> + u32 wake_source; >>>>> + u64 wake_timestamp; >>>>> +} __packed; >>>>> + >>>> >>>> It looks like we forgot to update the parameters in this API. >>>> See [1]: >>>> >>>> struct tisci_msg_lpm_wake_reason_req >>>> >>>> We're missing here the wake_pin, mode and 2 rsvd fields as well. >>>> >>>> [1] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html#tisci-msg-lpm-wake-reason >>>> >>> >>> The docs mention how to interpret the pin, but not the mode. This >>> driver should translate this mode number to some human-readable state >>> for better debug messages. >>> >>> Kevin >> >> Agreed, we would all benefit from a logic that prints the human-readable >> state. The way to interpret the mode would be just as: >> https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html#supported-low-power-modes >> >> So for eg. 0x0 = TISCI_MSG_VALUE_SLEEP_MODE_DEEP_SLEEP >> > > Missing the call to ti_sci_msg_cmd_lpm_wake_reason in resume path. > Oops, OK. Will be added for v10. Thanks, Kevin