From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@kernel.org (Kevin Hilman) Date: Tue, 01 Sep 2015 12:33:06 -0700 Subject: [PATCH] ARM: EXYNOS: reset KFC cores when cpu is up In-Reply-To: (Abhilash Kesavan's message of "Tue, 1 Sep 2015 20:17:14 +0530") References: <1441031111-6549-1-git-send-email-parkch98@gmail.com> <7hmvx785wx.fsf@deeprootsystems.com> <55E4D93E.4090307@osg.samsung.com> <55E4EFA3.1050007@samsung.com> Message-ID: <7hy4gq6ikt.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Abhilash Kesavan writes: > On Tue, Sep 1, 2015 at 5:51 AM, Krzysztof Kozlowski > wrote: >> On 01.09.2015 07:46, Javier Martinez Canillas wrote: [...] >>> I posted a similar patch that instead disabling CCI for the XU3 board, >>> it disables in exynos5422-odroidxu3-common.dtsi since all Exynos5422 >>> Odroid boards have the same broken firmware and so the same issue: >>> >>> https://lkml.org/lkml/2015/8/29/59 OK, that makes more sense. Thanks. >>> Krzysztof tested it on an Odroid XU3 Lite and reported that disabling >>> CCI caused some CPUs to fail to boot even with $subject applied: >>> >>> https://lkml.org/lkml/2015/8/29/65 >>> >>> Did you succeed booting all CPUs with CONFIG_ARM_BIG_LITTLE_CPUIDLE >>> enabled and CCI disabled in the the Odroid XU3 DTS? I thought so, but re-testing I'm seein the same results as Krzysztof: >> Indeed. On Odroid XU3 Chanho's patch gives me 8 CPUs up. Disabling CCI >> causes fails on CPU{5,6,7} (Cortex-A15). > > Chanho's patch is for the exynos mcpm back-end. However, when we > disable CCI the mcpm code is bypassed and we default to the code in > exynos' platsmp.c/firmware.c. If the A7s were failing to boot-up then > the reason could have been that Chanho's workaround was not being > executed after applying the CCI disablement patch. > According to the comments the A15s are not booting and so the > exynos_boot_secondary function needs to be checked further. Thanks for the explanation. That makes sense. $SUBJECT fix should be made so it works for both scenarios. Kevin