* [PATCH] ARM: dts: exynos5422-odroidxu3: add INA2xx sensors
@ 2015-01-14 0:03 Kevin Hilman
2015-01-14 15:55 ` Kukjin Kim
2015-01-14 21:25 ` Sjoerd Simons
0 siblings, 2 replies; 5+ messages in thread
From: Kevin Hilman @ 2015-01-14 0:03 UTC (permalink / raw)
To: linux-arm-kernel
From: Kevin Hilman <khilman@linaro.org>
The odroid-xu3 has 4 INA231 current sensors on board which can be
accessed from the Linux via the hwmon interface.
There is one sensor for each of these power rails:
- A15 cluster: VDD_ARM
- A7 cluster: VDD_KFC
- GPU: VDD_G3D
- memory: VDD_MEM
In addition to adding the sensors, LDO26 from the PMIC needs to be
enabled because it's powering these sensor.
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index c29123c0734d..7874da20939f 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -174,6 +174,13 @@
regulator-always-on;
};
+ ldo26_reg: LDO26 {
+ regulator-name = "vdd_ldo26";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-always-on;
+ };
+
buck1_reg: BUCK1 {
regulator-name = "vdd_mif";
regulator-min-microvolt = <800000>;
@@ -257,6 +264,38 @@
};
};
+ i2c_0: i2c at 12C60000 {
+ status = "okay";
+
+ /* A15 cluster: VDD_ARM */
+ ina220 at 40 {
+ compatible = "ti,ina230";
+ reg = <0x40>;
+ shunt-resistor = <10000>;
+ };
+
+ /* memory: VDD_MEM */
+ ina220 at 41 {
+ compatible = "ti,ina230";
+ reg = <0x41>;
+ shunt-resistor = <10000>;
+ };
+
+ /* GPU: VDD_G3D */
+ ina220 at 44 {
+ compatible = "ti,ina230";
+ reg = <0x44>;
+ shunt-resistor = <10000>;
+ };
+
+ /* A7 cluster: VDD_KFC */
+ ina220 at 45 {
+ compatible = "ti,ina230";
+ reg = <0x45>;
+ shunt-resistor = <10000>;
+ };
+ };
+
i2c_2: i2c at 12C80000 {
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <66000>;
--
2.1.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: exynos5422-odroidxu3: add INA2xx sensors
2015-01-14 0:03 [PATCH] ARM: dts: exynos5422-odroidxu3: add INA2xx sensors Kevin Hilman
@ 2015-01-14 15:55 ` Kukjin Kim
2015-01-14 23:42 ` Kevin Hilman
2015-01-14 21:25 ` Sjoerd Simons
1 sibling, 1 reply; 5+ messages in thread
From: Kukjin Kim @ 2015-01-14 15:55 UTC (permalink / raw)
To: linux-arm-kernel
On 01/14/15 09:03, Kevin Hilman wrote:
> From: Kevin Hilman <khilman@linaro.org>
>
> The odroid-xu3 has 4 INA231 current sensors on board which can be
> accessed from the Linux via the hwmon interface.
>
> There is one sensor for each of these power rails:
>
> - A15 cluster: VDD_ARM
> - A7 cluster: VDD_KFC
> - GPU: VDD_G3D
> - memory: VDD_MEM
>
> In addition to adding the sensors, LDO26 from the PMIC needs to be
> enabled because it's powering these sensor.
>
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
>
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index c29123c0734d..7874da20939f 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -174,6 +174,13 @@
> regulator-always-on;
> };
>
> + ldo26_reg: LDO26 {
> + regulator-name = "vdd_ldo26";
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-always-on;
> + };
> +
> buck1_reg: BUCK1 {
> regulator-name = "vdd_mif";
> regulator-min-microvolt = <800000>;
> @@ -257,6 +264,38 @@
> };
> };
>
> + i2c_0: i2c at 12C60000 {
> + status = "okay";
> +
> + /* A15 cluster: VDD_ARM */
> + ina220 at 40 {
> + compatible = "ti,ina230";
> + reg = <0x40>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* memory: VDD_MEM */
> + ina220 at 41 {
> + compatible = "ti,ina230";
> + reg = <0x41>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* GPU: VDD_G3D */
> + ina220 at 44 {
> + compatible = "ti,ina230";
> + reg = <0x44>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* A7 cluster: VDD_KFC */
> + ina220 at 45 {
> + compatible = "ti,ina230";
> + reg = <0x45>;
> + shunt-resistor = <10000>;
> + };
> + };
> +
> i2c_2: i2c at 12C80000 {
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-max-bus-freq = <66000>;
Looks good to me and applied. To be honest, I'm not sure about the
values in the node of shunt-resistor though ;)
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: exynos5422-odroidxu3: add INA2xx sensors
2015-01-14 0:03 [PATCH] ARM: dts: exynos5422-odroidxu3: add INA2xx sensors Kevin Hilman
2015-01-14 15:55 ` Kukjin Kim
@ 2015-01-14 21:25 ` Sjoerd Simons
2015-01-14 23:44 ` Kevin Hilman
1 sibling, 1 reply; 5+ messages in thread
From: Sjoerd Simons @ 2015-01-14 21:25 UTC (permalink / raw)
To: linux-arm-kernel
Hey kevin,
On Tue, 2015-01-13 at 16:03 -0800, Kevin Hilman wrote:
> From: Kevin Hilman <khilman@linaro.org>
>
> The odroid-xu3 has 4 INA231 current sensors on board which can be
> accessed from the Linux via the hwmon interface.
>
> There is one sensor for each of these power rails:
>
> - A15 cluster: VDD_ARM
> - A7 cluster: VDD_KFC
> - GPU: VDD_G3D
> - memory: VDD_MEM
>
> In addition to adding the sensors, LDO26 from the PMIC needs to be
> enabled because it's powering these sensor.
>
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
>
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index c29123c0734d..7874da20939f 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -257,6 +264,38 @@
> };
> };
>
> + i2c_0: i2c at 12C60000 {
> + status = "okay";
> +
> + /* A15 cluster: VDD_ARM */
> + ina220 at 40 {
^ ina231 at 40 ?
> + compatible = "ti,ina230";
This feels incredibly nitpicky, but would it not better to use ti,ina231
as it's an INA231 chip not a INA230? (And add the compatibility string
to the driver)
--
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6170 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150114/6ab1059a/attachment.bin>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: exynos5422-odroidxu3: add INA2xx sensors
2015-01-14 15:55 ` Kukjin Kim
@ 2015-01-14 23:42 ` Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2015-01-14 23:42 UTC (permalink / raw)
To: linux-arm-kernel
Kukjin Kim <kgene@kernel.org> writes:
> On 01/14/15 09:03, Kevin Hilman wrote:
>> From: Kevin Hilman <khilman@linaro.org>
>>
>> The odroid-xu3 has 4 INA231 current sensors on board which can be
>> accessed from the Linux via the hwmon interface.
>>
>> There is one sensor for each of these power rails:
>>
>> - A15 cluster: VDD_ARM
>> - A7 cluster: VDD_KFC
>> - GPU: VDD_G3D
>> - memory: VDD_MEM
>>
>> In addition to adding the sensors, LDO26 from the PMIC needs to be
>> enabled because it's powering these sensor.
>>
>> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>> Signed-off-by: Kevin Hilman <khilman@linaro.org>
>> ---
>> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
>>
>> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index c29123c0734d..7874da20939f 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -174,6 +174,13 @@
>> regulator-always-on;
>> };
>>
>> + ldo26_reg: LDO26 {
>> + regulator-name = "vdd_ldo26";
>> + regulator-min-microvolt = <3000000>;
>> + regulator-max-microvolt = <3000000>;
>> + regulator-always-on;
>> + };
>> +
>> buck1_reg: BUCK1 {
>> regulator-name = "vdd_mif";
>> regulator-min-microvolt = <800000>;
>> @@ -257,6 +264,38 @@
>> };
>> };
>>
>> + i2c_0: i2c at 12C60000 {
>> + status = "okay";
>> +
>> + /* A15 cluster: VDD_ARM */
>> + ina220 at 40 {
>> + compatible = "ti,ina230";
>> + reg = <0x40>;
>> + shunt-resistor = <10000>;
>> + };
>> +
>> + /* memory: VDD_MEM */
>> + ina220 at 41 {
>> + compatible = "ti,ina230";
>> + reg = <0x41>;
>> + shunt-resistor = <10000>;
>> + };
>> +
>> + /* GPU: VDD_G3D */
>> + ina220 at 44 {
>> + compatible = "ti,ina230";
>> + reg = <0x44>;
>> + shunt-resistor = <10000>;
>> + };
>> +
>> + /* A7 cluster: VDD_KFC */
>> + ina220 at 45 {
>> + compatible = "ti,ina230";
>> + reg = <0x45>;
>> + shunt-resistor = <10000>;
>> + };
>> + };
>> +
>> i2c_2: i2c at 12C80000 {
>> samsung,i2c-sda-delay = <100>;
>> samsung,i2c-max-bus-freq = <66000>;
>
> Looks good to me and applied. To be honest, I'm not sure about the
> values in the node of shunt-resistor though ;)
I didn't measure the values, but used the values from the DTS that's
part of the hardkernel tree.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: exynos5422-odroidxu3: add INA2xx sensors
2015-01-14 21:25 ` Sjoerd Simons
@ 2015-01-14 23:44 ` Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2015-01-14 23:44 UTC (permalink / raw)
To: linux-arm-kernel
Sjoerd Simons <sjoerd.simons@collabora.co.uk> writes:
> Hey kevin,
>
> On Tue, 2015-01-13 at 16:03 -0800, Kevin Hilman wrote:
>> From: Kevin Hilman <khilman@linaro.org>
>>
>> The odroid-xu3 has 4 INA231 current sensors on board which can be
>> accessed from the Linux via the hwmon interface.
>>
>> There is one sensor for each of these power rails:
>>
>> - A15 cluster: VDD_ARM
>> - A7 cluster: VDD_KFC
>> - GPU: VDD_G3D
>> - memory: VDD_MEM
>>
>> In addition to adding the sensors, LDO26 from the PMIC needs to be
>> enabled because it's powering these sensor.
>>
>> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>> Signed-off-by: Kevin Hilman <khilman@linaro.org>
>> ---
>> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
>>
>> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index c29123c0734d..7874da20939f 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -257,6 +264,38 @@
>> };
>> };
>>
>> + i2c_0: i2c at 12C60000 {
>> + status = "okay";
>> +
>> + /* A15 cluster: VDD_ARM */
>> + ina220 at 40 {
> ^ ina231 at 40 ?
>> + compatible = "ti,ina230";
>
> This feels incredibly nitpicky, but would it not better to use ti,ina231
> as it's an INA231 chip not a INA230? (And add the compatibility string
> to the driver)
Hmm, you're right. Until recently, I thought these were INA230s, but
squinted enough at the schematic yesterday to notice they were marked as
INA231, so updated the changelog, but not the DTS.
Will re-spin with a compatible string update to the driver.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-14 23:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-14 0:03 [PATCH] ARM: dts: exynos5422-odroidxu3: add INA2xx sensors Kevin Hilman
2015-01-14 15:55 ` Kukjin Kim
2015-01-14 23:42 ` Kevin Hilman
2015-01-14 21:25 ` Sjoerd Simons
2015-01-14 23:44 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).