From: Kevin Hilman <khilman@baylibre.com>
To: Andrew Davis <afd@ti.com>, Tony Lindgren <tony@atomide.com>,
Vignesh R <vigneshr@ti.com>,
Andreas Kemnade <andreas@kemnade.info>,
Roger Quadros <rogerq@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Davis <afd@ti.com>
Subject: Re: [PATCH v2 1/8] i2c: omap: Drop bit shift for I2C register addresses
Date: Mon, 21 Sep 2026 08:53:50 -0700 [thread overview]
Message-ID: <7hzexad2i9.fsf@baylibre.com> (raw)
In-Reply-To: <20260908154223.116074-2-afd@ti.com>
Andrew Davis <afd@ti.com> writes:
> The OMAP7xx devices used a register address shift of 1, but this device
> has long since been removed from the kernel. So now no remaining board
> device uses a shift other than 2, and no DT supported platform ever did.
> We can drop this flag and use the pre-shifted register addresses. This
> simplifies the register access.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Feel free to take this with the rest of the drivers/i2c/ patches.
Kevin
next prev parent reply other threads:[~2026-09-21 15:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 15:42 [PATCH v2 0/8] OMAP I2C driver cleanups Andrew Davis
2026-09-08 15:42 ` [PATCH v2 1/8] i2c: omap: Drop bit shift for I2C register addresses Andrew Davis
2026-09-21 15:53 ` Kevin Hilman [this message]
2026-09-08 15:42 ` [PATCH v2 2/8] i2c: omap: Remove unused is_rdr and is_xdr variables Andrew Davis
2026-09-08 15:42 ` [PATCH v2 3/8] i2c: omap: Use devm_pm_runtime_enable() helper Andrew Davis
2026-09-08 15:42 ` [PATCH v2 4/8] i2c: omap: Combine event flags register definitions Andrew Davis
2026-09-08 15:42 ` [PATCH v2 5/8] i2c: omap: Use bool for flag values Andrew Davis
2026-09-08 15:42 ` [PATCH v2 6/8] i2c: omap: Make reset bit name match register name Andrew Davis
2026-09-08 15:42 ` [PATCH v2 7/8] i2c: omap: Switch to using BIT and GENMASK Andrew Davis
2026-09-08 15:42 ` [PATCH v2 8/8] i2c: omap: Add OMAP_I2C_BUF_{TX,RX}TRSH definitions Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hzexad2i9.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=afd@ti.com \
--cc=andi.shyti@kernel.org \
--cc=andreas@kemnade.info \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox