From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/8 resend] dw_dmac: call dwc_scan_descriptor from dwc_issue_pending only if active list is empty
Date: Mon, 28 Feb 2011 16:11:18 +0530 [thread overview]
Message-ID: <8003205172278ef36cfca1fd50a54cb143fad958.1298889267.git.viresh.kumar@st.com> (raw)
In-Reply-To: <cover.1298889267.git.viresh.kumar@st.com>
dwc_scan_descriptor was called even when there were descriptors in active list.
Checking if active list is empty or not.
Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
drivers/dma/dw_dmac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 6dd03b0..3bf4772 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -848,7 +848,7 @@ static void dwc_issue_pending(struct dma_chan *chan)
struct dw_dma_chan *dwc = to_dw_dma_chan(chan);
spin_lock_bh(&dwc->lock);
- if (!list_empty(&dwc->queue))
+ if (!list_empty(&dwc->queue) && list_empty(&dwc->active_list))
dwc_scan_descriptors(to_dw_dma(chan->device), dwc);
spin_unlock_bh(&dwc->lock);
}
--
1.7.2.2
next prev parent reply other threads:[~2011-02-28 10:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 10:41 [PATCH 0/8 resend] dw_dmac: Extending support & minor fixes Viresh Kumar
2011-02-28 10:41 ` [PATCH 1/8 resend] dw_dmac: Remove compilation dependency from AVR32 Viresh Kumar
2011-03-02 16:46 ` Koul, Vinod
2011-03-03 3:42 ` viresh kumar
2011-03-03 4:19 ` Shiraz Hashim
2011-03-05 11:38 ` Russell King - ARM Linux
2011-03-07 4:15 ` viresh kumar
2011-02-28 10:41 ` [PATCH 2/8 resend] dw_dmac: Move single descriptor from dwc->queue to dwc->active_list in dwc_complete_all Viresh Kumar
2011-02-28 10:41 ` Viresh Kumar [this message]
2011-02-28 10:46 ` [PATCH 3/8 resend] dw_dmac: call dwc_scan_descriptor from dwc_issue_pending only if active list is empty Jamie Iles
2011-02-28 10:58 ` viresh kumar
2011-02-28 10:41 ` [PATCH 4/8 resend] dw_dmac: calling dwc_scan_descriptors from dwc_tx_status() after taking lock Viresh Kumar
2011-03-02 18:13 ` Koul, Vinod
2011-03-03 3:44 ` viresh kumar
2011-02-28 10:41 ` [PATCH 5/8 resend] dw_dmac: adding support for 64 bit access width for memcpy xfers Viresh Kumar
2011-02-28 10:41 ` [PATCH 6/8 resend] dw_dmac: Mark all tx_descriptors with DMA_CRTL_ACK after xfer finish Viresh Kumar
2011-02-28 12:05 ` Sergei Shtylyov
2011-02-28 15:04 ` viresh kumar
2011-03-02 18:34 ` Koul, Vinod
2011-03-03 3:45 ` viresh kumar
2011-02-28 10:41 ` [PATCH 7/8 resend] dw_dmac.c: Pass Channel Allocation Order from platform_data Viresh Kumar
2011-03-02 18:37 ` Koul, Vinod
2011-03-03 3:48 ` viresh kumar
2011-02-28 10:41 ` [PATCH 8/8 resend] dw_dmac.c: Pass Channel Priority " Viresh Kumar
2011-03-02 18:46 ` Koul, Vinod
2011-03-03 3:51 ` viresh kumar
2011-03-02 16:39 ` [PATCH 0/8 resend] dw_dmac: Extending support & minor fixes Koul, Vinod
2011-03-03 3:40 ` viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8003205172278ef36cfca1fd50a54cb143fad958.1298889267.git.viresh.kumar@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).