From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C73C433E0 for ; Fri, 29 Jan 2021 18:44:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07A7864DE7 for ; Fri, 29 Jan 2021 18:44:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07A7864DE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VgNTkNjawUA5iDfovg+GPywXa4ApLoK2SG0jEv9C32w=; b=3JNiMFG/sJKQ8y08jK0uFQwrg 8eMaSxpOscqfj1fb0DH8FySDhviVXyxmb2jAB/3CaCBMQFqT+sxfauGkUE6PeOkV+1wzuV6GhVftY o+TQd7+jaMMfHZZWmgcI3f3BAskFHz4Tuakw/1lZW7jjenAvwAgwOg92fIId8z2+3qf+d1MnAaUrM aJjWoT71uVdIX5KONU9D92yk/JJPcn+JQxoIi+O/mcyDwzMWSVJe8Fci1cszG2dZvG6WgVsijvniw zBeCzgPBt6t7kW32oW5PbL3bODuALpuThdDL0waD++I1voJLJcUz2YvJX2WzAYDYQ+vKgVhKI87TS p0wpltgBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5YjU-0002vV-Mi; Fri, 29 Jan 2021 18:43:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5YjS-0002v6-P5 for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 18:42:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 50C0813A1; Fri, 29 Jan 2021 10:42:46 -0800 (PST) Received: from [10.37.12.11] (unknown [10.37.12.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 97AF73F885; Fri, 29 Jan 2021 10:42:43 -0800 (PST) Subject: Re: [PATCH v9 3/4] kasan: Add report for async mode From: Vincenzo Frascino To: Andrey Konovalov , Alexander Potapenko References: <20210126134603.49759-1-vincenzo.frascino@arm.com> <20210126134603.49759-4-vincenzo.frascino@arm.com> Message-ID: <8021dbc4-8745-2430-8d52-6236ae8c47c7@arm.com> Date: Fri, 29 Jan 2021 18:46:38 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_134258_908850_3432B3DD X-CRM114-Status: GOOD ( 13.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Branislav Rankov , Catalin Marinas , Marco Elver , kasan-dev , LKML , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Will Deacon , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrey, On 1/29/21 6:16 PM, Vincenzo Frascino wrote: > What I meant is instead of: > > if (addr) trace_error_report_end(...); > > you might want to do: > > if (!IS_ENABLED(CONFIG_KASAN_HW_TAGS)) trace_error_report_end(...); > > because, could make sense to trace 0 in other cases? > > I could not find the implementation of trace_error_report_end() hence I am not > really sure on what it does. I figured it out how trace_error_report_end() works. And in doing that I realized that the problem is sync vs async, hence I agree with what you are proposing: if (addr) trace_error_report_end(...); I will post v10 shortly. If we want to trace the async mode we can improve it in -rc1. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel