From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F8DC49ED7 for ; Fri, 13 Sep 2019 07:39:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0ACF20678 for ; Fri, 13 Sep 2019 07:39:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AAxA185i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0ACF20678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=protonic.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=moU5wx51z4uZJydh92NESO2aj2EkkWL+eSobAoLDa30=; b=AAxA185iHv9pN7ob8KEZKp0fU sJS3v/NnfFJgN0INWU40JdnH+N7KdZKVq7sQY2wd04uwkzpbLHApJMqdq0QLOHr0E218rRagKVcOT 71KyXH70QS3ZHWxfb7nZ7fNaqmwJOs91Y+7ZD5EQzw8umZRjBCtypDUJU5BnP8tlE6h/v4SCLSHpA 4ySVhjveJpc+nXHSLCOgIEuSG4afA3jGPIwFkYTejqtsEeIbjV0YW47jmwseNEcqHm3m95uLLxvEM WgBzvOJD946THbeNDr8g+oVQ/ISaKLQTmzq99mdqihQZK8Nah8Wf0xESN9DDGnVFk0l3h9AaION8F 4tifvqRnA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8gAR-0003pW-Sw; Fri, 13 Sep 2019 07:38:55 +0000 Received: from protonic.xs4all.nl ([83.163.252.89] helo=protonic.nl) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8g9w-0003f3-R3 for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2019 07:38:27 +0000 Received: from webmail.promanet.nl (edge2.prtnl [192.168.1.170]) by sparta (Postfix) with ESMTP id CAC6B44A00CB; Fri, 13 Sep 2019 09:32:52 +0200 (CEST) MIME-Version: 1.0 Date: Fri, 13 Sep 2019 09:30:51 +0200 From: robin To: Dmitry Torokhov Subject: Re: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q In-Reply-To: <20190912201300.GA636@penguin> References: <20190904062329.97520-1-robin@protonic.nl> <20190912201300.GA636@penguin> Message-ID: <803592d161b9ca75d6ac1c2c54e891a1@protonic.nl> X-Sender: robin@protonic.nl User-Agent: Roundcube Webmail/1.3.6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190913_003825_603356_48A2F0CC X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Adam Ford , Marco Felsch , "linux-kernel @ vger . kernel . org" , Pengutronix Kernel Team , "linux-input @ vger . kernel . org" , RobinGong , Shawn Guo , "linux-arm-kernel @ lists . infradead . org" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dmitry, On 2019-09-12 22:13, Dmitry Torokhov wrote: > Hi Robin, > > On Wed, Sep 04, 2019 at 06:23:29AM +0000, Robin van der Gracht wrote: >> The first generation i.MX6 processors does not send an interrupt when >> the >> power key is pressed. It sends a power down request interrupt if the >> key is >> released before a hard shutdown (5 second press). This should allow >> software to bring down the SoC safely. >> >> For this driver to work as a regular power key with the older SoCs, we >> need >> to send a keypress AND release when we get the power down request irq. >> >> Signed-off-by: Robin van der Gracht >> --- >> >> Changes v2 -> v3: >> - Drop alt compatible string for identifying first revision snvs >> hardware, >> read minor revision from register instead. >> - Drop imx6qdl.dtsi modification and device-tree binding >> documentation. >> - Add an additional input_sync() to create 2 seperate input reports >> for press >> and release. >> >> drivers/input/keyboard/Kconfig | 2 +- >> drivers/input/keyboard/snvs_pwrkey.c | 28 >> ++++++++++++++++++++++++++-- >> 2 files changed, 27 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/input/keyboard/Kconfig >> b/drivers/input/keyboard/Kconfig >> index 7c4f19dab34f..937e58da5ce1 100644 >> --- a/drivers/input/keyboard/Kconfig >> +++ b/drivers/input/keyboard/Kconfig >> @@ -436,7 +436,7 @@ config KEYBOARD_SNVS_PWRKEY >> depends on OF >> help >> This is the snvs powerkey driver for the Freescale i.MX >> application >> - processors that are newer than i.MX6 SX. >> + processors. >> >> To compile this driver as a module, choose M here; the >> module will be called snvs_pwrkey. >> diff --git a/drivers/input/keyboard/snvs_pwrkey.c >> b/drivers/input/keyboard/snvs_pwrkey.c >> index 5342d8d45f81..828580eee0d2 100644 >> --- a/drivers/input/keyboard/snvs_pwrkey.c >> +++ b/drivers/input/keyboard/snvs_pwrkey.c >> @@ -19,6 +19,7 @@ >> #include >> #include >> >> +#define SNVS_HPVIDR1_REG 0xF8 >> #define SNVS_LPSR_REG 0x4C /* LP Status Register */ >> #define SNVS_LPCR_REG 0x38 /* LP Control Register */ >> #define SNVS_HPSR_REG 0x14 >> @@ -37,6 +38,7 @@ struct pwrkey_drv_data { >> int wakeup; >> struct timer_list check_timer; >> struct input_dev *input; >> + u8 minor_rev; >> }; >> >> static void imx_imx_snvs_check_for_events(struct timer_list *t) >> @@ -45,6 +47,20 @@ static void imx_imx_snvs_check_for_events(struct >> timer_list *t) >> struct input_dev *input = pdata->input; >> u32 state; >> >> + if (pdata->minor_rev == 0) { >> + /* >> + * The first generation i.MX6 SoCs only sends an interrupt on >> + * button release. To mimic power-key usage, we'll prepend a >> + * press event. >> + */ >> + input_report_key(input, pdata->keycode, 1); >> + input_sync(input); >> + input_report_key(input, pdata->keycode, 0); >> + input_sync(input); >> + pm_relax(input->dev.parent); >> + return; >> + } >> + >> regmap_read(pdata->snvs, SNVS_HPSR_REG, &state); >> state = state & SNVS_HPSR_BTN ? 1 : 0; >> >> @@ -67,13 +83,17 @@ static irqreturn_t imx_snvs_pwrkey_interrupt(int >> irq, void *dev_id) >> { >> struct platform_device *pdev = dev_id; >> struct pwrkey_drv_data *pdata = platform_get_drvdata(pdev); >> + unsigned long expire = jiffies; >> u32 lp_status; >> >> pm_wakeup_event(pdata->input->dev.parent, 0); >> >> regmap_read(pdata->snvs, SNVS_LPSR_REG, &lp_status); >> - if (lp_status & SNVS_LPSR_SPO) >> - mod_timer(&pdata->check_timer, jiffies + >> msecs_to_jiffies(DEBOUNCE_TIME)); >> + if (lp_status & SNVS_LPSR_SPO) { >> + if (pdata->minor_rev > 0) >> + expire = jiffies + msecs_to_jiffies(DEBOUNCE_TIME); >> + mod_timer(&pdata->check_timer, expire); > > Why do we even need to fire the timer in case of the first generation > hardware? Just send press and release events directly from the ISR. Robin Gong proposed to move the code to imx_imx_snvs_check_for_events() to improve readability and unload the ISR. But since I, eventually, couldn't use the existing handling in imx_imx_snvs_check_for_events(), I do see why you're asking. I'll move the code to the ISR and submit a new patch. Robin van der Gracht _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel