From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C03CCCD128A for ; Sat, 6 Apr 2024 05:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OIiVoA4J5P+Q5NzutExkCv25cg7k274tCjs0UNfRMk4=; b=DQj+R2wXrEoOQX AqKdRPyWHtuXziL4BwAFTX1scgTHv/J4Tx6K2De8r4hIfRTXgTK39wQvCpJsmpH6YhSKIOGuakgZz dcUbjIjzjMI8Xd2Uk3zOz3XfheNBH5b3WqR++AxhpYhRudxQ8gu/p9sy9gupY5g8R3MLIWUHOabU5 Dgwfz5JE2zxJwO0PvLwg8YuGMnD5XyH30rpgII3pL9pK1mXnJdQXBaV03efNfBSDVr/4BHHrXdWN2 c9Nf6NWliUVPpyd2FzRkauNvGkLna9s7gnhOP1ZINoyYD7mK/KHpjEHChcC8AjAzdNPf+IDS/aXG6 F19pozRjhIZ/E8PMXxhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsydm-00000009in6-2ZKU; Sat, 06 Apr 2024 05:30:58 +0000 Received: from mail-108-mta69.mxroute.com ([136.175.108.69]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsydj-00000009imf-38aR for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2024 05:30:57 +0000 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta69.mxroute.com (ZoneMTA) with ESMTPSA id 18eb1deb1d70003bea.009 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 06 Apr 2024 05:25:45 +0000 X-Zone-Loop: be7b83eef665decac7a4aeaccdaf85f46ab7d63bbbc8 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sz1o3+H/QzcFhJgMgxzNEIq38+fbX0fuDgjyR3Z3QQc=; b=yRxZ3zybwPCDOXYc6dTeGjFcrD oJ/ez3YSCH/U3R+W7HZ+fcllfTNo6nDrKK/J6LtIS+6pGlvAFrg1BKy+05tElSeHU+XVi9lLN7Jjq N9wWf/YR2FfU3yz4kxdskDLVFCSxd7zRrbZErNyZKiZ8MEh3oScdzDZhatOoB/q3+riVjlqTrkRy7 Hqeh+nMcad2X60AuJoWOblCKmKuwLSR4xq2i1LF1f++LiJf/cQxwpQUlP0h1QbgLNhKUUez/MFVEI p5YxnOGH1HDkg3IQGhGvjSPxDKypqt8FcRQbW50njJ2QApLlk+PAT2yoMCtocDpSVBdl4iJWE7/by Vyq36ttA==; Message-ID: <803b0bd3-e615-41c1-888e-69b6ecca0b8a@luigi311.com> Date: Fri, 5 Apr 2024 23:25:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/25] media: i2c: imx258: Add support for running on 2 CSI data lanes To: Pavel Machek Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20240403150355.189229-1-git@luigi311.com> <20240403150355.189229-10-git@luigi311.com> Content-Language: en-US From: Luis Garcia In-Reply-To: X-Authenticated-Id: git@luigi311.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_223056_002954_4A56E3B8 X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/3/24 12:45, Pavel Machek wrote: > Hi! > >> +/* >> + * 4208x3120 @ 30 fps needs 1267Mbps/lane, 4 lanes. >> + * To avoid further computation of clock settings, adopt the same per >> + * lane data rate when using 2 lanes, thus allowing a maximum of 15fps. >> + */ >> +static const struct imx258_reg mipi_1267mbps_19_2mhz_2l[] = { >> + { 0x0136, 0x13 }, >> + { 0x0137, 0x33 }, >> + { 0x0301, 0x0A }, >> + { 0x0303, 0x02 }, >> + { 0x0305, 0x03 }, >> + { 0x0306, 0x00 }, >> + { 0x0307, 0xC6 }, >> + { 0x0309, 0x0A }, >> + { 0x030B, 0x01 }, >> + { 0x030D, 0x02 }, >> + { 0x030E, 0x00 }, >> + { 0x030F, 0xD8 }, >> + { 0x0310, 0x00 }, >> + >> + { 0x0114, 0x01 }, >> + { 0x0820, 0x09 }, >> + { 0x0821, 0xa6 }, >> + { 0x0822, 0x66 }, >> + { 0x0823, 0x66 }, >> +}; >> + >> +static const struct imx258_reg mipi_1267mbps_19_2mhz_4l[] = { >> { 0x0136, 0x13 }, >> { 0x0137, 0x33 }, >> { 0x0301, 0x05 }, > > I wish we did not have to copy all the magic values like this. > > Best regards, > Pavel > no kidding, magic values everywhere.... it makes it annoying for me to move things around because they all start to look similar. Down the line we added in more defined names so its not as bad but still its bad lol. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel