From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2624EC63798 for ; Sat, 28 Nov 2020 20:49:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC709221FF for ; Sat, 28 Nov 2020 20:49:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xy72W7C4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC709221FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/b/1ZtzeKfX73V+Q7KM+exuHoly3+FTVibiRkrhqbGY=; b=Xy72W7C4JjAWRdFA10ta3XrgH tdbgEem0vfl0weoUq2EBFdPIp923W3Tryls/jZvGICwdPm43p5c+OSGhHv+KUF3AwkL00br3qJL7F L1B6ELJjPSeW9GrOJPjBGuTcgoX0vzc9bD7F2vJPxPNnShZhVS0JQIT3YgYRj1FgcrTHteqhd89O9 2PFA9qtsJPYTxWSPKFcHOpwuyWbieCs1nOZqIGo0fUl3AMNZ4dFVgIiyO4k/uryArmQUsfRZdK36P rJPVZTRhkth7MK4anmp8ZQk+QLNvRMoOiYEza9f6UxZJzPE2jYlNs8cWWu7SRcW0Em7v0UY1SNoCY 5iqCvTv8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kj78X-0000ap-74; Sat, 28 Nov 2020 20:48:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kj78U-0000aV-Fr for linux-arm-kernel@lists.infradead.org; Sat, 28 Nov 2020 20:48:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F7C030E; Sat, 28 Nov 2020 12:48:00 -0800 (PST) Received: from [192.168.2.22] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0B0F3F23F; Sat, 28 Nov 2020 12:47:58 -0800 (PST) Subject: Re: [RESEND PATCH 07/19] arm64: dts: allwinner: A100: Add PMU mode To: Frank Lee , tiny.windzz@gmail.com References: <5aede9ac5069e61913905617b20cdcf1ec84fe26.1604988979.git.frank@allwinnertech.com> From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Organization: ARM Ltd. Message-ID: <803fa6fb-31a2-e90d-a7cc-98f282cec2b1@arm.com> Date: Sat, 28 Nov 2020 20:47:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <5aede9ac5069e61913905617b20cdcf1ec84fe26.1604988979.git.frank@allwinnertech.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201128_154802_670110_0E75F5AA X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/11/2020 06:31, Frank Lee wrote: Hi, > From: Yangtao Li > > Add the Performance Monitoring Unit (PMU) device tree node to the A100 > .dtsi, which tells DT users which interrupts are triggered by PMU overflow > events on each core. Have you tested that the interrupts actually work? For the A64 there were wrong in the manual, and we realised only later. "perf stat" works even without interrupts, but "perf record" requires interrupts, and will return empty-handed if they don't work. Can you confirm this? > > Signed-off-by: Yangtao Li Without being able to test or verify this, the nodes looks correct, so: Reviewed-by: Andre Przywara Cheers, Andre > --- > arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > index c34ed8045363..01ff53b5a7a8 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > @@ -25,21 +25,21 @@ cpu0: cpu@0 { > enable-method = "psci"; > }; > > - cpu@1 { > + cpu1: cpu@1 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > reg = <0x1>; > enable-method = "psci"; > }; > > - cpu@2 { > + cpu2: cpu@2 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > reg = <0x2>; > enable-method = "psci"; > }; > > - cpu@3 { > + cpu3: cpu@3 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > reg = <0x3>; > @@ -47,6 +47,15 @@ cpu@3 { > }; > }; > > + pmu { > + compatible = "arm,cortex-a53-pmu"; > + interrupts = , > + , > + , > + ; > + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>; > + }; > + > psci { > compatible = "arm,psci-1.0"; > method = "smc"; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel