From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94020C282EC for ; Tue, 11 Mar 2025 22:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FQVMT0SYg7MWzDSI+5t//19e57L1PwaokMNGGmBaDBc=; b=sOYVsA9rAt3OIlvQUmT4fSy8qr UeYRe7o+9ASlUZR4jlKBMru/rfdrsDKlQo/+McPce/26NZJIkSh8oZ26CWq9DkSPvqNlV8rFWf9wY moeSJUjKe1+W2NG+NV3WlhCPVBRKXRNFIK0cfFHtZ7sEOpHfPJXiT5uDMX3rOmu9QCoYpu+upuruc dxXXRdGjOKi5/lWMXFmv+hHDsMuoutSAdlNw7GQUVu4743gPcleW5tjTsOq13QacFYGJyT9AsyH44 DZf7hoUYM4xyxnTQCZfcRSl4fqpWVdmYhLasiAn7wv5MfkBe5TcLYkPHdPPOX4anKrk3l6WPMgLbN +DUWsf0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ts852-000000076OB-3K87; Tue, 11 Mar 2025 22:28:08 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ts83O-000000076Fg-0vAS for linux-arm-kernel@lists.infradead.org; Tue, 11 Mar 2025 22:26:27 +0000 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3913d129c1aso222585f8f.0 for ; Tue, 11 Mar 2025 15:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741731983; x=1742336783; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FQVMT0SYg7MWzDSI+5t//19e57L1PwaokMNGGmBaDBc=; b=e7rJ8YjxLJkQfuZWdJ7UgxtxBd786urbYMRR5GGJM0p6eiq8SsXHqTv9vGyNGtkL3R ctfKQk7qS/Kc/z4JLqcq8WWYLCQjEsIKRVCjPPbR2DRzwRJl2uCtKHfXPmvCfsYSX0/k cka6CuMle7fA8WS2Pa63Cm3O+Nk6vzGj/4jG61EijDV1YQJMbE6cClc/0vFw78z8VLlO KtAh4ePyo1qdXKooUIyO/Z0MqUP/zB1WPx3vS2Rsv6gaQwoXck37EZTG03qZhN4TbS/R iXRN+FKYDKTlJZoD27nxET3I21lWPrE4nKt7m+BvAW7w1ZdWjPBQFfMytEX11rR0Ivly pbMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741731983; x=1742336783; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FQVMT0SYg7MWzDSI+5t//19e57L1PwaokMNGGmBaDBc=; b=n//4ylgJCy3XVhepzn/Hl1Apbuv4dumta9AfhXbav7xox4DeoZs836615qiec4pN8/ UVSMXBz2OrfWxwFs9Qhcehy2zFW8PNiE3zG3d2WKrmX3ot7xpYDfyPFX9WE3m0JxMVwH WyBF4KMEyW8C0gO7RD/ItzhLBmcqBsKvCKq///w4ApbnYafRu0LnT9035yIThgyA4Fz1 ScyypB1d96BYs5roAwBxTdSHqxxZ5Mhi5Ft5VHaUskzOy8E9tMCU8RnOI0S7fnyb8rYI ZXBbEnh/Sq89I/Z6tYcSezTROdtMjWl99GjyNOHhvC0Y8328eXu6pAtkZtFltCNhUzA7 CVuw== X-Forwarded-Encrypted: i=1; AJvYcCWqUpYNyMXDoe73D/WjjkwXtVO5SXYNqZdhAwjb04qbEt9qnAUc8B5rEzC5H7Qbd0da6SVaO9HccxIP2atdouwy@lists.infradead.org X-Gm-Message-State: AOJu0YwqkVhj9U1Dio+EjMPhPksHdzbnOiaASX9VB/4Noy8jUywFrLmB k5o6Bwm/EG3vCxbLYq5PbcFWriKCdpzQcTpgSoSHLQC66Uan3oSq X-Gm-Gg: ASbGnctrNvBzn6BoR+fc7ugf4WGQZu7fg4nUZjx1S7IQ4OdcDF5H8BLF3h9emx8FoJg BtcJy1v53kfDNhjevZqiuczfccB2moXJDEiBNh6/NTg1ckqnVRB5ojIHfjS7+Vay+h/Hz10cf9g qwWRWMJnEXg+K1p8nFOAvG0Uk/zPGPDKfR5WBL26Oge4P9JZcxgzoYa4CLye7IQHMgyTV/Bxzhr EeJUaTYnCRnthZb6DJ4shLYO5btP+/c1gt3+r0+PQXL8eyrBU55tD6/X3LZ+WBn3v/TQ2WUnBx7 lPO1LO97qOiagBUAT4ULlBleLBJyPgJQybHBrnAZBY5nYk8PW3w= X-Google-Smtp-Source: AGHT+IGRf3+rxXg9y5r2+u9zmmrMjmX28RK97Boc7y5I6WN3NsKiYYv7R2o+DZaG/J3zfHe+qJasNg== X-Received: by 2002:a5d:6d87:0:b0:391:65c:1b05 with SMTP id ffacd0b85a97d-3926c5a5dfamr6122321f8f.11.1741731983075; Tue, 11 Mar 2025 15:26:23 -0700 (PDT) Received: from [192.168.0.100] ([188.27.130.21]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfba8a9sm19294599f8f.9.2025.03.11.15.26.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Mar 2025 15:26:21 -0700 (PDT) Message-ID: <80456f67-1742-4b54-98dd-0985f95c376e@gmail.com> Date: Wed, 12 Mar 2025 00:26:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 11/16] dt-bindings: media: i2c: add MAX9296A, MAX96716A, MAX96792A To: Rob Herring Cc: Tomi Valkeinen , Cosmin Tanislav , Mauro Carvalho Chehab , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Julien Massot , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Bjorn Andersson , Geert Uytterhoeven , Dmitry Baryshkov , Arnd Bergmann , Taniya Das , Biju Das , =?UTF-8?Q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , Eric Biggers , Javier Carrasco , Ross Burton , Hans Verkuil , Sakari Ailus , Laurent Pinchart , Zhi Mao , Kieran Bingham , Dongcheng Yan , AngeloGioacchino Del Regno , Benjamin Mugnier , Tommaso Merciai , Dan Carpenter , Ihor Matushchak , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-gpio@vger.kernel.org References: <20250309084814.3114794-1-demonsingur@gmail.com> <20250309084814.3114794-12-demonsingur@gmail.com> <20250311190711.GA3985355-robh@kernel.org> Content-Language: en-US From: Cosmin Tanislav In-Reply-To: <20250311190711.GA3985355-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250311_152626_268606_FE8B1455 X-CRM114-Status: GOOD ( 22.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/11/25 9:07 PM, Rob Herring wrote: > On Sun, Mar 09, 2025 at 10:48:03AM +0200, Cosmin Tanislav wrote: >> The MAX9296A deserializer converts single or dual serial inputs to MIPI >> CSI-2 outputs. The GMSL2 links operate at a fixed rate of 3Gbps or 6Gbps >> in the forward direction and 187.5Mbps in the reverse direction. >> In GMSL1 mode, each serial link can be paired with 3.12Gbps or 1.5Gbps >> GMSL1 serializers or operate up to 4.5Gbps with GMSL2 serializers with >> GMSL1 backward compatibility. The MAX9296A supports mixed GMSL2 and >> GMSL1 links. The serial inputs operate independently, allowing videos >> with different timings and resolutions to be received on each input. >> >> MAX96716A supports both tunnel and pixel mode. >> MAX96792A supports both tunnel and pixel mode, and has two GMSL3 links. >> >> Signed-off-by: Cosmin Tanislav >> --- >> .../bindings/media/i2c/maxim,max9296a.yaml | 281 ++++++++++++++++++ >> MAINTAINERS | 6 + >> 2 files changed, 287 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml >> new file mode 100644 >> index 000000000000..97731549d161 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml >> @@ -0,0 +1,281 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2024 Collabora Ltd. >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/i2c/maxim,max9296a.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Maxim MAX9296A GMSL2 to CSI-2 Deserializer >> + >> +maintainers: >> + - Cosmin Tanislav >> + >> +description: > > Needs '>' token as you have paragraphs. > >> + The MAX9296A deserializer converts single or dual serial inputs to >> + MIPI CSI-2 outputs. The GMSL2 links operate at a fixed rate of 3Gbps >> + or 6Gbps in the forward direction and 187.5Mbps in the reverse >> + direction. In GMSL1 mode, each serial link can be paired with 3.12Gbps >> + or 1.5Gbps GMSL1 serializers or operate up to 4.5Gbps with GMSL2 >> + serializers with GMSL1 backward compatibility. The MAX9296A supports >> + mixed GMSL2 and GMSL1 links. The serial inputs operate independently, >> + allowing videos with different timings and resolutions to be received >> + on each input. >> + >> + MAX96716A supports both tunnel and pixel mode. >> + MAX96792A supports both tunnel and pixel mode, and has two GMSL3 links. >> + >> +properties: >> + compatible: >> + enum: >> + - maxim,max9296a >> + - maxim,max96716a >> + - maxim,max96792a >> + >> + reg: >> + maxItems: 1 >> + >> + powerdown-gpios: >> + maxItems: 1 >> + description: Specifier for the GPIO connected to the PWDNB pin. >> + >> + port0-poc-supply: >> + description: Regulator providing Power over Coax for GMSL port 0 >> + >> + port1-poc-supply: >> + description: Regulator providing Power over Coax for GMSL port 1 >> + >> + i2c-mux: >> + $ref: /schemas/i2c/i2c-mux.yaml# >> + unevaluatedProperties: false >> + patternProperties: >> + '^i2c@[0-1]$': >> + $ref: /schemas/i2c/i2c-controller.yaml# >> + unevaluatedProperties: false >> + properties: >> + reg: >> + items: >> + minimum: 0 >> + maximum: 1 >> + >> + i2c-alias-pool: >> + maxItems: 2 >> + >> + i2c-atr: >> + type: object >> + additionalProperties: false >> + >> + properties: >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 >> + >> + patternProperties: >> + '^i2c@[0-1]$': >> + $ref: /schemas/i2c/i2c-controller.yaml# >> + unevaluatedProperties: false >> + properties: >> + reg: >> + items: >> + minimum: 0 >> + maximum: 1 >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + patternProperties: >> + '^port@[0-1]$': >> + $ref: /schemas/graph.yaml#/properties/port >> + unevaluatedProperties: false >> + description: GMSL Input >> + properties: >> + endpoint: >> + $ref: /schemas/media/video-interfaces.yaml# > > What properties are you using from here? > > None actually because /schemas/graph.yaml#/properties/port won't allow > any. > So these lines should be removed. unevaluatedProperties: false properties: endpoint: $ref: /schemas/media/video-interfaces.yaml# unevaluatedProperties: false description: Endpoint for GMSL2-Link port. Should I submit patches to do the same for the maxim,max96714.yaml file? I basically copied these bindings from there and adapted them, and those bindings seem to have the same issue. > >> + unevaluatedProperties: false >> + description: Endpoint for GMSL2-Link port. >> + >> + '^port@[2-3]$': >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: CSI-2 Output port >> + properties: >> + endpoint: >> + $ref: /schemas/media/video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + properties: >> + data-lanes: >> + minItems: 1 >> + maxItems: 4 >> + >> + lane-polarities: >> + minItems: 1 >> + maxItems: 5 >> + >> + link-frequencies: >> + maxItems: 1 >> + >> + required: >> + - data-lanes >> + >> + anyOf: >> + - required: >> + - port@2 >> + - required: >> + - port@3 >> + >> +required: >> + - compatible >> + - reg >> + - ports >> + >> +additionalProperties: false >> + >> +allOf: >> + - $ref: /schemas/i2c/i2c-atr.yaml# >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - maxim,max9296a >> + - maxim,max96792a >> + then: >> + not: >> + required: [i2c-mux] >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - maxim,max96716a >> + then: >> + not: >> + required: [i2c-atr] >> + >> +dependentRequired: >> + i2c-atr: [i2c-alias-pool] >> + i2c-alias-pool: [i2c-atr] >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + deserializer@28 { >> + compatible = "maxim,max9296a"; >> + reg = <0x28>; >> + powerdown-gpios = <&main_gpio0 37 GPIO_ACTIVE_LOW>; >> + >> + i2c-alias-pool = <0x40 0x41>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + des_gmsl_in_0: endpoint { >> + remote-endpoint = <&ser_0_gmsl_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + des_gmsl_in_1: endpoint { >> + remote-endpoint = <&ser_1_gmsl_out>; >> + }; >> + }; >> + >> + port@2 { >> + reg = <2>; >> + des_csi_out: endpoint { >> + data-lanes = <1 2 3 4>; >> + link-frequencies = /bits/ 64 <400000000>; >> + remote-endpoint = <&csi_in>; >> + }; >> + }; >> + }; >> + >> + i2c-atr { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + i2c@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0>; >> + >> + serializer@40 { >> + compatible = "maxim,max96717"; >> + reg = <0x40>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + #clock-cells = <0>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + ser_0_csi_in: endpoint { >> + data-lanes = <1 2>; >> + remote-endpoint = <&sensor_0_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + ser_0_gmsl_out: endpoint { >> + remote-endpoint = <&des_gmsl_in_0>; >> + }; >> + }; >> + }; >> + }; >> + }; >> + >> + i2c@1 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <1>; >> + >> + serializer@40 { >> + compatible = "maxim,max96717"; >> + reg = <0x40>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + #clock-cells = <0>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + ser_1_csi_in: endpoint { >> + data-lanes = <1 2>; >> + remote-endpoint = <&sensor_1_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + ser_1_gmsl_out: endpoint { >> + remote-endpoint = <&des_gmsl_in_1>; >> + }; >> + }; >> + }; >> + }; >> + }; >> + }; >> + }; >> + }; >> +... >> diff --git a/MAINTAINERS b/MAINTAINERS >> index abf3afc95fc9..c1e01668e81a 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -14220,6 +14220,12 @@ S: Maintained >> F: Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.yaml >> F: drivers/iio/proximity/mb1232.c >> >> +MAXIM GMSL2 SERIALIZERS AND DESERIALIZERS >> +M: Cosmin Tanislav >> +L: linux-media@vger.kernel.org >> +S: Maintained >> +F: Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml >> + >> MAXIM MAX11205 DRIVER >> M: Ramona Bolboaca >> L: linux-iio@vger.kernel.org >> -- >> 2.48.1 >>