Re: [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio

["Jernej Škrabec" <jernej.skrabec@gmail.com>]

Dne četrtek, 07. april 2022 ob 04:49:03 CEST je Samuel Holland napisal(a):
> On 1/12/22 9:49 AM, Philip Rinn wrote:
> > Enable the audio hardware on the Olimex A64-OLinuXino board family.
> > Tested on the A64-OLinuXino-2Ge8G-IND variant.

Please also update recipients, there were some maintainer changes recently and 
you're missing official linux-sunxi ML (not google groups). scripts/
get_maintainer.pl is your friend here.

Best regards,
Jernej

> > 
> > Signed-off-by: Philip Rinn <rinni@inventati.org>
> > ---
> > 
> > Changes in v2: added missing &sound {...} part
> > Changes in v3: removed HDMI audio part as requested by Jernej Škrabec
> > 
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30
> >  +++++++++++++++++++ 1 file changed, 30 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts index
> > ec7e2c0e82c1..6f2674bb1b7f 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > @@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
> > 
> >  	};
> >  
> >  };
> > 
> > +&codec {
> > +	status = "okay";
> > +};
> > +
> > +&codec_analog {
> > +	cpvdd-supply = <&reg_eldo1>;
> > +	status = "okay";
> > +};
> > +
> > 
> >  &cpu0 {
> >  
> >  	cpu-supply = <&reg_dcdc2>;
> >  
> >  };
> > 
> > @@ -74,6 +83,10 @@ &cpu3 {
> > 
> >  	cpu-supply = <&reg_dcdc2>;
> >  
> >  };
> > 
> > +&dai {
> > +	status = "okay";
> > +};
> > +
> > 
> >  &de {
> >  
> >  	status = "okay";
> >  
> >  };
> > 
> > @@ -328,6 +341,23 @@ &simplefb_hdmi {
> > 
> >  	vcc-hdmi-supply = <&reg_dldo1>;
> >  
> >  };
> > 
> > +&sound {
> > +	simple-audio-card,aux-devs = <&codec_analog>;
> > +	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
> > +		    "Microphone", "Microphone Jack Right",
> > +		    "Headphone", "Headphone Jack";
> > +	simple-audio-card,routing = "Left DAC", "DACL",
> > +		    "Right DAC", "DACR",
> > +		    "Headphone Jack", "HP",
> > +		    "ADCL", "Left ADC",
> > +		    "ADCR", "Right ADC",
> > +		    "Microphone Jack Left", "MBIAS",
> > +		    "MIC1", "Microphone Jack Left",
> > +		    "Microphone Jack Left", "HBIAS",
> 
> According to the schematic, both sides of the microphone jack are biased to
> MBIAS. Otherwise, this patch looks good to me.
> 
> Regards,
> Samuel
> 
> > +		    "MIC2", "Microphone Jack Right";
> > +	status = "okay";
> > +};
> > +
> > 
> >  &uart0 {
> >  
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&uart0_pb_pins>;





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel