From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20718C2D0A8 for ; Wed, 23 Sep 2020 10:59:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FBE3235FC for ; Wed, 23 Sep 2020 10:59:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZLUMRQnW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FBE3235FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ws8ykq66WNq7kooqYnvyE0aq/4fkdooQ80+4dPL3MFo=; b=ZLUMRQnWNQUkMfrE7TZUSw3/d 1FBwK0P76TYWTpgGXUC8HUAvWuYB17zGhhcjiOyiOBCASQtJmJhZCnoRGSlfrX871hE9pBYa00vpO BJtcFfsVhgEKehgXS0dKGRoCYgxY22Ta73f6/arysliyhxqgOmnF+yPaUPXuLJNncmCIpO6pHTJQE ZYhKYjOS4BRjmq2mzwpXdgKIvREFIfJGPDSLswA9j4jVSRLxGGj76WifLowvj3Qsbc2HnZQooJIhJ mY78jgf8zrmCEM1iW03QmXhMzxavYr57Q0AWmCpFRJDuvdUBBuEBpnYU+C+f/nh47hOfZvLq15LG/ Che4PiFXw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL2TJ-0002vz-Py; Wed, 23 Sep 2020 10:58:01 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL2TG-0002uO-Ue for linux-arm-kernel@lists.infradead.org; Wed, 23 Sep 2020 10:58:00 +0000 Received: from [95.90.166.74] (helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kL2TF-0006YK-2A; Wed, 23 Sep 2020 12:57:57 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Artem Lapkin Subject: Re: [PATCH 1/2] arm64: dts: rockchip: rk3399-khadas-edge: add missed spiflash node Date: Wed, 23 Sep 2020 12:57:56 +0200 Message-ID: <8046326.tZ3HhvINgq@diego> In-Reply-To: <20200923101225.1513392-2-email2tema@gmail.com> References: <20200923101225.1513392-1-email2tema@gmail.com> <20200923101225.1513392-2-email2tema@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_065758_994835_0ECB5F3F X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, nick@khadas.com, jbx6244@gmail.com, art@khadas.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Artem, please make the subject something like "arm64: dts: rockchip: add spiflash node to rk3399-khadas-edge" Am Mittwoch, 23. September 2020, 12:12:24 CEST schrieb Artem Lapkin: > From: Artem Lapkin > > The Khadas Edge Boards uses winbond - w25q128 spi flash with 104Mhz Missing "Signed-off-by: ..." > --- > .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > index e36837c04dc..42ebbd6fa46 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > @@ -805,3 +805,17 @@ &vopl { > &vopl_mmu { > status = "okay"; > }; > + > + no double empty lines please > +&spi1 { please group the &spi1 alphabetically in the file > + max-freq = <104000000>; not part of any binding, spi-max-frequency below should be enough. > + status = "okay"; > + > + spiflash: flash@0 { > + u-boot,dm-pre-reloc; u-boot specific, please drop > + compatible = "winbond,w25q128fw", "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <104000000>; > + }; > +}; > + > Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel