From: Marek Vasut <marek.vasut@mailbox.org>
To: Rob Herring <robh@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-arm-kernel@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: renesas: sparrow-hawk: Add overlay for WaveShare 2CH CANFD HAT
Date: Wed, 16 Sep 2026 23:26:47 +0200 [thread overview]
Message-ID: <805629d1-ba2b-4e59-8d29-c374528367f9@mailbox.org> (raw)
In-Reply-To: <CAL_JsqK8--7X5g4T05Y6bEGzsxrhTq2QyQRpE5E5uHBot3jLWA@mail.gmail.com>
On 9/16/26 10:49 PM, Rob Herring wrote:
> On Wed, Sep 9, 2026 at 10:55 AM Marek Vasut <marek.vasut@mailbox.org> wrote:
>>
>> On 9/9/26 5:31 PM, Geert Uytterhoeven wrote:
>>
>> Hello Geert,
>>
>>>> + /*
>>>> + * SPI_1 is operated as GPIO SPI, because MSIOF5 can not be
>>>> + * muxed on the pins allocated for SPI_1 on this CANFD HAT.
>>>> + */
>>>> + spi { /* SPI_1 */
>>>
>>> As this lives at the root node, I'd rather change it back to
>>> spi-ws-2ch-canfd while applying, if you don't mind?
>> Please make sure the DT schema check does not complain about it,
>> otherwise it is fine, thank you.
>
> It does complain:
>
> 1 spi-ws-2ch-canfd (spi-gpio): Unevaluated properties are not
> allowed ('#address-cells', '#size-cells', 'can@0' were unexpected)
> 1 spi-ws-2ch-canfd (spi-gpio): $nodename:0: 'spi-ws-2ch-canfd'
> does not match '^spi(@.*|-([0-9]|[1-9][0-9]+))?$'
>
> The 1st warning is a side effect of the 2nd warning.
>
> "spi-1" like the comment says if just "spi" does not work.
Geert send this fix today:
[PATCH] spi: dt-bindings: Relax node name suffixes again
Maybe that works too ?
prev parent reply other threads:[~2026-09-16 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 15:13 [PATCH v2] arm64: dts: renesas: sparrow-hawk: Add overlay for WaveShare 2CH CANFD HAT Marek Vasut
2026-09-09 15:31 ` Geert Uytterhoeven
2026-09-09 15:55 ` Marek Vasut
2026-09-16 20:49 ` Rob Herring
2026-09-16 21:26 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=805629d1-ba2b-4e59-8d29-c374528367f9@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox