From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0A0BC04A6B for ; Fri, 10 May 2019 06:21:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 698542175B for ; Fri, 10 May 2019 06:21:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V7xeOkol"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="VGPaDZPU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 698542175B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oy/CSsGpAqQ61hfQ6wMTXBgCslKtWrN74j/tp9t4EWM=; b=V7xeOkolfjW7ZZW0HGyy6JLsz W2dtUrGz0/a2872FteX+CVpmygX1Dd5FZUP/SmfyNDHBUteR93bZt5rt9YygSUdG/ntEjb8nZdDu6 eGTSRngp0lNcORCvhqAm59lBdYmTfwhDpXtBn01UJsW1Jrnur+6eBTM1MTowolVvF0JIrtjqAQemX JkQT7G1unE3cE3NIalNkJH2QBQ4fpyU9Mp6WZ4TDEVSsn3Zyt35qe6OL9w0IhTsZS91K+6T82gkVL 5VjVf4oxrcLgXYzkDYRhgooNfY9/2bwc1bMonjmLNQZKEwVxPCWOakfFbbEHjyiPyarwhEbkpX8g9 qBujScMQQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOyuY-0008Od-Oa; Fri, 10 May 2019 06:21:38 +0000 Received: from hqemgate15.nvidia.com ([216.228.121.64]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOyuU-0008OD-Si for linux-arm-kernel@lists.infradead.org; Fri, 10 May 2019 06:21:36 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 09 May 2019 23:20:56 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 09 May 2019 23:21:33 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 09 May 2019 23:21:33 -0700 Received: from [10.24.47.55] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 10 May 2019 06:21:27 +0000 Subject: RE: [PATCH V5 03/16] PCI: Export pcie_bus_config symbol To: Thierry Reding References: <20190424052004.6270-1-vidyas@nvidia.com> <20190424052004.6270-4-vidyas@nvidia.com> <20190503110732.GC32400@ulmo> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: <80616ff5-d7a5-84a4-a71b-569e340d128c@nvidia.com> Date: Fri, 10 May 2019 11:51:24 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190503110732.GC32400@ulmo> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1557469257; bh=24uok8Emgfq8JqLYEmA9il4vmwDxuvY2qeXLWgy1Ux8=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=VGPaDZPU6RodfRcYpWevyox/CweWPCBp2FZ9famAhFSxmUmLYCqoxomnKy3VUay8+ BzMmFoE5yCRMN4THPY6r8HObhAtdLkjZ1FFvmHhAh5NDKaq5SmDigH/E0+PxNknxjN GAb9d7nnGvIWMUWovvD2NALS935C9Af05oRJyiGb+x0saF9s4ch+FkwJ8nOeM6UF5n bbycgvMnkvjCQW2ElsYBymdx5+RWWDbQn2NuFwb6Hxk3tG0mTb1cT/u+bcyPH5ahrP wOnRr+ELEdu/+/RZEAJuMkkjUhagK8PK5+gy2jJqkJxdjOf1B3F31MaTnpYKmsCmMI WmQxUames0JFQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190509_232134_942361_80F8DE06 X-CRM114-Status: GOOD ( 24.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "lorenzo.pieralisi@arm.com" , Mikko Perttunen , Manikanta Maddireddy , "linux-pci@vger.kernel.org" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "linux-kernel@vger.kernel.org" , Krishna Thota , "kishon@ti.com" , "linux-tegra@vger.kernel.org" , "robh+dt@kernel.org" , "gustavo.pimentel@synopsys.com" , "jingoohan1@gmail.com" , "bhelgaas@google.com" , Jonathan Hunter , "linux-arm-kernel@lists.infradead.org" , "sagar.tv@gmail.com" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: linux-pci-owner@vger.kernel.org On > Behalf Of Thierry Reding > Sent: Friday, May 3, 2019 4:38 PM > To: Vidya Sagar > Cc: lorenzo.pieralisi@arm.com; bhelgaas@google.com; robh+dt@kernel.org; > mark.rutland@arm.com; Jonathan Hunter ; > kishon@ti.com; catalin.marinas@arm.com; will.deacon@arm.com; > jingoohan1@gmail.com; gustavo.pimentel@synopsys.com; Mikko Perttunen > ; linux-pci@vger.kernel.org; > devicetree@vger.kernel.org; linux-tegra@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Krishna Thota > ; Manikanta Maddireddy ; > sagar.tv@gmail.com > Subject: Re: [PATCH V5 03/16] PCI: Export pcie_bus_config symbol > > On Wed, Apr 24, 2019 at 10:49:51AM +0530, Vidya Sagar wrote: > > Export pcie_bus_config to enable host controller drivers setting it to > > a specific configuration be able to build as loadable modules > > > > Signed-off-by: Vidya Sagar > > --- > > Changes since [v4]: > > * None > > > > Changes since [v3]: > > * None > > > > Changes since [v2]: > > * None > > > > Changes since [v1]: > > * This is a new patch in v2 series > > > > drivers/pci/pci.c | 1 + > > 1 file changed, 1 insertion(+) > > It doesn't look to me like this is something that host controller drivers are > supposed to change. This is set via the pci kernel command- line parameter, > meaning it's a way of tuning the system configuration. > Drivers should not be allowed to override this after the fact. > > Why do we need to set this? Here is the reason I'm doing it. First things first, Tegra194 supports MPS up to 256 bytes. Assume there are two endpoints with MPS supported up to a) 128 bytes (Ex:- Realtek NIC with 8168 controller) b) 256 bytes (Ex:- Kingston NVMe drive) Now, leaving "pcie_bus_config" untouched in the driver sets it to PCIE_BUS_DEFAULT by default. With this setting, for both (a) and (b), MPS is set to 128, which means, even though Tegra194 supports 256 MPS, it is not set to 256 even in case of (b) thereby not using RP's 256 MPS feature. If I explicitly set pcie_bus_config=PCIE_BUS_PERFORMACE in the code, then 256 MPS is set when (b) is connected, but when (a) is connected, for root port MPS 256 is set and for endpoint MPS 128 is set, because of which root port tries to send packets with 256 payload that breaks functionality of Realtek NIC card. The best option I've found out is that when I set 256 in PCI_EXP_DEVCTL of root port explicitly before link up and use pcie_bus_config=PCIE_BUS_SAFE, then, I get the best of both PCIE_BUS_DEFAULT and PCIE_BUS_PERFORMANCE i.e. with (a) connected, MPS is set to 128 in both RP and EP and with (b) connected, MPS is set to 256 in both RP and EP. So, is it like, pcie_bus_config shouldn't be set to anything explicitly in the driver and depending on the platform and what is connected to root port, kernel parameter can be passed with appropriate setting? > > Thierry > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index > > f5ff01dc4b13..731f78508601 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -94,6 +94,7 @@ unsigned long pci_hotplug_mem_size = > > DEFAULT_HOTPLUG_MEM_SIZE; unsigned long pci_hotplug_bus_size = > > DEFAULT_HOTPLUG_BUS_SIZE; > > > > enum pcie_bus_config_types pcie_bus_config = PCIE_BUS_DEFAULT; > > +EXPORT_SYMBOL_GPL(pcie_bus_config); > > > > /* > > * The default CLS is used if arch didn't set CLS explicitly and not > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel