From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E535C25B75 for ; Tue, 21 May 2024 20:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TpLxCTeAkn64K3+AUjUNXw7MNbZ3TeEGgEIC3vLcU88=; b=mcHtTf+yV0LE+8 JteBZmcYrdgfnhutoiFkI+Q7ovOHguJOxt+2KEDcQM5Xa7FZCMmFSeyeHsFswWMa+/ct9yhvXEcYa ez5CY4Pbj15U4nc/4/cmnfwMc9psnFF2X8mXmYvUpGpY/2uAAChau5t2jH8LmLdZ2bGDImLXIpKe7 QVgQkPcdyfP0m4axof/yWQd2YjiR6HW04E4ZI1MKbAVNamYj0czks3dOA5dNHC1nH/RxvL330WMKJ y+g+A9FCht//2Xl+JUgFU40gB19ulS0+6RqlSYcC5SfXPapm/KGo3ERZXBKpiMKhrW8RH2adQgnd0 QEHOU1MIvrvvekXhFI9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9VlI-00000000yEl-09RM; Tue, 21 May 2024 20:07:04 +0000 Received: from fout6-smtp.messagingengine.com ([103.168.172.149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9VlE-00000000yDx-2zxi for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2024 20:07:02 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id F36F0138150F; Tue, 21 May 2024 16:06:56 -0400 (EDT) Received: from imap53 ([10.202.2.103]) by compute1.internal (MEProxy); Tue, 21 May 2024 16:06:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jannau.net; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1716322016; x=1716408416; bh=auMqi6BTaN xoIG36SjSU6GhPhyiR6/VLklN3fAHEa9s=; b=OHxZKyIVSd0w693BcNLhUTWS4c FpNIS9nO0iqVU5rnpj7aQb4B0JhH6rzx1yeXxTqLMVIzLLKlMtAEBJ/LoygCi3xF B7JtWnMLdZrQYpf/sPLBvg0WkID++9qBrjSCddHC/Pe1IBfefWf3Lrq8fnAJTWh6 M3T1RDpe5VtFeXk7NhpOS/zRvJCz/AE8z3l+4i7+u2aCis0Diy8l7vZ7B2nnSZCP 8f1d87C2RIgiUZcUNVhUrKKrGbFZCPULwRWllpvPtR47/W3aBFbNDyIWcsqbHAWk tFryE+EX7fPFcIEC8euhPRHary4txaF+GD6qrmNC+J+ZfJNOHc9zp5lYK/Wg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1716322016; x=1716408416; bh=auMqi6BTaNxoIG36SjSU6GhPhyiR 6/VLklN3fAHEa9s=; b=RugSA8OXA10V1qO+4J1PfuJyu9fmODCSjw9Gcj7QROo5 cDjxKZ6+W/8f50jvnXxuRXX6bxgOhULRmWY0EdT2BVpY2K4jIdL0x1gw9Ot+2Kdl nfT3A+yOx5tDGbG6Pl32o7NUQeIldDLFs5UFBdtACc30VuttUeq3xSRb4MFIa0E8 MqynrRtnUwVhvziewUj+cKpxW6pTvFKUBDX6D/gZdazeblA5du4gIT8wPucQOb6q JYT8bNCFLEB4TPzqbTpdPfXeuNxDSQTnLbGP96MjD+ScgInPI6Dqp5VRpFWql7BQ TJJy2kWU/nEz2gg4P7koOR63VaxvMLwc6KgEuERA+w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeivddgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdfl rghnnhgvucfirhhunhgruhdfuceojhesjhgrnhhnrghurdhnvghtqeenucggtffrrghtth gvrhhnpeevvdfhtddvvddtgffggfeuteduhfeigeevfeffueekheetffekjeehjeefhfei tdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjse hjrghnnhgruhdrnhgvth X-ME-Proxy: Feedback-ID: i47b949f6:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6C9323640070; Tue, 21 May 2024 16:06:56 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-480-g515a2f54a-fm-20240515.001-g515a2f54 MIME-Version: 1.0 Message-Id: <806fe068-893c-4167-8162-699328014e2b@app.fastmail.com> In-Reply-To: <20240521183445.GA7154@willie-the-truck> References: <20240521183445.GA7154@willie-the-truck> Date: Tue, 21 May 2024 22:06:36 +0200 From: "Janne Grunau" To: "Will Deacon" , "Johannes Nixdorf" Cc: "Marc Zyngier" , "Ard Biesheuvel" , "Mark Brown" , linux-arm-kernel@lists.infradead.org, asahi@lists.linux.dev Subject: Re: [BUG] dm-crypt broken after 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240521_130701_201437_E4ED2A47 X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hej, On Tue, May 21, 2024, at 20:34, Will Deacon wrote: > Hi Johannes, > > On Tue, May 21, 2024 at 08:22:08AM +0200, Johannes Nixdorf wrote: >> Bad news: I hit the bug again with 2632e2521769 ("arm64: fpsimd: Implement >> lazy restore for kernel mode FPSIMD") reverted during prolonged interactive >> usage with the downstream Asahi Linux kernel. > > Damn, but thanks for the update. I have to ask, but are you absolutely > sure this was with 2632e2521769 reverted? If you're able to double-check > that, it would be great, since we're having trouble reproducing the > issue. I can reproduce the issue with v6.8 and 2632e2521769 reverted on M1 (t8103). Reproduction with 2632e2521769 reverted is harder. I've seen multiple fio runs without verification errors while with plain v6.8 verification errors are hit after a few seconds. Running SIMD intense workloads in user space apparently increase the reproduction odds. When running AV1 decoding using dav1d in parallel errors appear faster. Errors manifest either in changed decoder output, fio verification errors or both. I'm using `dav1d -i sample.ivf --muxer xxh3 -o -` here as user space SIMD payload but I'd assume the exact SIMD user space code doesn't matter as long as it runs on all CPU cores. >> This prompted me to adjust the reproducer to be closer to the desktop use >> case, which then also found aefbab8e77eb ("arm64: fpsimd: Preserve/restore >> kernel mode NEON at context switch"). With the vanilla kernel before the >> commit or that commit reverted on the Asahi Linux kernel the new reproducer >> also sees no bug, and interactive usage seems fine. > > I've already reverted 2632e2521769 ("arm64: fpsimd: Implement lazy > restore for kernel mode FPSIMD"), so it sounds like I should revert > aefbab8e77eb ("arm64: fpsimd: Preserve/restore kernel mode NEON at > context switch") as well while we work to reproduce the issue. v6.8 with 2632e2521769 and aefbab8e77eb reverted does no longer reproduce errors. av1 decoding produces a stable hash as expected and fio does not report any verification errors. best regards Janne _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel