From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24383EE645F for ; Thu, 12 Sep 2024 08:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8uL3yDQtDSTfprjNMoH8FDOc9dazYHaDt/nHN9xGeXM=; b=j+So9CHvOd2ZmtMedmSGZlz911 PhI28H6n4HIsGBx7ojx3W5HqcZrljukSPqQw4TE1ahzPNmQzJlvwQYFCYcr8Hg1ORWsSYfyAQebGQ EqylCxfmbSqToGGavTuV30kGPeLXprRR76wvSZYY9bVhR5XvmOj2UiHRKl2nhyAzLgHMA9zCEa4xy l/EtWfmmKC2RhZt80nYaGbRG6Q4LBQaVQ4XHM0ZwVEqJB3PYjwaM1LM8NVXXTGgxIIEsEdXEdYIrF 930JTdG8leWeuA4xcnoDFUH5lBqCRhw+S9sUZ1bhNEFOXyebJtjJm0pbsKi1pHeE8Di/rQWR0/qWa cgr7JqGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sof4K-0000000CM0H-3Ksf; Thu, 12 Sep 2024 08:20:48 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sof1B-0000000CKna-0qC2 for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 08:17:34 +0000 Received: by mail-oi1-x243.google.com with SMTP id 5614622812f47-3e039889ca0so402044b6e.3 for ; Thu, 12 Sep 2024 01:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1726129052; x=1726733852; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8uL3yDQtDSTfprjNMoH8FDOc9dazYHaDt/nHN9xGeXM=; b=NXi2s/j27piu9XFLjyFkKZm8g1e5qLn0qhCA2YJEiBSfQ4XkL7GsacK8pr1FGRempx Z2tfdUoKGaJGRHRuxCPFS+dlrUIVQ5z9ambeugKPtZ+xNNcg3LIipH0GaHFiLvkjVuoF CybnlStybBPl939stXKUBTtJ0QPKDLPM9ABG1+Qr9ebajyjoPaIkXFUMSGothKX4AW4b 1clEMApuvCWgrdpWWcBPXX+X0tGbG9bp0HDfHQmIv33Tz+qmFnF5t9EXTQpIWslisT7y uu2wp462FaOi7aLkZTl/NuuFSmrx31aWbj5lDzfV1vYaXT8pn+K0dT503inrrBcV8IZ7 ipww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726129052; x=1726733852; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8uL3yDQtDSTfprjNMoH8FDOc9dazYHaDt/nHN9xGeXM=; b=IlYCkwAcycetMDhEF1JHg2QTJedD0/A8KHWQsxP4S1jlJks6IedsbeEAyt+KwyppKy WMvbYVBBOpd8kvXMxitZJsrrzR4Tblcrb6AXb7ijc58Km1NoyGrIZ5ZtmNW4PMC17mlL p2E8b2BqiyU/w1zwNhdWYaJsA94LgxpYXTi/kQ37dCENYWJgw0nqPH3CYo6ZHzJlyOy7 Bp6HFolUnbq1ZFkuk+nWUiaPVpEBsdbUazhP25JckU21yWTwD4mjXUFOgCN5f+gD5Ktk 2KNE7rmV9+kRH1WbJwgxFHP1U2Du5OPJUctw604jE3UwJPnhjEm7xiONigNYT9LuwWaE j42w== X-Forwarded-Encrypted: i=1; AJvYcCVaa9E4uwffULc63raFHEp8um2hv7hZBNgFKx2qwLAAGakgeFC4xzLD8JNqwizKISNO7HWtvdDC6wOy5/iZJeqQ@lists.infradead.org X-Gm-Message-State: AOJu0YxIB/1yJ2WyGW2oOwlFR617KOIZ9VspQBr1ZKNBiukTUmYnpYl0 4WTVdOlNQY39dxj5ZHrkqSlbkzgupRYRqdrmfwjP+vewLIIoOIDclpHfBNlySQ== X-Google-Smtp-Source: AGHT+IHqXN55m2k9nKnrLVORi16b7s+aS0bP7kpj9K+gERCN7cxXjZ4YnCy9OzUuuNUrn0w1QzZ3/w== X-Received: by 2002:a05:6808:3190:b0:3e0:74b1:d676 with SMTP id 5614622812f47-3e074b1dfb8mr974656b6e.27.1726129051808; Thu, 12 Sep 2024 01:17:31 -0700 (PDT) Received: from [172.16.118.100] ([103.15.228.94]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fddc6e2sm1186225a12.62.2024.09.12.01.17.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 01:17:30 -0700 (PDT) Message-ID: <8072c698-93b0-4d3a-a970-e276243f82c4@beagleboard.org> Date: Thu, 12 Sep 2024 13:47:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 8/8] addon_boards: mikrobus: Add GPS3 Click Content-Language: en-US To: Greg Kroah-Hartman , Dirk Behme Cc: Ayush Singh , fabien.parent@linaro.org, d-gole@ti.com, lorforlinux@beagleboard.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, Andrew Davis , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240911-mikrobus-dt-v1-0-3ded4dc879e7@beagleboard.org> <20240911-mikrobus-dt-v1-8-3ded4dc879e7@beagleboard.org> <2024091149-vocalize-composite-6e48@gregkh> <44039255-159a-4284-abd8-a0f558ad006d@gmail.com> <2024091151-unworldly-dance-9a80@gregkh> <097159c7-1602-4e32-8e6f-9cd023d62238@beagleboard.org> <419bf74e-74cb-46ca-95d0-03b3bab3948d@de.bosch.com> <2024091211-bladder-runner-2d75@gregkh> From: Ayush Singh In-Reply-To: <2024091211-bladder-runner-2d75@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_011733_540471_DC27BE3C X-CRM114-Status: GOOD ( 22.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/12/24 13:09, Greg Kroah-Hartman wrote: > On Thu, Sep 12, 2024 at 09:29:01AM +0200, Dirk Behme wrote: >> On 12.09.2024 09:16, Ayush Singh wrote: >>> On 9/12/24 01:34, Greg Kroah-Hartman wrote: >>> >>>> On Wed, Sep 11, 2024 at 09:26:06PM +0530, Ayush Singh wrote: >>>>> On 9/11/24 20:28, Greg Kroah-Hartman wrote: >>>>> >>>>>> On Wed, Sep 11, 2024 at 07:57:25PM +0530, Ayush Singh wrote: >>>>>>> - GPS3 Click is a UART MikroBUS addon Board >>>>>>> >>>>>>> Link: https://www.mikroe.com/gps-3-click >>>>>>> >>>>>>> Signed-off-by: Ayush Singh >>>>>>> --- >>>>>>>    addon_boards/mikrobus/Makefile         |  1 + >>>>>>>    addon_boards/mikrobus/mikroe-1714.dtso | 28 >>>>>>> ++++++++++++++++++++++++++++ >>>>>> Odd top-level directory for the kernel, are you sure this is correct? >>>>>> >>>>>> thanks, >>>>>> >>>>>> greg k-h >>>>>> >>>>> Well, it is kinda a temporary location, since well, I could not >>>>> find a good >>>>> place for board overlays but a top-level location seems better >>>>> than putting >>>>> them in any arch specific location. I am open to moving them to a more >>>>> suitable location if we have one. >>>> top-level location is not ok for something so tiny and "special".  Just >>>> put it where all other dtso files go. >>>> >>>> thanks, >>>> >>>> greg k-h >>> >>> So here are the directories where dtso files currently go: >>> >>> ❯ find . -type f -name "*.dtso" -printf "%h\n" | sort -u >>> ./arch/arm64/boot/dts/amlogic >>> ./arch/arm64/boot/dts/freescale >>> ./arch/arm64/boot/dts/mediatek >>> ./arch/arm64/boot/dts/qcom >>> ./arch/arm64/boot/dts/renesas >>> ./arch/arm64/boot/dts/rockchip >>> ./arch/arm64/boot/dts/ti >>> ./arch/arm64/boot/dts/xilinx >>> ./arch/arm/boot/dts/nxp/imx >>> ./arch/arm/boot/dts/ti/omap >>> ./drivers/clk >>> ./drivers/of >>> ./drivers/of/unittest-data >>> >>> >>> Out of these, `drivers/of` and `drivers/of/unittest-data` contain >>> unittest dtso, so probably not the place. >>> >>> And the `arch/arm` and `arch/arm64` are for arch specific stuff. >>> MikroBUS is supported in RISC-V boards as well (BeagleV-Ahead). So >>> probably not the correct location either. >>> >>> Maybe something like `arch/common/addon_boards` would be better? >> Whats about >> >> drivers/misc/mikrobus/mikrobus.rs >> drivers/misc/mikrobus/mikroe-1714.dtso >> drivers/misc/mikrobus/mikroe-5761-i2c.dtso > Exactly, put them where the drivers are, like clk and of does. > > thanks, > > greg k-h So I am writing a more thorough reply in the driver questions, but essentially, the driver is not actually required for using the overlay based approach for mikroBUS addon boards. Initially, the driver was not supposed to be included in the patch series at all. But I was not able to find a way to use a GPIO nexus node [0] without having a platform driver attached to the node. In fact, if the GPIO nexus node is not required (like in the case of weather click), there is no need to even have a mikrobus-connector node in dt, let alone a driver. So to answer why it probably should not go in the driver directory, the driver for the connector, actually does not register the mikrobus addon board. And if there is a way to have GPIO nexus node without having a platform driver attached to the node, then it should probably be removed. The reason why the overlay based approach was suggested was because previous approaches could not do board stacking (having chain of mikrobus connector -> grove connector addon board -> grove board). So as you can see, it is beneficial to have grove board overlays compiled even in a board without any grove connectors because of stacking. [0]: https://devicetree-specification.readthedocs.io/en/v0.3/devicetree-basics.html#nexus-nodes-and-specifier-mapping Ayush Singh