From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>
Cc: Samuel Holland <samuel@sholland.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Paul Cercueil <paul@crapouillou.net>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] drm/sun4i: dw-hdmi: Fix ddc-en GPIO consumer conflict
Date: Tue, 14 Jun 2022 17:45:55 +0200 [thread overview]
Message-ID: <8075386.T7Z3S40VBb@kista> (raw)
In-Reply-To: <20220614073100.11550-1-samuel@sholland.org>
Dne torek, 14. junij 2022 ob 09:31:00 CEST je Samuel Holland napisal(a):
> commit 6de79dd3a920 ("drm/bridge: display-connector: add ddc-en gpio
> support") added a consumer for this GPIO in the HDMI connector device.
> This new consumer conflicts with the pre-existing GPIO consumer in the
> sun8i HDMI controller driver, which prevents the driver from probing:
>
> [ 4.983358] display-connector connector: GPIO lookup for consumer ddc-
en
> [ 4.983364] display-connector connector: using device tree for GPIO
lookup
> [ 4.983392] gpio-226 (ddc-en): gpiod_request: status -16
> [ 4.983399] sun8i-dw-hdmi 6000000.hdmi: Couldn't get ddc-en gpio
> [ 4.983618] sun4i-drm display-engine: failed to bind 6000000.hdmi (ops
sun8i_dw_hdmi_ops [sun8i_drm_hdmi]): -16
> [ 4.984082] sun4i-drm display-engine: Couldn't bind all pipelines
components
> [ 4.984171] sun4i-drm display-engine: adev bind failed: -16
> [ 4.984179] sun8i-dw-hdmi: probe of 6000000.hdmi failed with error -16
>
> Both drivers have the same behavior: they leave the GPIO active for the
> life of the device. Let's take advantage of the new implementation, and
> drop the now-obsolete code from the HDMI controller driver.
>
> Fixes: 6de79dd3a920 ("drm/bridge: display-connector: add ddc-en gpio
support")
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-14 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 7:31 [PATCH] drm/sun4i: dw-hdmi: Fix ddc-en GPIO consumer conflict Samuel Holland
2022-06-14 15:45 ` Jernej Škrabec [this message]
2022-06-16 7:53 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8075386.T7Z3S40VBb@kista \
--to=jernej.skrabec@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=paul@crapouillou.net \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).