From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2DD7C433DF for ; Mon, 13 Jul 2020 20:34:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F45A2075D for ; Mon, 13 Jul 2020 20:34:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wPNGX8rP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="cHdBGMUw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F45A2075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ISQiwiN4JcVL4BF3/9aCNxdbStMllUfuhZHy6lpeDmg=; b=wPNGX8rPkHck8PVNdbikY/Ass n1N8YCtFNvNM1RpZY4kGWo3L7SxGTj9X0DUc7mdtHI3uK8zzDpkxO2X5QeEBH7N9F1XJLZII8tFjC 0kPtIBqShivp+FZ8q08ux7yzsaSjJOdaKsI+j0NppgafI3QATie6WiIVIHZB0XtCnIsBSQM3BibZH l6zoeRe5twVnyQooeo9XVy/an3YLmd0o7SLHJsx4+TSrE1+Cea/VaAgyrxHGkXhFG43lybGSzQZQZ e5UCM70x7c0yetoesVdyvI7Q0nJvQGG4iLAx6SnIjHWbltHhCHkyZCw8jRtksVrqtMIDMd9hNjEEU f9tfi2+pw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv58B-0002mu-91; Mon, 13 Jul 2020 20:32:55 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv588-0002mO-Jz for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 20:32:53 +0000 Received: from [10.0.0.249] (c-24-19-135-168.hsd1.wa.comcast.net [24.19.135.168]) by linux.microsoft.com (Postfix) with ESMTPSA id CAADF20B4909; Mon, 13 Jul 2020 13:32:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CAADF20B4909 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1594672371; bh=VeWN4l0WTivLpVxHyd7AaFSTibjlEMzXV0jVP3Zo+E4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=cHdBGMUwa6d7vQELISebugbZOJJPgfylgs+Ow4juQxNZlH84Uew4znIMhI1ctPIqj H3I0N3rghH+OPS5b0/jhoIQBL8VUHOjGPpO6T+NSQaCMWJ5VU3jNPyjiJGtaOjHTVC 7dGIyN+NRs9Dp/ZrXQdYTJ5ocXPgoEQ4OChP6Zbc= Subject: Re: [V2 PATCH 2/3] dt-bindings: chosen: Document ima-kexec-buffer To: Thiago Jung Bauermann References: <20200618071045.471131-1-prsriva@linux.microsoft.com> <20200618071045.471131-3-prsriva@linux.microsoft.com> <87mu4yr2k2.fsf@morokweng.localdomain> From: Prakhar Srivastava Message-ID: <80813a16-be43-3fc4-4812-33c60095a423@linux.microsoft.com> Date: Mon, 13 Jul 2020 13:32:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87mu4yr2k2.fsf@morokweng.localdomain> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_163252_790860_707C86D1 X-CRM114-Status: GOOD ( 28.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kstewart@linuxfoundation.org, mark.rutland@arm.com, gregkh@linuxfoundation.org, benh@kernel.crashing.org, bhsharma@redhat.com, tao.li@vivo.com, zohar@linux.ibm.com, paulus@samba.org, vincenzo.frascino@arm.com, will@kernel.org, nramas@linux.microsoft.com, frowand.list@gmail.com, masahiroy@kernel.org, jmorris@namei.org, takahiro.akashi@linaro.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, serge@hallyn.com, devicetree@vger.kernel.org, pasha.tatashin@soleen.com, robh+dt@kernel.org, hsinyi@chromium.org, tusharsu@linux.microsoft.com, tglx@linutronix.de, allison@lohutok.net, christophe.leroy@c-s.fr, mbrugger@suse.com, balajib@linux.microsoft.com, dmitry.kasatkin@gmail.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, james.morse@arm.com, mpe@ellerman.id.au, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/19/20 5:41 PM, Thiago Jung Bauermann wrote: > > Prakhar Srivastava writes: > >> Integrity measurement architecture(IMA) validates if files >> have been accidentally or maliciously altered, both remotely and >> locally, appraise a file's measurement against a "good" value stored >> as an extended attribute, and enforce local file integrity. >> >> IMA also measures singatures of kernel and initrd during kexec along with >> the command line used for kexec. >> These measurements are critical to verify the seccurity posture of the OS. >> >> Resering memory and adding the memory information to a device tree node >> acts as the mechanism to carry over IMA measurement logs. >> >> Update devicetree documentation to reflect the addition of new property >> under the chosen node. > > Thank you for writing this documentation patch. It's something I should > have done when I added the powerpc IMA kexec support. > > You addressed Rob Herring's comments regarding the commit message, but > not the ones regarding the patch contents. > > When posting a new version of the patches, make sure to address all > comments made so far. Addressing a comment doesn't necessarily mean > implementing the requested change. If you don't then you should at least > explain why you chose a different path. > > I mention it because this has occurred before with this patch series, > and it's hard to make forward progress if review comments get ignored. > >> --- >> Documentation/devicetree/bindings/chosen.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt >> index 45e79172a646..a15f70c007ef 100644 >> --- a/Documentation/devicetree/bindings/chosen.txt >> +++ b/Documentation/devicetree/bindings/chosen.txt >> @@ -135,3 +135,20 @@ e.g. >> linux,initrd-end = <0x82800000>; >> }; >> }; >> + >> +linux,ima-kexec-buffer >> +---------------------- >> + >> +This property(currently used by powerpc, arm64) holds the memory range, > > space before the parenthesis. > >> +the address and the size, of the IMA measurement logs that are being carried > > Maybe it's because English isn't my first language, but IMHO it's > clearer if "the address and the size" is between parentheses rather than > commas. > >> +over to the kexec session. > > I don't think there's a "kexec session", but I'm not sure what a good > term would be. "linux,booted-from-kexec" uses "new kernel" so perhaps > that's a good option to use instead of "kexec session". > >> + >> +/ { >> + chosen { >> + linux,ima-kexec-buffer = <0x9 0x82000000 0x0 0x00008000>; >> + }; >> +}; >> + >> +This porperty does not represent real hardware, but the memory allocated for >> +carrying the IMA measurement logs. The address and the suze are expressed in >> +#address-cells and #size-cells, respectively of the root node. > > I will update the descriptions and ack the comments/changes in the patches as well. Thankyou, Prakhar Srivastava > -- > Thiago Jung Bauermann > IBM Linux Technology Center > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel