From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDAF4C43603 for ; Mon, 9 Dec 2019 13:54:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CA5E2073D for ; Mon, 9 Dec 2019 13:54:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QiZSP2f2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CA5E2073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z2Terl9SLPHdWS6PSFaXau0I0KEglp1KpivUicaty6Q=; b=QiZSP2f2o+OK0c J8HouM5vSmAEWrAW/wZELUVSfVIxsjnAd02T7sIzWVUcfwCM5JmDptRR/QGiA7PQvDJM05EwScviE mn7oo1+aNSFJMSzuAKt6FeWW/NTW4ThnXmLQkLbGrhzQ79+r9AMqzUf4Rm9WXqlS84UoNhvQWmyOW 7fDMLuIKUjyyIbFKSdQ5iWnn7LjqqCfWoPHzlOU4AIGRYEq+hIwhuSJjU4e1B0iYQouHtN57l+zV5 2v+U3YHine/g6P3FiO4dtQ41zh3+KCV011/ZU1n97edZ2fLYLu6OdXD2852LZgGA5vnH/FX4ffG6G Hynn4BFG+nJnG2pkRVGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieJUF-0007zS-Nf; Mon, 09 Dec 2019 13:54:07 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieJUB-0007xY-Rm; Mon, 09 Dec 2019 13:54:06 +0000 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ieJU1-0000ns-B0; Mon, 09 Dec 2019 14:53:53 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Peter Geis Subject: Re: [RFCv1 0/8] RK3399 clean shutdown issue Date: Mon, 09 Dec 2019 14:53:52 +0100 Message-ID: <8087758.JvhXzBlCRf@diego> In-Reply-To: References: <20191206184536.2507-1-linux.amoon@gmail.com> <724aa7db-3838-16f9-d344-1789ae2a5746@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191209_055404_048995_FAEB3AA7 X-CRM114-Status: GOOD ( 23.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Daniel Schultz , linux-kernel@vger.kernel.org, "open list:ARM/Rockchip SoC..." , Rob Herring , Jagan Teki , Manivannan Sadhasivam , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Montag, 9. Dezember 2019, 14:37:28 CET schrieb Peter Geis: > On Mon, Dec 9, 2019 at 8:29 AM Robin Murphy wrote: > > > > On 06/12/2019 6:45 pm, Anand Moon wrote: > > > Most of the RK3399 SBC boards do not perform clean > > > shutdown and clean reboot. > > > > FWIW reboot problems on RK3399 have been tracked down to issues in > > upstream ATF, and are unrelated to the PMIC. > > > > > These patches try to help resolve the issue with proper > > > shutdown by turning off the PMIC. > > > > As mentioned elsewhere[1], although this is what the BSP kernel seems to > > do, and in practice it's unlikely to matter for the majority of devboard > > users like you and me, I still feel a bit uncomfortable with this > > solution for systems using ATF as in principle the secure world might > > want to know about orderly shutdowns, and this effectively makes every > > shutdown an unexpected power loss from secure software's point of view. > > > > Robin. > > Since ATF is operating completely in volatile memory, and shouldn't be > touching hardware once it passes off control to the kernel anyways, > what is the harm of pulling the rug out from under it? Secure-world doesn't end with ATF :-) There can also be an instance of OP-TEE or another TEE on top and they often actually do secure storage encrypted onto the hosts mass storage (see kernel's optee module). > If this idea is to prevent issues in the future, such as if ATF does > gain the ability to preempt hardware control, then at that time ATF > will need to be able to handle actually powering off devices using the > same functionality. > > But as we discussed previously, ATF doesn't have this capability, so > in this case any board without a dedicated power-off gpio will be > unable to power off at all. > Also it seems that giving ATF this functionality, with the current > state of ATF, would be cost prohibitive. > > I personally feel that allowing the kernel to do this is a solution to > the problem we have now. For the rest I guess I'll just point to Robin's text and Ack under your system-power-controller patch ;-) Heiko > > [1] > > http://lists.infradead.org/pipermail/linux-rockchip/2019-December/028183.html > > > > > For reference > > > RK805 PMCI data sheet: > > > [0] http://rockchip.fr/RK805%20datasheet%20V1.3.pdf > > > RK808 PMIC data sheet: > > > [1] http://rockchip.fr/RK808%20datasheet%20V1.4.pdf > > > RK817 PMIC data sheet: > > > [2] http://rockchip.fr/RK817%20datasheet%20V1.01.pdf > > > RK818 PMIC data sheet: > > > [3] http://rockchip.fr/RK818%20datasheet%20V1.0.pdf > > > > > > Reboot issue: > > > My guess is that we need to some proper sequence of > > > setting to PMCI to perform clean. > > > > > > If you have any input please share them. > > > > > > Tested on SBC > > > Rock960 Model A > > > Odroid N1 > > > Rock64 > > > > > > -Anand Moon > > > > > > Anand Moon (8): > > > mfd: rk808: Refactor shutdown functions > > > mfd: rk808: use syscore for RK805 PMIC shutdown > > > mfd: rk808: use syscore for RK808 PMIC shutdown > > > mfd: rk808: use syscore for RK818 PMIC shutdown > > > mfd: rk808: cleanup unused function pointer > > > mfd: rk808: use common syscore for all PMCI for clean shutdown > > > arm64: rockchip: drop unused field from rk8xx i2c node > > > arm: rockchip: drop unused field from rk8xx i2c node > > > > > > arch/arm/boot/dts/rk3036-kylin.dts | 1 - > > > arch/arm/boot/dts/rk3188-px3-evb.dts | 1 - > > > arch/arm/boot/dts/rk3288-evb-rk808.dts | 1 - > > > arch/arm/boot/dts/rk3288-phycore-som.dtsi | 1 - > > > arch/arm/boot/dts/rk3288-popmetal.dts | 1 - > > > arch/arm/boot/dts/rk3288-tinker.dtsi | 1 - > > > arch/arm/boot/dts/rk3288-veyron.dtsi | 1 - > > > arch/arm/boot/dts/rk3288-vyasa.dts | 1 - > > > arch/arm/boot/dts/rv1108-elgin-r1.dts | 1 - > > > arch/arm/boot/dts/rv1108-evb.dts | 1 - > > > arch/arm64/boot/dts/rockchip/px30-evb.dts | 1 - > > > arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 1 - > > > arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 1 - > > > .../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 1 - > > > .../arm64/boot/dts/rockchip/rk3328-rock64.dts | 1 - > > > .../boot/dts/rockchip/rk3368-geekbox.dts | 1 - > > > arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi | 1 - > > > .../boot/dts/rockchip/rk3368-px5-evb.dts | 1 - > > > .../boot/dts/rockchip/rk3399-firefly.dts | 1 - > > > .../boot/dts/rockchip/rk3399-hugsun-x99.dts | 1 - > > > .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 1 - > > > .../boot/dts/rockchip/rk3399-leez-p710.dts | 1 - > > > .../boot/dts/rockchip/rk3399-nanopi4.dtsi | 1 - > > > .../boot/dts/rockchip/rk3399-orangepi.dts | 1 - > > > arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 1 - > > > .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 1 - > > > .../boot/dts/rockchip/rk3399-rock-pi-4.dts | 1 - > > > .../boot/dts/rockchip/rk3399-rock960.dtsi | 1 - > > > .../boot/dts/rockchip/rk3399-rockpro64.dts | 1 - > > > .../boot/dts/rockchip/rk3399-sapphire.dtsi | 1 - > > > drivers/mfd/rk808.c | 144 +++++------------- > > > include/linux/mfd/rk808.h | 2 - > > > 32 files changed, 42 insertions(+), 134 deletions(-) > > > > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel