From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78B68CD1284 for ; Tue, 2 Apr 2024 07:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SvVg0s1dbRtrLxmToK5xRQpBLM8vDX60kGOg64zTNGY=; b=P85oDIY1cfJTXO a1/GDWaNBgj6IENocUzOXMHbyETlpHsseoRHf47nkIJXhrLDqDJ0/gP/48fIJ2mx0tgL4R4txP8UV 48XNvr9FKlBWM8+mZpjX9JqvTGuuR5yV4jNoaAeZBjMdD+zxroG+mp4wEAsUniX8T2vYfpz7dYdKl 1Z2k6MAJZt5lOAL2BVNSOYiXV/Iei2Uqk9TtK8bAeJGAp3mw/FL821vkmbmzFtj9LdZasHf+RrpMg /Wji+w9DoNSElsKozcKtAA77Z5JCE+V/7WXnn8v1kMhX1CU2zebydEiHlii9qR+pm773ZhJSZExZx rY2Xmswc8h/penCZJJwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrYip-0000000A6CT-4BpC; Tue, 02 Apr 2024 07:38:20 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrYim-0000000A6B1-1FhG; Tue, 02 Apr 2024 07:38:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7765B60B4F; Tue, 2 Apr 2024 07:38:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C703C433F1; Tue, 2 Apr 2024 07:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712043495; bh=TfkRnq5Iex/rUtVkNVsPycE3pm25lH41VYxu3rMQUOA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=V7S6CQI93E3zwLQFAHvPkTOZroqxnXZLv+j98cTwbl0BfjL5riHoJJlkAWmqd/RzX QMGelJ3/TmSzX16VOatTUkmy/KgJ4pFHEMvETHPBid9Ud93Icownw9abE3svYuvIYF 4feje6sQtbq3Gl1YyBy1YA5xCyYLY8skgtD52QNgIS19gijoD9rCPvxdXDAAD8KOcS BBL8jMywvaTotqTRcIM48kKaFZYieUm7CwUSaYwblGSxXFVO511ITLIFcZtfgEvZFC EEie4rNsP8Q8SEcQLtqKg6gZIdANxMQTWe8OHLcY7d361v9PDIyWJbmDRbEUJ6Qf59 uQtLfckete3pQ== Message-ID: <80c4c37b-8c5c-4628-a455-fcccfc3b3730@kernel.org> Date: Tue, 2 Apr 2024 16:38:12 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 17/18] dt-bindings: pci: rockchip,rk3399-pcie-ep: Add ep-gpios property To: Krzysztof Kozlowski , Manivannan Sadhasivam , Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240330041928.1555578-18-dlemoal@kernel.org> <518f04ea-7ff6-4568-be76-60276d18b209@linaro.org> <49ecab2e-8f36-47be-a1b0-1bb0089dab0f@kernel.org> <57d5d6ea-5fef-423c-9f85-5f295bfa4c5f@linaro.org> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <57d5d6ea-5fef-423c-9f85-5f295bfa4c5f@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_003816_461896_A53B7B5D X-CRM114-Status: GOOD ( 19.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/2/24 16:33, Krzysztof Kozlowski wrote: > On 02/04/2024 01:36, Damien Le Moal wrote: >> On 4/1/24 18:57, Krzysztof Kozlowski wrote: >>> On 01/04/2024 01:06, Damien Le Moal wrote: >>>> On 3/30/24 18:16, Krzysztof Kozlowski wrote: >>>>> On 30/03/2024 05:19, Damien Le Moal wrote: >>>>>> From: Wilfred Mallawa >>>>>> >>>>>> Describe the `ep-gpios` property which is used to map the PERST# input >>>>>> signal for endpoint mode. >>>>>> >>>>>> Signed-off-by: Wilfred Mallawa >>>>>> Signed-off-by: Damien Le Moal >>>>>> --- >>>>>> .../devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml | 3 +++ >>>>>> 1 file changed, 3 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>>>>> index 6b62f6f58efe..9331d44d6963 100644 >>>>>> --- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>>>>> +++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>>>>> @@ -30,6 +30,9 @@ properties: >>>>>> maximum: 32 >>>>>> default: 32 >>>>>> >>>>>> + ep-gpios: >>>>>> + description: Input GPIO configured for the PERST# signal. >>>>> >>>>> Missing maxItems. But more important: why existing property perst-gpios, >>>>> which you already have there in common schema, is not correct for this case? >>>> >>>> I am confused... Where do you find perst-gpios defined for the rk3399 ? >>>> Under Documentation/devicetree/bindings/pci/, the only schema I see using >>>> perst-gpios property are for the qcom (Qualcomm) controllers. >>> >>> You are right, it's so far only in Qualcomm. >>> >>>> The RC bindings for the rockchip rk3399 PCIe controller >>>> (pci/rockchip,rk3399-pcie.yaml) already define the ep-gpios property. So if >>> >>> Any reason why this cannot be named like GPIO? Is there already a user >>> of this in Linux kernel? Commit msg says nothing about this, so that's >>> why I would expect name matching the signal. >> >> The RC-mode PCIe controller node of the rk3399 DTS already defines the ep-gpios >> property for RC side PERST# signal handling. So we simply reused the exact same >> name to be consistent between RC and EP. I personnally have no preferences. If >> there is an effort to rename such signal with some preferred pattern, I will >> follow. For the EP node, there was no PERST signal handling in the driver and >> no property defined for it, so any name is fine. "perst-gpios" would indeed be >> a better name, but again, given that the RC controller node has ep-gpios, we >> reused that. What is your recommendation here ? > > Actually I don't know, perst and ep would work for me. If you do not > have code for this in the driver yet (nothing is shared between ep and > host), then maybe let's go with perst to match the actual name. That works for me. The other simple solution would be to move the RC node ep-gpios description to the common schema pci/rockchip,rk3399-pcie-common.yaml, maybe ? Otherwise, perst-gpios like the Qualcomm schemas would be nice too. > > Anyway, you need maxItems. I sent a patch for the other binding: > https://lore.kernel.org/all/20240401100058.15749-1-krzysztof.kozlowski@linaro.org/ Thanks for that. > > Best regards, > Krzysztof > -- Damien Le Moal Western Digital Research _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel