From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEF23EB64DD for ; Thu, 13 Jul 2023 07:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wt2a1QrYznpCq5ZKESumm1eKrU0iKd6y/O8Jl2+GHzc=; b=Z3gDm+cgISUP9r PmrY1JCH1ZSoNbgJAZys8VxhV/+Eq3IPVU0Nm1zh6NFJ3RbjYcz0Ej3GfEbl/6d1BveDV6Yl9Zibs b9JObU+icA90wRkyYMnnD6BevMnJH0s2mGVtAJ+BzgORWZ0U+z+ZXLxY9LXuiTBgODzMLqgTUP7C2 yVx2n00QdL3b2aXx57ZOx4m3rzSEZ17CZBTUB9mHSNSvlaGghUZQ3pX3YkPak+hK1g+OcdMKGxvj6 0MwWtKiKbIQqVN0GbrkAc/CThKNpV6nhwgm6vI7f8QNKOoHGxanUC0Nrqih9USynExVLoRnO4ZjuQ X1HVMSuxVq99g9eHnHqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJqqk-002FRb-0D; Thu, 13 Jul 2023 07:34:54 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJqqh-002FQ7-12; Thu, 13 Jul 2023 07:34:53 +0000 X-UUID: bd6e6310214f11ee83ed1395ce914268-20230713 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=J8Y791zY3vO0ZQD4QdyuA5O6S4XlLfjNukpyuK2hBTo=; b=UkRe49JIYua77g3feLuJwi95y0/SigNNoFTMyOx0NElQ07s46pztXsL/jWG9Cb6Bm4WLQk4P1sa4rDkx5LJnl4WajXD9/6wUTWP6AcMmYyBSrSHDJEqMAmW9RngspGqEMRlIumXLOmJ4IFSzIAV+RqKrMpLeP9wAreb7PzEugPg=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.28,REQID:85839f31-c978-46c6-856c-f0a3e40d92e8,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:45 X-CID-INFO: VERSION:1.1.28,REQID:85839f31-c978-46c6-856c-f0a3e40d92e8,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:45 X-CID-META: VersionHash:176cd25,CLOUDID:36f72e68-314d-4083-81b6-6a74159151eb,B ulkID:230713153415H68L1NPQ,BulkQuantity:4,Recheck:0,SF:29|28|17|19|48|102, TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:40,QS:nil,BEC:nil,COL:0 ,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:PA,DKP:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_SDM,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: bd6e6310214f11ee83ed1395ce914268-20230713 Received: from mtkmbs14n2.mediatek.inc [(172.21.101.76)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1814263651; Thu, 13 Jul 2023 00:34:45 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 13 Jul 2023 15:34:12 +0800 Received: from APC01-SG2-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 13 Jul 2023 15:34:11 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mqInOeW8jc6/hEZLFRaWLrP9S3m6wI4B9Qb3A04fIcKZVKIXvkwHwlH8SHNvZXyeUwUMNackOD7IPvK4jbc1qCfhciAi4O6wqJI8dpe7sKF3sJZm6sL7ozWkRO/eZM59g7XIQmbVQ4vIAxOtdnw5Bv2y6fZ7EnyfhvNaCfqnoadhuLoLojjwpSWWIcV7kQZcpX5qqkvfrU26eeMHUmy7a/fde1K86Pm0wykig/+8bwx+UbJckBBNE9m96UatneNHXLHp2CzVSP0Zbs+IsZV7p1V4C75aUqUuUu15kr/TNJmEHmL1SgPvCyHIxcwBNYQvBAOw3i0Uqi7oF5a0gMQmnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J8Y791zY3vO0ZQD4QdyuA5O6S4XlLfjNukpyuK2hBTo=; b=cfMkQ7roZismKXLVGKwaWVZiz2bqT2Yyn8KgDchmeMiupIOTQoY+AvwBe3mKaI/A/bwiJpivYAHWq7LZpZespyYoN1WTONBUMzBJQqowwZUQp9+IqwYNB4FLVMmmNDjp8UA8rfUIhGcy3HkGKgf/+FKxz6HUZPMO5Ndre7lY38+1ohR3aLJrYOi8PHNRDTQRzj3FU1ALo2aydB64SgzZqwWofqG56zYiwa6rMTvyFrtDjdgiL0o1mwnR0IZwUBd7+c3CkLh0ciUpKJrre1Bm8iUi3njr5av1yfIgoBtYLMxZlVfUuCxVx00uIqCLOpmuLI3Tj6mrMwNdMTce4tYRFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J8Y791zY3vO0ZQD4QdyuA5O6S4XlLfjNukpyuK2hBTo=; b=ReTHB/fdsQO0aQ31uz8pNnYqxFpPSt4mWZAoTIT8D4HUSWqT7mcI2C7cn+/NNKsUJOk2xy6A/Mt9TKU9QTuewIBh/H69F7vLMU7A1STy2V8XKS5deyb+8dga3fpyGJzC7lc85E8PohDT3ffrcUX51e6hz2xxymn1vOoi+G0lIE8= Received: from SL2PR03MB4204.apcprd03.prod.outlook.com (2603:1096:100:53::15) by SEYPR03MB7950.apcprd03.prod.outlook.com (2603:1096:101:169::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.32; Thu, 13 Jul 2023 07:34:09 +0000 Received: from SL2PR03MB4204.apcprd03.prod.outlook.com ([fe80::308:e3ed:1ec8:f918]) by SL2PR03MB4204.apcprd03.prod.outlook.com ([fe80::308:e3ed:1ec8:f918%3]) with mapi id 15.20.6588.022; Thu, 13 Jul 2023 07:34:09 +0000 From: =?utf-8?B?VGluZ0hhbiBTaGVuICjmsojlu7fnv7Ap?= To: "mathieu.poirier@linaro.org" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-remoteproc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "conor+dt@kernel.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "andersson@kernel.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v14 07/12] remoteproc: mediatek: Remove dependency of MT8195 SCP L2TCM power control on dual-core SCP Thread-Topic: [PATCH v14 07/12] remoteproc: mediatek: Remove dependency of MT8195 SCP L2TCM power control on dual-core SCP Thread-Index: AQHZsJO3lAlinBBl8E2mWUSOotwCEK+03xWAgAJ4k4A= Date: Thu, 13 Jul 2023 07:34:08 +0000 Message-ID: <80c5a207beb41259b075d43552839c277b294a6e.camel@mediatek.com> References: <20230707052612.27521-1-tinghan.shen@mediatek.com> <20230707052612.27521-8-tinghan.shen@mediatek.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SL2PR03MB4204:EE_|SEYPR03MB7950:EE_ x-ms-office365-filtering-correlation-id: 1aef0ef2-3017-4244-100e-08db83738b89 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jNnkt4EgYyAUllnYENEX+3rIhbNvQyY6Pbr4YR9azr+cWyBGEpZX9V03DStdHHWiUeorlamuz+JnWp3/3pRSdsQIRHpI351l36g7x9L5RWCYqSpmXkp9xOkeCy91LGO21csTq0g/udWhANhcXif250s1aOySV3NBpxp0lQ4YerA/Zm/jjHVmyQkkXIjbq1aaIc4Pc6+AGWVBq9eWqPAzFc75gHZJ7VJjE4WAVoVoepg9mTDDgdzx0d/jphMXXnI37J2EC6wHzFzRSx7X04SRNuFozYEc/jkCjHaSN2KtEPkrgsAUfjZnEwVEGLX3Xek7Zqot54gJ+Z2hHpNkKjhm3bq3W3P88TuUvhbyhFZs4pDTudgmQi5FXAbLNjskrkaybaCA+V05m6WJHgXI/GzrFu7I4a62JSgVHyCWXbQZJNDWKhEGoobMHRFZKOHYmi/uWs9pE4HYngVDbDdC8rbOG6OwSLEHn8AS4MRBxm6IsWSWHlfGx3O2YShhLWsRt80rOxooD/pb4BblpfgYSYbZKzSde1pzT2xpN9hLXHyRNfO9p5pjMnIeMO/vOLbYomljmmWRPl5tOCVv8BRMgJoS6bqNHFiFYtEWJsFXgj8EtIHscwMyIaYT41k2rl3Dl773gjJzpf12g10FPb4WSYSQJsrijBI9nCmsDtnBVLxKFTs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SL2PR03MB4204.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(376002)(396003)(346002)(366004)(451199021)(66446008)(41300700001)(4326008)(7416002)(2906002)(6916009)(66946007)(64756008)(66556008)(66476007)(91956017)(5660300002)(71200400001)(478600001)(316002)(76116006)(86362001)(38100700002)(8936002)(8676002)(6486002)(6512007)(85182001)(36756003)(26005)(83380400001)(6506007)(38070700005)(186003)(122000001)(54906003)(2616005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eE5MQ0hBdDlRVEQySTlsQklLOXkrTk1WbFR0Ly8wSFVOTWdPNnllUk9ZNGV3?= =?utf-8?B?R3Rvd1Z1YzJxcm9ENnQ1QlJJZWtONVFMaVQ2R3BCMTZuc1FJMFMzNjN2cWxh?= =?utf-8?B?VnQ3b3EyMUdqUWdqUVBzd1F3NmRCOFZOaHdmTVozbW90bU5yVDBUZUxmTEZi?= =?utf-8?B?cnNjbGg5NW5jNFI0TGxlYUZRZDI3bVRyVVNZbXhiWDhnQ2plL0VON0xST1B4?= =?utf-8?B?dnRXdU5MQTFDTmMyY0M2UDdaSUxGZG1rRkkzVDZrbVF1VEVZdkFFQjlsb0Ju?= =?utf-8?B?TjR6V0JKU0lRZ2Y1NFgxTXRkM0MzZkl6OHBIdWNqVXRUeGo2UGk0RFlJblNR?= =?utf-8?B?OXFSdnlYTGp5aDVGY2dOajlUM1IwL1BLaFhNQ1lteGRDbGRvbVd1VmNjWWtJ?= =?utf-8?B?M3B4Vm1IbXZIaWNrT0J6Znl6MzlHb3JCeFhuTlJmNXR0alFtQ1JabE8yelVL?= =?utf-8?B?UTZQNnowblJSSjg3OEF5a2JlVElpU0EvVXQ3V3Flb1QrOXRnb1kwbk91eENU?= =?utf-8?B?bnMzLzkrUW9WK05zYmJOWG5jdER0T1FxSXZmUTJuZUp1MjUzZ281ZmpFZ1k5?= =?utf-8?B?N3prcloxNEtkUUhURnArTDlyYnVwRjg2RVlGT1FxVTJYaGNYa3F0K3E5NXJX?= =?utf-8?B?RytTbVRvSzdXaUJsTzF0TU1TbCtoVWcxbkNpUERXeGQyYko4eE9NalJJYmdU?= =?utf-8?B?cmJFLzh2NzhjYzU1ZnVWR1BpYjBPUDg4RVJFL2tmVnNrSDlqZ2RXNUwzRktE?= =?utf-8?B?WmFTUHNpNkI5YmpUMVdubjhpMHFJcnhjTU5uR3JSQzQyYlgxWGlseHRYS3FF?= =?utf-8?B?RDl4Vk5RZVV4bkpjRjhZZEYySDlKd0RTL3pwMVV1eWhUeS9QSnpQWWhRcVBJ?= =?utf-8?B?T3JhMFd6UFZVaENNOUFCYzVvR01aQ201by9SNGVKRWtVODZvUUtMRTlpcnRB?= =?utf-8?B?aG9UeGx5aGxEaWh4YktaRGVJUGF1WnA5R3F6VHZFaG9tQTFEakFzNGRRTmFJ?= =?utf-8?B?UTdERmxFNTRyUXI5dXIyRGhXR2M1cU4rdWhXMDhiSDN0Q1pxZGhONWxXamlo?= =?utf-8?B?bys4aTF3UkRudHBLbTdDYlJUbXU3VmYwTzdieUg5UkFmd2xHbXRxUndHUWZO?= =?utf-8?B?VVEzQ2V2NlJwa0krNkFNeFBNdk9yOWg3TXJlZ2kzVGZWeEkrak1KaEwzcjBJ?= =?utf-8?B?RTh6TzNMcjFTZzFZdnNpamRKZ09pblo1WXVQWE05eVAwY00vaThzRm5OeFNu?= =?utf-8?B?OWFVV1dtN2lmSW5iWXE3STVmZUVRYVhNSDJ4NmxXcUUyV09xWVdLc0hLemJu?= =?utf-8?B?ajhEeFhxczdqQldTYkxvSFgvNUpnU3lXZDQzZ09JWVJNazJTTnM1bEN2NFNT?= =?utf-8?B?V3dFUm1qMDdlanJudjBaREprZDNUbTczeFRTQzM3U3FSVm9VL25UNEhhWUZU?= =?utf-8?B?WHBWNFR1aVo4MXNjSDNORXFsdzBCa0pteHhSMlY4di9RYXJVUUlxSDJJZDlE?= =?utf-8?B?YUNrQkFGd2p4NFU1VEFoaXh3b2t4V2t0KzFxS2I0YUZRK3Z4TlhNQU0vdG1J?= =?utf-8?B?NGI0VWdiZkcxZ2xCcG1kcW5XdlYwb3p5a3M1SFNXYU1uRERsblFGM21BVEhz?= =?utf-8?B?MkwrTkxPRld4UTFOdmZGY2tpOFZjanpmWEt4M2tOTG1JalRNeURqNXptVGxm?= =?utf-8?B?SStsdWVhZVVCTVNQRlhwblFWSTh0VFN6cVFHMENJK3N0TW9vWVlFWkhYTGRl?= =?utf-8?B?am5yR3lHV3h2R3lhSGNMYS9tYkVzZXRZaEdMRXE0bzZDR3NrS016eFhzbFJO?= =?utf-8?B?ZWViMlY1U2xHUXFGMFhCUG5oTmtGeUZ3bDVZSXltSXlKY1VSNGQxemtpcFdL?= =?utf-8?B?elMxcjgrUU1qOXhjYW43OURtaFZud3B0T3hMajdTYlc2MWpMakMvN25LQmJq?= =?utf-8?B?N2huTGcwZzFhRUFGcWF6WExJbktTOC9jUDVucTdnOU5vdlJLQm9oSW5zaWM1?= =?utf-8?B?UmhVcWhpazBvOWQvYWp4VmFJMjhiL0c3b21meG5wSXFET2VuTWNrcmpzeUZv?= =?utf-8?B?S2dRUWhqa1JRMnAvbnh4ODJ0UWtMbnB2cVFrUHlQdWxiY1p5R3ErcmNzZVBD?= =?utf-8?B?eS9Lbmgwc1gxck96aDhSVHY1UC8xdlFEM0VrRzJqNXQ1VTMvbU5WK2o1QVdh?= =?utf-8?B?VFE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SL2PR03MB4204.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1aef0ef2-3017-4244-100e-08db83738b89 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2023 07:34:08.8491 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CKiJjGGQ/Yjud2JoXibi6HfnMU5dBX1jULeYRhT6kojVUi+TpYu1k18VTCYSDL+0M1UZyS6kdc2Ngk+gv2f02yBkRSCwplqIs/nF4MuJEzU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR03MB7950 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_003451_372303_C81B4442 X-CRM114-Status: GOOD ( 26.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On Tue, 2023-07-11 at 11:50 -0600, Mathieu Poirier wrote: > On Fri, Jul 07, 2023 at 01:26:07PM +0800, Tinghan Shen wrote: > > Previously, SCP core 0 controlled the power of L2TCM and dictated that > > SCP core 1 could only boot after SCP core 0. To address this constraint, > > extracted the power control flow of L2TCM and made it shared > > between both cores, enabling support of arbitrary boot order. > > Definitely an improvement. > > > > > The flow for controlling L2TCM power has been incorporated into the > > mt8195_scp_before_load() and mt8195_scp_stop() APIs, which are > > respectively invoked during the rproc->ops->start() and > > rproc->ops->stop() operations. These APIs effectively serve the same > > purpose as the rproc prepare()/unprepare() APIs." > > I'm not fond of that custom API but it is so widespread in this driver that I > will go with it. > > > > > Signed-off-by: Tinghan Shen > > --- > > drivers/remoteproc/mtk_common.h | 1 + > > drivers/remoteproc/mtk_scp.c | 80 ++++++++++++++++++++++++++------- > > 2 files changed, 66 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/remoteproc/mtk_common.h b/drivers/remoteproc/mtk_common.h > > index 56395e8664cb..41e1b4732b75 100644 > > --- a/drivers/remoteproc/mtk_common.h > > +++ b/drivers/remoteproc/mtk_common.h > > @@ -130,6 +130,7 @@ struct mtk_scp { > > struct rproc_subdev *rpmsg_subdev; > > > > struct list_head elem; > > + struct platform_device *cluster_pdev; > > This isn't needed. rproc->dev.parent is pdev->dev. Use container_of() to > get to the platform device. Ok, I'll update it in the next version. > > > > }; > > > > /** > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > > index 3349488e5f21..94602272c05f 100644 > > --- a/drivers/remoteproc/mtk_scp.c > > +++ b/drivers/remoteproc/mtk_scp.c > > @@ -29,6 +29,10 @@ struct mtk_scp_of_cluster { > > size_t l1tcm_size; > > phys_addr_t l1tcm_phys; > > struct list_head mtk_scp_list; > > + > > + /* Prevent concurrent operations of L2TCM power control. */ > > + struct mutex l2tcm_lock; > > + u32 l2tcm_refcnt; > > }; > > > > /** > > @@ -449,7 +453,7 @@ static int mt8192_scp_before_load(struct mtk_scp *scp) > > > > writel(1, scp->reg_base + MT8192_CORE0_SW_RSTN_SET); > > > > - /* enable SRAM clock */ > > + /* enable SRAM power */ > > scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_0, 0); > > scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_1, 0); > > scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_2, 0); > > @@ -462,19 +466,38 @@ static int mt8192_scp_before_load(struct mtk_scp *scp) > > return 0; > > } > > > > -static int mt8195_scp_before_load(struct mtk_scp *scp) > > +static int mt8195_scp_l2tcm_on(struct mtk_scp *scp) > > { > > - /* clear SPM interrupt, SCP2SPM_IPC_CLR */ > > - writel(0xff, scp->reg_base + MT8192_SCP2SPM_IPC_CLR); > > + struct mtk_scp_of_cluster *scp_cluster = platform_get_drvdata(scp->cluster_pdev); > > + > > + mutex_lock(&scp_cluster->l2tcm_lock); > > + > > + if (scp_cluster->l2tcm_refcnt == 0) { > > + /* clear SPM interrupt, SCP2SPM_IPC_CLR */ > > + writel(0xff, scp->reg_base + MT8192_SCP2SPM_IPC_CLR); > > + > > + /* Power on L2TCM */ > > + scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_0, 0); > > + scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_1, 0); > > + scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_2, 0); > > + scp_sram_power_on(scp->reg_base + MT8192_L1TCM_SRAM_PDN, > > + MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS); > > + } > > + > > + scp_cluster->l2tcm_refcnt += 1; > > > > + mutex_unlock(&scp_cluster->l2tcm_lock); > > + > > + return 0; > > +} > > + > > +static int mt8195_scp_before_load(struct mtk_scp *scp) > > +{ > > writel(1, scp->reg_base + MT8192_CORE0_SW_RSTN_SET); > > > > + mt8195_scp_l2tcm_on(scp); > > + > > /* enable SRAM clock */ > > - scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_0, 0); > > - scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_1, 0); > > - scp_sram_power_on(scp->reg_base + MT8192_L2TCM_SRAM_PD_2, 0); > > - scp_sram_power_on(scp->reg_base + MT8192_L1TCM_SRAM_PDN, > > - MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS); > > scp_sram_power_on(scp->reg_base + MT8192_CPU0_SRAM_PD, 0); > > > > /* enable MPU for all memory regions */ > > @@ -487,6 +510,8 @@ static int mt8195_scp_c1_before_load(struct mtk_scp *scp) > > { > > scp->data->scp_reset_assert(scp); > > > > + mt8195_scp_l2tcm_on(scp); > > + > > scp_sram_power_on(scp->reg_base + MT8195_CPU1_SRAM_PD, 0); > > > > /* enable MPU for all memory regions */ > > @@ -653,14 +678,30 @@ static void mt8192_scp_stop(struct mtk_scp *scp) > > writel(0, scp->reg_base + MT8192_CORE0_WDT_CFG); > > } > > > > +static void mt8195_scp_l2tcm_off(struct mtk_scp *scp) > > +{ > > + struct mtk_scp_of_cluster *scp_cluster = platform_get_drvdata(scp->cluster_pdev); > > + > > + mutex_lock(&scp_cluster->l2tcm_lock); > > + > > What happens if ->l2tcm_refcnt is 0 and this function is called? Thanks, I'll check this condition in the next version. Best regards, TingHan. > > > > + scp_cluster->l2tcm_refcnt -= 1; > > + > > + if (scp_cluster->l2tcm_refcnt == 0) { > > + /* Power off L2TCM */ > > + scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_0, 0); > > + scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_1, 0); > > + scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_2, 0); > > + scp_sram_power_off(scp->reg_base + MT8192_L1TCM_SRAM_PDN, 0); > > + scp_sram_power_off(scp->reg_base + MT8192_CPU0_SRAM_PD, 0); > > + } > > + > > + mutex_unlock(&scp_cluster->l2tcm_lock); > > +} > > + > > static void mt8195_scp_stop(struct mtk_scp *scp) > > { > > - /* Disable SRAM clock */ > > - scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_0, 0); > > - scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_1, 0); > > - scp_sram_power_off(scp->reg_base + MT8192_L2TCM_SRAM_PD_2, 0); > > - scp_sram_power_off(scp->reg_base + MT8192_L1TCM_SRAM_PDN, > > - MT8195_L1TCM_SRAM_PDN_RESERVED_RSI_BITS); > > + mt8195_scp_l2tcm_off(scp); > > + > > scp_sram_power_off(scp->reg_base + MT8192_CPU0_SRAM_PD, 0); > > > > /* Disable SCP watchdog */ > > @@ -669,6 +710,8 @@ static void mt8195_scp_stop(struct mtk_scp *scp) > > > > static void mt8195_scp_c1_stop(struct mtk_scp *scp) > > { > > + mt8195_scp_l2tcm_off(scp); > > + > > /* Power off CPU SRAM */ > > scp_sram_power_off(scp->reg_base + MT8195_CPU1_SRAM_PD, 0); > > > > @@ -976,6 +1019,8 @@ static int scp_add_single_core(struct platform_device *pdev) > > if (IS_ERR(scp)) > > return PTR_ERR(scp); > > > > + scp->cluster_pdev = pdev; > > + > > ret = rproc_add(scp->rproc); > > if (ret) { > > dev_err(dev, "Failed to add rproc\n"); > > @@ -1028,6 +1073,8 @@ static int scp_add_multi_core(struct platform_device *pdev) > > goto init_fail; > > } > > > > + scp->cluster_pdev = pdev; > > + > > ret = rproc_add(scp->rproc); > > if (ret) { > > dev_err(dev, "Failed to add rproc of core %d\n", core_id); > > @@ -1114,6 +1161,7 @@ static int scp_probe(struct platform_device *pdev) > > } > > > > INIT_LIST_HEAD(&scp_cluster->mtk_scp_list); > > + mutex_init(&scp_cluster->l2tcm_lock); > > platform_set_drvdata(pdev, scp_cluster); > > > > ret = devm_of_platform_populate(dev); > > @@ -1137,6 +1185,8 @@ static void scp_remove(struct platform_device *pdev) > > rproc_del(scp->rproc); > > scp_free(scp); > > } > > + > > + mutex_destroy(&scp_cluster->l2tcm_lock); > > } > > > > static const struct mtk_scp_of_data mt8183_of_data = { > > -- > > 2.18.0 -- Best regards, TingHan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel