[PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure

[PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure

[Daniel Lezcano]

From: Markus Elfring <elfring@users.sourceforge.net>

The bcm2835_timer_init() function emits an error message in case of a memory
allocation failure. This is pointless as the mm core already do that.

Remove this message.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/bcm2835_timer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clocksource/bcm2835_timer.c b/drivers/clocksource/bcm2835_timer.c
index 82828d3..39e489a 100644
--- a/drivers/clocksource/bcm2835_timer.c
+++ b/drivers/clocksource/bcm2835_timer.c
@@ -114,7 +114,6 @@ static int __init bcm2835_timer_init(struct device_node *node)
 
 	timer = kzalloc(sizeof(*timer), GFP_KERNEL);
 	if (!timer) {
-		pr_err("Can't allocate timer struct\n");
 		ret = -ENOMEM;
 		goto err_iounmap;
 	}
-- 
2.7.4

[PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure

[SF Markus Elfring]

I would prefer to use the wording ?for a? instead of ?on? in the commit subject.


> The bcm2835_timer_init() function emits an error message in case of a memory
> allocation failure. This is pointless as the mm core already do that.

Does this commit message contain a typo?
Would a wording like ?? does that already.? be more appropriate here?

Regards,
Markus

[PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure

[Daniel Lezcano]

On 29/08/2017 13:21, SF Markus Elfring wrote:
> I would prefer to use the wording ?for a? instead of ?on? in the commit subject.
> 
> 
>> The bcm2835_timer_init() function emits an error message in case of a memory
>> allocation failure. This is pointless as the mm core already do that.
> 
> Does this commit message contain a typo?
> Would a wording like ?? does that already.? be more appropriate here?

Yep. Fixed.

Thanks.

  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure

[SF Markus Elfring]

>> Would a wording like ?? does that already.? be more appropriate here?
> 
> Yep. Fixed.

Thanks for this adjustment.
https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa

Do you disagree to my suggestion to amend also the commit subject?

Regards,
Markus

[PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure

[Daniel Lezcano]

On 29/08/2017 15:12, SF Markus Elfring wrote:
>>> Would a wording like ?? does that already.? be more appropriate here?
>>
>> Yep. Fixed.
> 
> Thanks for this adjustment.
> https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa
> 
> Do you disagree to my suggestion to amend also the commit subject?

Just wanted to keep it short.


-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

clocksource/drivers/bcm2835: Remove message on memory allocation failure

[SF Markus Elfring]

>> https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa
>>
>> Do you disagree to my suggestion to amend also the commit subject?
> 
> Just wanted to keep it short.

I propose to reconsider the preposition which should be used in the title.

Regards,
Markus

clocksource/drivers/bcm2835: Remove message on memory allocation failure

[Daniel Lezcano]

On 29/08/2017 15:20, SF Markus Elfring wrote:
>>> https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=clockevents/4.14&id=fd388bc07c2ca854f28f405bb65470647499dcaa
>>>
>>> Do you disagree to my suggestion to amend also the commit subject?
>>
>> Just wanted to keep it short.
> 
> I propose to reconsider the preposition which should be used in the title.

Done.


-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog