From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: "Avi Fishman" <avifishman70@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Joel Stanley" <joel@jms.id.au>,
"Patrick Venture" <venture@google.com>,
"Nancy Yuen" <yuenn@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>,
"Olof Johansson" <olof@lixom.net>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>,
"Robert Hancock" <robert.hancock@calian.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Lubomir Rintel" <lkundrak@v3.sk>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 10/20] ARM: dts: nuvoton: add reset syscon property
Date: Fri, 10 Jun 2022 11:51:39 +0200 [thread overview]
Message-ID: <80f9c2d5-52d9-b03d-c272-ac475ae8c69e@linaro.org> (raw)
In-Reply-To: <CAP6Zq1iCJO3AzHnG7RSQ1pyVwayxs+X3iVM4U=6j2k0EgR7psg@mail.gmail.com>
On 09/06/2022 23:30, Tomer Maimon wrote:
> Hi Krzysztof,
>
> Thanks for your comments
>
> On Wed, 8 Jun 2022 at 13:07, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 08/06/2022 11:56, Tomer Maimon wrote:
>>> Add nuvoton,sysgcr syscon property to the reset
>>> node to handle the general control registers.
>>
>> Wrong wrapping.
> it will be very helpful if you could point me what wrong wrapped in
> the commit message, is it the explanation or the header? or something
> else?
I pointed you last time. I pointed the exact line, exact rule you need
to follow. I pointed it three times already and three times I said
wrapping is wrong:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
"The body of the explanation, line wrapped at 75 columns, which will be
copied to the permanent changelog to describe this patch."
Your wrapping is not at 75 columns and it causes the commit to be less
readable, without any reason. Please follow Linux kernel coding style/rules.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-10 10:00 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 9:56 [PATCH v2 00/20] Introduce Nuvoton Arbel NPCM8XX BMC SoC Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 01/20] clocksource: timer-npcm7xx: Add NPCM845 timer Tomer Maimon
2022-06-08 12:00 ` Arnd Bergmann
2022-06-08 9:56 ` [PATCH v2 02/20] dt-bindings: serial: 8250: Add npcm845 compatible string Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 03/20] tty: serial: 8250: Add NPCM845 UART support Tomer Maimon
2022-06-08 12:01 ` Arnd Bergmann
2022-06-08 13:40 ` Tomer Maimon
2022-06-08 13:46 ` Arnd Bergmann
2022-06-08 9:56 ` [PATCH v2 04/20] dt-bindings: watchdog: npcm: Add npcm845 compatible string Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 05/20] watchdog: npcm_wdt: Add NPCM845 watchdog support Tomer Maimon
2022-06-08 12:01 ` Arnd Bergmann
2022-06-16 21:06 ` Tomer Maimon
2022-06-16 21:11 ` Arnd Bergmann
2022-06-08 9:56 ` [PATCH v2 06/20] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock Tomer Maimon
2022-06-08 10:03 ` Krzysztof Kozlowski
2022-06-09 13:17 ` Tomer Maimon
2022-06-09 13:22 ` Krzysztof Kozlowski
2022-06-09 21:21 ` Tomer Maimon
2022-06-10 9:49 ` Krzysztof Kozlowski
2022-06-09 17:44 ` Jonathan Neuschäfer
2022-06-08 9:56 ` [PATCH v2 07/20] clk: npcm8xx: add clock controller Tomer Maimon
2022-06-09 22:14 ` Stephen Boyd
2022-06-09 22:42 ` Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 08/20] dt-bindings: reset: modify to general NPCM name Tomer Maimon
2022-06-08 10:03 ` Krzysztof Kozlowski
2022-06-09 21:25 ` Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 09/20] dt-bindings: reset: npcm: add GCR syscon property Tomer Maimon
2022-06-08 10:06 ` Krzysztof Kozlowski
2022-06-08 21:48 ` Rob Herring
2022-06-08 9:56 ` [PATCH v2 10/20] ARM: dts: nuvoton: add reset " Tomer Maimon
2022-06-08 10:07 ` Krzysztof Kozlowski
2022-06-09 21:30 ` Tomer Maimon
2022-06-09 22:10 ` Benjamin Fair
2022-06-09 23:22 ` Tomer Maimon
2022-06-10 9:51 ` Krzysztof Kozlowski [this message]
2022-06-13 7:15 ` Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 11/20] reset: npcm: using syscon instead of device data Tomer Maimon
2022-06-08 10:08 ` Krzysztof Kozlowski
2022-06-09 21:37 ` Tomer Maimon
2022-06-10 9:53 ` Krzysztof Kozlowski
2022-06-13 7:16 ` Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 12/20] dt-bindings: reset: npcm: Add support for NPCM8XX Tomer Maimon
2022-06-08 10:11 ` Krzysztof Kozlowski
2022-06-09 22:05 ` Tomer Maimon
2022-06-10 9:55 ` Krzysztof Kozlowski
2022-06-13 9:25 ` Tomer Maimon
2022-06-15 17:03 ` Krzysztof Kozlowski
2022-06-16 13:24 ` Tomer Maimon
2022-06-16 13:38 ` Krzysztof Kozlowski
2022-06-16 13:41 ` Tomer Maimon
2022-06-16 13:42 ` Krzysztof Kozlowski
2022-06-08 9:56 ` [PATCH v2 13/20] reset: npcm: Add NPCM8XX support Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 14/20] dt-bindings: arm: npcm: Add maintainer Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 15/20] dt-bindings: arm: npcm: Add nuvoton,npcm845 compatible string Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 16/20] dt-bindings: arm: npcm: Add nuvoton,npcm845 GCR " Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 17/20] arm64: npcm: Add support for Nuvoton NPCM8XX BMC SoC Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 18/20] arm64: dts: nuvoton: Add initial NPCM8XX device tree Tomer Maimon
2022-06-08 10:21 ` Krzysztof Kozlowski
2022-06-09 22:29 ` Tomer Maimon
2022-06-10 7:57 ` Geert Uytterhoeven
2022-06-10 9:59 ` Krzysztof Kozlowski
2022-06-10 9:59 ` Krzysztof Kozlowski
2022-06-08 9:56 ` [PATCH v2 19/20] arm64: dts: nuvoton: Add initial NPCM845 EVB " Tomer Maimon
2022-06-08 9:56 ` [PATCH v2 20/20] arm64: defconfig: Add Nuvoton NPCM family support Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80f9c2d5-52d9-b03d-c272-ac475ae8c69e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=j.neuschaefer@gmx.net \
--cc=jirislaby@kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkundrak@v3.sk \
--cc=marcel.ziswiler@toradex.com \
--cc=mturquette@baylibre.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=robert.hancock@calian.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tglx@linutronix.de \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).