From: john.ogness@linutronix.de (John Ogness)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] mtd: mxc_nand fixups
Date: Sat, 19 Jun 2010 22:25:25 +0200 [thread overview]
Message-ID: <80sk4ivkga.fsf@merkur.tec.linutronix.de> (raw)
In-Reply-To: <20100618205401.GA12115@pengutronix.de> (Sascha Hauer's message of "Fri, 18 Jun 2010 22:54:01 +0200")
On 2010-06-18, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>> This patch reverts the driver to enabling/disabling the NFC interrupt
>> mask rather than enabling/disabling the system interrupt. This cleans
>> up the driver so that it doesn't rely on interrupts being disabled
>> within the interrupt handler.
>
> This behaviour was introduced in
> a47bfd2eb66837653dc3b42541dfe4283dd41251 mxc_nand: support i.MX21
>
> I guess this won't work on i.MX21.
I just downloaded the i.MX21 reference manual and its NFC interrupts can
also be masked with INT_MASK (bit 4) of NFC_Flash_Config1 (0xdf003e1a).
IMHO we should revert the driver to masking the NFC interrupts. The
current linux-next version with nosync irq disabling within the
interrupt handler is a bit silly. Especially since the interrupt handler
does nothing except signal a wait queue.
John Ogness
next prev parent reply other threads:[~2010-06-19 20:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 17:01 [PATCH 4/5] mtd: mxc_nand fixups John Ogness
2010-06-18 20:54 ` Sascha Hauer
2010-06-19 20:25 ` John Ogness [this message]
2010-06-20 9:09 ` Ivo Clarysse
2010-06-20 9:21 ` [PATCHv2 " John Ogness
2010-06-21 11:47 ` Ivo Clarysse
2010-06-22 15:54 ` [PATCHv3 " John Ogness
2010-06-23 7:34 ` Ivo Clarysse
2010-06-23 8:48 ` John Ogness
2010-06-23 9:23 ` Ivo Clarysse
2010-06-23 10:10 ` John Ogness
2010-06-24 7:27 ` Sascha Hauer
2010-06-24 10:16 ` John Ogness
2010-06-25 14:50 ` Ivo Clarysse
2010-06-26 9:17 ` John Ogness
2010-07-01 14:24 ` Ivo Clarysse
2010-06-25 14:46 ` Ivo Clarysse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80sk4ivkga.fsf@merkur.tec.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox