From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C491FC77B73 for ; Fri, 21 Apr 2023 01:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:From:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kXOzuNZUtCBwxAuI8c3CANcHWlNJvRdcwJa9X0CzX7k=; b=oKuzSGyWJmxoX6 JKgvwZorRTzCORWE5dD8LV8O9EYOp5pjGlM9OKFJFzQBTAq9OKK23ZRSCof77cyWDigSZ5qOsA1mq QIPnkdW/qCygmrXk2FtolMkrpohHal2lLG+a3G1MdVewKzg1NbwGw0ojuOuCFCCASWn4YEU6NlimS Ybjjyt4uVNCeTl5rsjlwCH8j5t05mPUE54+UqZAjvXgODvmzyVayl4kjInmEplxHZjbfVh3M2M3oc COy/rkU7wcZnJPbsUTh5f0wxxTUgR5AFOIK6eh8036aCGjpj/VStEvtBWZca0pu+JuWIQz9uAlNKo pgYMTn8tCkMK2G0ktseg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppfsJ-009PKC-09; Fri, 21 Apr 2023 01:47:47 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppfsF-009PIZ-1j for linux-arm-kernel@lists.infradead.org; Fri, 21 Apr 2023 01:47:45 +0000 Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20230421014735epoutp03eee1ced283f257e9b9e82a37bd034070~Xz-lU99i03270332703epoutp03f for ; Fri, 21 Apr 2023 01:47:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20230421014735epoutp03eee1ced283f257e9b9e82a37bd034070~Xz-lU99i03270332703epoutp03f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1682041655; bh=cCyrDxiGndEUcSfg/w6e0yeLBQlNiTq5y+DlcxQS26w=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=cuE1q+8bOCBjqR9RqpAF2bZZqv7tebYfRYg2qNSmBjPWdCbRSYoQ0sVqWIPQ7ukGC MsERCcrZ5gY65BXXW7LNP3pfKAQS8ZyxrbtDApJ1NEKRpJdywZen/MMhrY+MHnMf4Z mgbmQDETD/w8ZinbqYuIkJX/tJ9BvyYroAp35qI0= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas2p3.samsung.com (KnoxPortal) with ESMTP id 20230421014735epcas2p3487e881fd4a99147fb18396797915755~Xz-k3sgD30212302123epcas2p3N; Fri, 21 Apr 2023 01:47:35 +0000 (GMT) Received: from epsmges2p2.samsung.com (unknown [182.195.36.97]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4Q2cpt5fj9z4x9Q0; Fri, 21 Apr 2023 01:47:34 +0000 (GMT) Received: from epcas2p3.samsung.com ( [182.195.41.55]) by epsmges2p2.samsung.com (Symantec Messaging Gateway) with SMTP id 18.D3.10686.63BE1446; Fri, 21 Apr 2023 10:47:34 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p2.samsung.com (KnoxPortal) with ESMTPA id 20230421014734epcas2p2417b3b2c41589801924ae76aef92dbb2~Xz-kHy2Zm2869928699epcas2p2L; Fri, 21 Apr 2023 01:47:34 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230421014734epsmtrp293506ac03135b57fe7c766a71f974a34~Xz-kHEdzI1041910419epsmtrp2j; Fri, 21 Apr 2023 01:47:34 +0000 (GMT) X-AuditID: b6c32a46-c81ff700000029be-83-6441eb36a7d0 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 38.1E.08279.63BE1446; Fri, 21 Apr 2023 10:47:34 +0900 (KST) Received: from [10.229.8.168] (unknown [10.229.8.168]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230421014734epsmtip2370ec0f8b6e30d121996234a1f15f83f~Xz-j1tqFY1101211012epsmtip2W; Fri, 21 Apr 2023 01:47:34 +0000 (GMT) Message-ID: <812a93ad-af21-5b34-8199-1ccaae325ce5@samsung.com> Date: Fri, 21 Apr 2023 10:45:09 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 1/4] spi: s3c64xx: changed to PIO mode if there is no DMA Content-Language: en-US To: Krzysztof Kozlowski , Mark Brown , Andi Shyti , Alim Akhtar Cc: linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chanho Park From: Jaewon Kim In-Reply-To: <087ba4df-7575-acce-309a-efb5115a987d@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCJsWRmVeSWpSXmKPExsWy7bCmua7Za8cUg5dXNCwezNvGZrH4x3Mm i6kPn7BZXN6vbbH39VZ2i02Pr7FaXN41h81ixvl9TBaNH2+yO3B6XF/yidlj06pONo871/aw eWxeUu/Rt2UVo8fnTXIBbFHZNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJ uam2Si4+AbpumTlANykplCXmlAKFAhKLi5X07WyK8ktLUhUy8otLbJVSC1JyCswL9IoTc4tL 89L18lJLrAwNDIxMgQoTsjN+PL/AVrCIvaK3ez1LA+Mt1i5GDg4JAROJ81cluxg5OYQEdjBK bDqh1cXIBWR/YpS4cG4yE4TzjVFi7/cfrCBVIA3b9/9jg0jsZZR4evUfI4TzmlFi/qPd7CBV vAJ2EhubfrKB2CwCqhJ/j21ihIgLSpyc+YQFxBYViJZYvG8KmC0sECSx5N99JhCbWUBc4taT +WCrRQQWM0r0Pf4Eto5ZYCOjxOamqWAb2AS0Jb6vXwx2EyfQtm2X7rJBdMtLbH87hxmkQUJg LofE6blf2CEOd5G41LSOBcIWlnh1fAtUXEri87u9bBB2tkT79D9Qj1ZIXNwwGypuLDHrWTsj KMSYBTQl1u/ShwSessSRWywQa/kkOg7/ZYcI80p0tAlBNKpJ3J96DmqIjMSkIyuZIGwPiSsd 25gnMCrOQgqWWUjen4XkmVkIexcwsqxiFEstKM5NTy02KjCCR3Zyfu4mRnBy1XLbwTjl7Qe9 Q4xMHIyHGCU4mJVEeM+4WqUI8aYkVlalFuXHF5XmpBYfYjQFRs5EZinR5Hxges8riTc0sTQw MTMzNDcyNTBXEueVtj2ZLCSQnliSmp2aWpBaBNPHxMEp1cC0Tzj3c95L18Uy2WwuLVN0ZzK/ iXpS4xwy6/DXWfxfXu29x+T30npHxdmQ1/YT1MzKmo3Pnehvmnvki9iVc1acjyauD38Rom3z 4/iHfzLFS/V/Sx898OX7w3Pay4wCH546+qZvic1H9/qIP/YvI/hbxXa1qRh/lrj5m2eV8uev G9jayj9+b/yyXFFm48d1WTNWngqp4y6aKyCbLZPJP/vTBL7Jpf3LOP79Xhdi0rR3S6Zy49J/ JdwNFUozRQzmp9au7pXzd7Y60NW4M8c1Km/tbdc3ag1BEZJFgvtTWreqTSrddTs21emV6M62 pUa9Nw59FlDqXSL/XGe6YWCjRfa66aU/ZMztsrRZdt+x1GlRYinOSDTUYi4qTgQAw5XDJjcE AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42LZdlhJXtfstWOKwfdtPBYP5m1js1j84zmT xdSHT9gsLu/Xttj7eiu7xabH11gtLu+aw2Yx4/w+JovGjzfZHTg9ri/5xOyxaVUnm8eda3vY PDYvqffo27KK0ePzJrkAtigum5TUnMyy1CJ9uwSujB/PL7AVLGKv6O1ez9LAeIu1i5GTQ0LA RGL7/n9sXYxcHEICuxklznY2sEEkZCSWP+uDsoUl7rccYYUoeskoceP8E7AEr4CdxMamn2A2 i4CqxN9jmxgh4oISJ2c+YQGxRQWiJW4s/8YEYgsLBEks+XcfzGYWEJe49WQ+E8hQEYHFjBId l96ygzjMAhsZJVZeX88Mse4no0T3iVlgY9kEtCW+r18Mdjgn0Optl+6yQYwyk+ja2sUIYctL bH87h3kCo9AsJJfMQrJxFpKWWUhaFjCyrGKUTC0ozk3PLTYsMMxLLdcrTswtLs1L10vOz93E CI4rLc0djNtXfdA7xMjEwXiIUYKDWUmE193GLkWINyWxsiq1KD++qDQntfgQozQHi5I474Wu k/FCAumJJanZqakFqUUwWSYOTqkGJmmHLCOjbx+sij51Xvu95N+bX+kKedW8tsxp++wL9RO6 mR9m7sk2L+62UOU7zbFrv7oa0x5J/jv/NwhrxB3Mbp2vM6fM4dGB0I5gy4uXjCevFzl+X87M 7v9z3fiaTYbRCS/Kp8YleUknz5/duDJ1u93ZT4cObTW8kBtnNS9xp39pzzLJkzdq3l1inMP3 YFlGe+jv73UOW/e9LZEVn5PLqXNrz+wL2hHnQv5xpDQe+8p1/0luX8CUYCmFb2It22ZtuxYb cd51X8HVo3Znue+x6rzUMT/7MCDygojPHi6VxMSOIommM5I7J/vdutLdLhvEU/Bt3g422RWK +0Re1e/a7J5seP7r6tmPhHYtLb5pocRSnJFoqMVcVJwIAACqr4QaAwAA X-CMS-MailID: 20230421014734epcas2p2417b3b2c41589801924ae76aef92dbb2 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230419062755epcas2p1370c1ca60d88d6b114a7c7c1de3f15c0 References: <20230419060639.38853-1-jaewon02.kim@samsung.com> <20230419060639.38853-2-jaewon02.kim@samsung.com> <087ba4df-7575-acce-309a-efb5115a987d@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230420_184744_037973_98A4324E X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23. 4. 21. 00:40, Krzysztof Kozlowski wrote: > On 19/04/2023 08:06, Jaewon Kim wrote: >> Polling mode supported with qurik if there was no DMA in the SOC. >> However, there are cased where we cannot or do not want to use DMA. >> To support this case, if DMA is not set, it is switched to polling mode. >> > (...) > >> #define msecs_to_loops(t) (loops_per_jiffy / 1000 * HZ * t) >> -#define is_polling(x) (x->port_conf->quirks & S3C64XX_SPI_QUIRK_POLL) >> +#define is_polling(x) (x->cntrlr_info->polling) >> >> #define RXBUSY (1<<2) >> #define TXBUSY (1<<3) >> @@ -1067,6 +1066,11 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_dt(struct device *dev) >> sci->num_cs = temp; >> } >> >> + if (!of_find_property(dev->of_node, "dmas", NULL)) { > of_property_present() I will change it to of_property_present(). > > Best regards, > Krzysztof > > Thanks Jaewon Kim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel