From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C63C4742C for ; Tue, 3 Nov 2020 01:19:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28759223AB for ; Tue, 3 Nov 2020 01:19:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yk2p3Bvz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28759223AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AxVSGALpKCbNITgGIgctZWihokxFZpygyFQg5SJVIGQ=; b=yk2p3Bvz5o7+j62PByjlyaIR7 t2zwNbrkaFa6IBrgjMVwkvkExK7jkwzZmttLap3XGVYvtAbi3QhEm03KopM7wfte7CYufgwpDdl50 smD6zxfPuF7E3X/x4Wd/fZ4nydMT4Bm4pp4zTLvSygC5hcTaq9xoSldjkowiwcAhE7eGpi/r1j6kq BlMAk8p5i0N0qvpc0MnRqK1eYwq2Ae8G1J/9vT6sLGQWAHOxRbHwP53q+W34ODjcChNrBv3/eOExG CdgjDzn/jp6I8S7p6S73puCO3VZO8MoYklfvAtpWUCe915quTw/ALzxPXUVfIeuw1bK31xu+hLAhu aKfLh7jUQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZkyD-0004kV-Ul; Tue, 03 Nov 2020 01:18:46 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZky7-0004jI-TM for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 01:18:41 +0000 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CQBk66jMZz15NlQ; Tue, 3 Nov 2020 09:18:22 +0800 (CST) Received: from [127.0.0.1] (10.65.95.32) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Tue, 3 Nov 2020 09:18:15 +0800 Subject: Re: [PATCH] coresight: funnel: Remove unnecessary .owner of static funnel driver To: Mathieu Poirier References: <1604139150-18659-1-git-send-email-liuqi115@huawei.com> <20201102172330.GB2749502@xps15> From: Qi Liu Message-ID: <813ceaa8-9bad-6e10-45f8-a56656519f63@huawei.com> Date: Tue, 3 Nov 2020 09:18:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20201102172330.GB2749502@xps15> X-Originating-IP: [10.65.95.32] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_201840_450147_F9146A83 X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Al.Grant@arm.com, suzuki.poulose@arm.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On 2020/11/3 1:23, Mathieu Poirier wrote: > Hi Liu, > > On Sat, Oct 31, 2020 at 06:12:30PM +0800, Qi Liu wrote: >> As driver.owner has been set in platform_driver_register(), it is >> unnecessary to set it in static funnel driver, so remove it from >> struct static_funnel_driver. >> >> Signed-off-by: Qi Liu >> --- >> drivers/hwtracing/coresight/coresight-funnel.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c >> index af40814..07bc203 100644 >> --- a/drivers/hwtracing/coresight/coresight-funnel.c >> +++ b/drivers/hwtracing/coresight/coresight-funnel.c >> @@ -356,7 +356,6 @@ static struct platform_driver static_funnel_driver = { >> .remove = static_funnel_remove, >> .driver = { >> .name = "coresight-static-funnel", >> - .owner = THIS_MODULE, > I received two identical patches (with a different title) from you. Since there > was no explanation I will discard the first one and work with this one. > > You are correct, platform_driver_register() does take care of THIS_MODULE. > Please send another revision where you will do three things: > > 1) CC the coresight mailing list, as instructed by get_maintainer.pl > 1) Also fix the replicator driver. > 2) Add a comment that clearly mentions THIS_MODULE doesn't need to be set: > > .name = "coresight-static-funnel", > /* THIS_MODULE is taken care of by platform_driver_register() */ > .of_match_table = static_funnel_match, > .acpi_match_table = ACPI_PTR(static_funnel_ids), > .pm = &funnel_dev_pm_ops, > > Thanks, > Mathieu Thanks for your review , I'll send a new patch latter. Liu >> -- >> 2.8.1 >> > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel