From: Robin Murphy <robin.murphy@arm.com>
To: Miles Chen <miles.chen@mediatek.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>
Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, wsd_upstream@mediatek.com
Subject: Re: [PATCH] arm64: mm: make CONFIG_ZONE_DMA32 configurable
Date: Tue, 28 May 2019 11:43:11 +0100 [thread overview]
Message-ID: <814b9bd0-38de-4b8d-92b3-d663931d90bf@arm.com> (raw)
In-Reply-To: <1558973315-19655-1-git-send-email-miles.chen@mediatek.com>
On 27/05/2019 17:08, Miles Chen wrote:
> This change makes CONFIG_ZONE_DMA32 defuly y and allows users
> to overwrite it.
>
> For the SoCs that do not need CONFIG_ZONE_DMA32, this is the
> first step to manage all available memory by a single
> zone(normal zone) to reduce the overhead of multiple zones.
>
> The change also fixes a build error when CONFIG_NUMA=y and
> CONFIG_ZONE_DMA32=n.
>
> arch/arm64/mm/init.c:195:17: error: use of undeclared identifier 'ZONE_DMA32'
> max_zone_pfns[ZONE_DMA32] = PFN_DOWN(max_zone_dma_phys());
>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> ---
> arch/arm64/Kconfig | 3 ++-
> arch/arm64/mm/init.c | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 76f6e4765f49..9d20a736d1d1 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -260,7 +260,8 @@ config GENERIC_CALIBRATE_DELAY
> def_bool y
>
> config ZONE_DMA32
> - def_bool y
> + bool "Support DMA32 zone"
This probably warrants an "if EMBEDDED" or "if EXPERT", since turning it
off produces a kernel which won't work at all on certain systems (I've
played around with this before...)
> + default y
>
> config HAVE_GENERIC_GUP
> def_bool y
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index d2adffb81b5d..96829ce21f99 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -191,8 +191,10 @@ static void __init zone_sizes_init(unsigned long min, unsigned long max)
> {
> unsigned long max_zone_pfns[MAX_NR_ZONES] = {0};
>
> +#ifdef CONFIG_ZONE_DMA32
> if (IS_ENABLED(CONFIG_ZONE_DMA32))
There's no point keeping the IS_ENABLED() check when it's entirely
redundant with the #ifdefs.
Robin.
> max_zone_pfns[ZONE_DMA32] = PFN_DOWN(max_zone_dma_phys());
> +#endif
> max_zone_pfns[ZONE_NORMAL] = max;
>
> free_area_init_nodes(max_zone_pfns);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-28 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 16:08 [PATCH] arm64: mm: make CONFIG_ZONE_DMA32 configurable Miles Chen
2019-05-28 10:43 ` Robin Murphy [this message]
2019-05-28 15:46 ` Miles Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=814b9bd0-38de-4b8d-92b3-d663931d90bf@arm.com \
--to=robin.murphy@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=miles.chen@mediatek.com \
--cc=will.deacon@arm.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox