Re: [PATCH v0 00/10] i.MX8MP HDMI support

Tim Harvey
2022-04-06T16:13:18Z

On Wed, Apr 6, 2022 at 9:01 AM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> Hi all,
>
> this adds support for the HDMI output pipeline on the i.MX8MP.
> It currently depends on the i.MX8MP HDMI power domain series [1]
> and support for the new LCDIF [2] in the i.MX8MP. I guess the
> implementation presented here also still has some warts that
> require fixing and the individual patches most likely need to go
> through different maintainer trees, so I don't expect this series
> to be applied right away.
>
> However this complete series should allow people to test it more
> easily and provide feedback on the implementation with the full
> picture available.
>
> Compared to downstream this implementation actually allows to
> power down the separate HDMI PHY power domain when the display
> is inactive or no HDMI cable is connected.
>
> Regards,
> Lucas
>
> [1] https://lore.kernel.org/all/20220406153402.1265474-1-l.stach@pengutronix.de/
> [2] https://lore.kernel.org/all/20220322142853.125880-1-marex@denx.de/
>
> Lucas Stach (10):
> drm/bridge: dw-hdmi: add low-active PHY reset
> dt-bindings: display: imx: add binding for i.MX8MP HDMI TX
> drm/imx: add bridge wrapper driver for i.MX8MP DWC HDMI
> dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI
> drm/imx: add driver for HDMI TX Parallel Video Interface
> dt-bindings: phy: add binding for the i.MX8MP HDMI PHY
> phy: freescale: add Samsung HDMI PHY
> arm64: dts: imx8mp: add HDMI irqsteer
> arm64: dts: imx8mp: add HDMI display pipeline
> arm64: dts: imx8mp-evk: enable HDMI
>
> .../display/imx/fsl,imx8mp-hdmi-pvi.yaml | 83 ++
> .../bindings/display/imx/fsl,imx8mp-hdmi.yaml | 72 ++
> .../bindings/phy/fsl,imx8mp-hdmi-phy.yaml | 62 +
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 19 +
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 93 ++
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +
> drivers/gpu/drm/imx/Kconfig | 1 +
> drivers/gpu/drm/imx/Makefile | 2 +
> drivers/gpu/drm/imx/bridge/Kconfig | 18 +
> drivers/gpu/drm/imx/bridge/Makefile | 4 +
> drivers/gpu/drm/imx/bridge/imx-hdmi-pvi.c | 209 +++
> drivers/gpu/drm/imx/bridge/imx-hdmi.c | 128 ++
> drivers/phy/freescale/Kconfig | 7 +
> drivers/phy/freescale/Makefile | 1 +
> drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 1145 +++++++++++++++++
> include/drm/bridge/dw_hdmi.h | 1 +
> 16 files changed, 1852 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi.yaml
> create mode 100644 Documentation/devicetree/bindings/phy/fsl,imx8mp-hdmi-phy.yaml
> create mode 100644 drivers/gpu/drm/imx/bridge/Kconfig
> create mode 100644 drivers/gpu/drm/imx/bridge/Makefile
> create mode 100644 drivers/gpu/drm/imx/bridge/imx-hdmi-pvi.c
> create mode 100644 drivers/gpu/drm/imx/bridge/imx-hdmi.c
> create mode 100644 drivers/phy/freescale/phy-fsl-samsung-hdmi.c
>
> --
> 2.30.2
>

Lucas,

Thanks for consolidating this - It's been difficult to try to merge
these for testing.

I still have not been able to apply these to origin/master or
imx/master - what are you basing off of here?

Best Regards,

Tim
I