From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91723C433EF for ; Sun, 3 Apr 2022 15:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=niGJhrbFPsp4knF94nAqospjH9fUi4L6gF6t4ItUb4g=; b=UpiDgf+CcMwemu 9Y+nP6vxIh7OPZmO2DbPL+CXXOsHCRKzbsRfxbTE/o7OrKEeifptBbqgJEb0yRW0DlfijH7omjQk5 mfisrSgUDyhBdObDezpAjnoF63/PVQRhlr4ocff8M1WVT2n30fbaFUk+XWqkeg1ORpYEr3bTZy3Rg gHMeF/o23enNBj0g8+KDJi089r3CKuaIOlvI3aXRyXaVOvVS3N4aYp3E0kFR8218IqEcRs+lFmJm1 JUR8Npd8TU0dJKDwFiXcNV7bG9T5QDDsKRKoN3S8kc8bBUWkLpkbbSbPC3PyVN2f+OeIZsxpRB/hf dZ/t0iCHgV3Q3MeOtQ7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nb2IU-00BiPh-6W; Sun, 03 Apr 2022 15:37:46 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nb2IQ-00BiMu-F2 for linux-arm-kernel@lists.infradead.org; Sun, 03 Apr 2022 15:37:44 +0000 Received: by mail-wr1-x435.google.com with SMTP id u3so10979808wrg.3 for ; Sun, 03 Apr 2022 08:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=eDFMs7EElGjgVXSi1G28DbTYKExJESQOSQxzUR+xKqM=; b=lnbGEtlamweYbPt09LLUZZmY1OEhSHyThX/GrCcNl6El493Cx8SaCgtQqMkE17prcX J4LfZqyU7meN7ZKBqPiiaqhEz48OQnHqLhAsz6amdsKGeWKgN2kgs5yDi1GqwrBu1PqX Gbm4GlMU9jc9lgq2KPbfHuzHqtBonIWl+PqeIdB1b5Cpz4H5t624nAEKk4q2tOus8EbX ze51geAwftRiFo4VVmbrccFnbRQ7WwQvc/jJ302DDtrGiVE1dmAAG1WFhfGrfBVVPuXt MzsCJc8qaT8+5p98TbBnT842jG/MYim7LYqY2m7SIu/Lrq4rx6om8VKeS5BRzJaTTgMA j12g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=eDFMs7EElGjgVXSi1G28DbTYKExJESQOSQxzUR+xKqM=; b=Bsyx2Ziqki0fFDl+71VhDMZDaeQS0ddd8SveBo89ZfHspsJ+XvohF82zhtwkok5mgz reHslFXm8scLLhkY/91T8g53KRVXOTqXtlXJc2RgcesO23soLy2hMjLYM+oU9seaoxAd mg94I20BDV0sKPurlNzDdeEnPD+kA/uYsP/8iBewpc5bLkcU1GpxZQRoT0m8oilHmlyj m4MJL0hucfBYrhsewhV2H3ZPfSIV87IQhJJArY/bUZTB8yay749/blgky7nT8vvgRmO5 UFQdb1xVR0qHKzlqrafuvEW7aqNCSgiJzXLt/mBiTikWTHvS8jd8rWgRx7QVvz2u40HC YITQ== X-Gm-Message-State: AOAM532b6Scx2C7srAvX79upyjgNrXm4RjrOwodfhUsZWVm4qBpRijQS BVACO6UQoKkpmV7auI4TDGhU4Q== X-Google-Smtp-Source: ABdhPJzno6MvWVjCp8ZyExCrnTXODZzrLF1ozU8hgn7hmy1XaDLiOBxe1FQc2Cu1D2oZQReX5TZNZw== X-Received: by 2002:a5d:47c3:0:b0:204:5b8:225c with SMTP id o3-20020a5d47c3000000b0020405b8225cmr14059127wrc.474.1649000259960; Sun, 03 Apr 2022 08:37:39 -0700 (PDT) Received: from [192.168.0.172] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id m63-20020a1c2642000000b0038e5fa06b50sm4607976wmm.31.2022.04.03.08.37.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Apr 2022 08:37:39 -0700 (PDT) Message-ID: <817dda10-39db-adfc-376d-a3d5e037937e@linaro.org> Date: Sun, 3 Apr 2022 17:37:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/4] dt-bindings: spi: add binding doc for spi-mtk-snfi Content-Language: en-US To: Chuanhong Guo , linux-spi@lists.infradead.org Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Roger Quadros , Thomas Bogendoerfer , Cai Huoqing , Florian Fainelli , Colin Ian King , Wolfram Sang , Paul Cercueil , Pratyush Yadav , Yu Kuai , "open list:SPI SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list , "open list:NAND FLASH SUBSYSTEM" References: <20220403131154.1267887-1-gch981213@gmail.com> <20220403131154.1267887-4-gch981213@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220403131154.1267887-4-gch981213@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220403_083742_566722_2C698363 X-CRM114-Status: GOOD ( 20.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/04/2022 15:11, Chuanhong Guo wrote: > Add device-tree binding documentation for Mediatek SPI-NAND Flash > Interface. Thank you for your patch. There is something to discuss/improve. > > Signed-off-by: Chuanhong Guo > --- > .../bindings/spi/mediatek,spi-mtk-snfi.yaml | 87 +++++++++++++++++++ > 1 file changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > new file mode 100644 > index 000000000000..166c6b50b9d1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/mediatek,spi-mtk-snfi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SPI-NAND flash controller for MediaTek ARM SoCs > + > +maintainers: > + - Chuanhong Guo > + > +description: | > + The Mediatek SPI-NAND flash controller is an extended version of > + the Mediatek NAND flash controller. It can perform standard SPI > + instructions with one continuous write and one read for up-to 0xa0 > + bytes. It also supports typical SPI-NAND page cache operations > + in single, dual or quad IO mode with piplined ECC encoding/decoding > + using the accompanying ECC engine. There should be only one spi > + slave device following generic spi bindings. > + > +allOf: > + - $ref: /schemas/spi/spi-controller.yaml# > + > +properties: > + compatible: > + enum: > + - mediatek,mt7622-snand > + - mediatek,mt7629-snand One blank line, please. > + reg: > + items: > + - description: core registers > + > + interrupts: > + items: > + - description: NFI interrupt > + > + clocks: > + items: > + - description: clock used for the controller > + - description: clock used for the SPI bus > + > + clock-names: > + items: > + - const: nfi_clk > + - const: pad_clk > + > + ecc-engine: The nand-chip.yaml defines a nand-ecc-engine, so how about using that one? I know mtk-nand.txt uses ecc-engine, but for new schema better to use properties from existing YAML. > + description: device-tree node of the accompanying ECC engine. > + $ref: /schemas/types.yaml#/definitions/phandle > + Rest looks good, thank you! Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel