From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E4C2C433E1 for ; Sat, 22 Aug 2020 20:23:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 473202078A for ; Sat, 22 Aug 2020 20:23:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N6wI3Voo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="buUI7cTE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 473202078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HnrrpVxv0HBHpJf1lQpRwINAsOH8JiXA4/Ba6QlNRlQ=; b=N6wI3VooaUYs5YJO80WVYfwGV Eoe+sRSd2swZFwSotdNnCE6xvZ/HHGPc9cIC1emVUKRbC66DxtSIVm5en5VHYE9CdvHe2usKo/y0B GbXGyoTnt34ZNCT1C8UVl0rt86hiyF4cnOHfhWenQqZaFbHueS4aLydS5DRYPMoCo32dc5O5V+a9/ 7PP2E6ZUGeHZ3mR+sveEvtYBvDXTpP7I9tT4HjP0pWgW2IWO1fQEAuGJREA9hZHC0AfcMFhpgJy/k jPAFekav3elUVMDF31l5Q1GrfQp0GgY7VoKO3/8ar74eXaxkVRB8blsbJrhVOsPMLRgsCVDb/iJ0R mESwk13hg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9a1U-0000pX-Pt; Sat, 22 Aug 2020 20:21:56 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9a1S-0000ox-1e for linux-arm-kernel@lists.infradead.org; Sat, 22 Aug 2020 20:21:54 +0000 Received: by mail-pj1-x1044.google.com with SMTP id 2so2287205pjx.5 for ; Sat, 22 Aug 2020 13:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mN1iKDEyC3rA1Z74FeKTAwvaB/0bfpLiv8xA+/THcfE=; b=buUI7cTEXw0CqhjGusziy1qvMeUQnMbxSuk9u8oBhEVXDy2JpbTGHiz09OghHAtnfb MjyORiYBD8o3ITVKf0Wq0sN+HZZ0cc/wVawGT/LaMwH/62+zKuIwgZwStWoYDZxNCRm5 vHxZWuuZZaPPUeIx90594xZARn15u1VfZAyc9VjVI4yI8VtqGIWTc9wgvWDM9aeKIth0 vy1gt+NOUgcLOQ7iJco/fte1JhcP7QWZ7vdq+pTfzXC07SGTMj6duIVa5QC9Qx+BRXDg yjImBPiGxVO6589k8xFsVZ6349XQ3noBvELpS4OJ9stZgM1q+Poqc50FOOSIH5H3wRiw YsIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mN1iKDEyC3rA1Z74FeKTAwvaB/0bfpLiv8xA+/THcfE=; b=Tb2mDW7XdEB2/NInj2bD8xOlp38bBXSqPF0myo4nNr0YlNl/UJ++APwaC6HJrPQ2Xb OXb6uk+SK3MxYyxt+3X4xLJFNGAYre4MnOQzWjMOfq5XaVPntV1dQhogk3eSRq/J6ErI RQw1Kz78tmztVm/jCGrzatjvarTPq1wk2KrqyMRxRo9b97ODAPPaEEVAzBrCsOIzI+1/ ayRg+sJoDjEVFUgTALqSI1Yc2PUXlpd3qU3rYOF5zoRlj3xH+rJDh3tUx6olI+jFROI6 t5rLOB8zY0Leovi25QhKNsWslGgAD8DzKimRCRKnpiqmjtEhQSR6rJaYX469cBMY51Dg RGPQ== X-Gm-Message-State: AOAM5336NX/YGsYClz5RF5SSvt8EbINkEMkkIlOXez/EASXw2F063KkN SIigvNH9+QLh3CPnIO42vk8= X-Google-Smtp-Source: ABdhPJx8s/fRLcufDR11rS5meEUVanLoMvXI2iSut+yYBf8owMaDOrQ572+qGTM9anFMUNePTv3MUw== X-Received: by 2002:a17:90a:a4ca:: with SMTP id l10mr5606289pjw.207.1598127710231; Sat, 22 Aug 2020 13:21:50 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id a2sm6591393pfh.152.2020.08.22.13.21.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Aug 2020 13:21:48 -0700 (PDT) Subject: Re: [PATCH v2] memory: brcmstb_dpfe: fix array index out of bounds To: Markus Mayer , Krzysztof Kozlowski References: <20200821165221.32267-1-mmayer@broadcom.com> <20200822115636.GA19975@kozik-lap> <20200822164619.GA24669@kozik-lap> From: Florian Fainelli Message-ID: <81b2ad54-d4ef-cf98-886c-61c79e4cac62@gmail.com> Date: Sat, 22 Aug 2020 13:21:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200822_162154_130497_0ABD9598 X-CRM114-Status: GOOD ( 21.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Colin Ian King , Florian Fainelli , BCM Kernel Feedback , Linux Kernel , Linux ARM Kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/22/2020 1:14 PM, Markus Mayer wrote: > On Sat, 22 Aug 2020 at 09:46, Krzysztof Kozlowski wrote: >> >> On Sat, Aug 22, 2020 at 09:40:59AM -0700, Markus Mayer wrote: >>> On Sat, 22 Aug 2020 at 04:56, Krzysztof Kozlowski wrote: >>>> >>>> On Fri, Aug 21, 2020 at 09:52:21AM -0700, Markus Mayer wrote: >>>>> We would overrun the error_text array if we hit a TIMEOUT condition, >>>>> because we were using the error code "ETIMEDOUT" (which is 110) as an >>>>> array index. >>>>> >>>>> We fix the problem by correcting the array index and by providing a >>>>> function to retrieve error messages rather than accessing the array >>>>> directly. The function includes a bounds check that prevents the array >>>>> from being overrun. >>>>> >>>>> This patch was prepared in response to >>>>> https://lkml.org/lkml/2020/8/18/505. >>>>> >>>>> Signed-off-by: Markus Mayer >>>> >>>> Your Signed-off-by does not match From field. Please run >>>> scripts/checkpatch on every patch you send. >>>> >>>> I fixed it up, assuming markus.mayer@broadcom.com is the valid email >>>> address. >>> >>> No. I have always been using mmayer@broadcom.com since it is shorter. >>> That's also what's in the MAINTAINERS file. Please change it back. I >>> accidentally used the long form for one of my e-mail replies which is >>> where the confusion must have originated. >> >> I'll drop the patch then. You need to resend with SoB matching email. > > Oh, I am starting to see what's happening here. This is new and > apparently due to some changes with the mail server setup on our end. > > I have this in my patch file: > > $ head 0001-memory-brcmstb_dpfe-fix-array-index-out-of-bounds.patch > From 6b424772d4c84fa56474b2522d0d3ed6b2b2b360 Mon Sep 17 00:00:00 2001 > From: Markus Mayer > Date: Fri, 21 Aug 2020 08:56:52 -0700 > > Sending patches like this used to work. Clearly our SMTP server has > now taken it upon itself to rewrite the sender e-mail address. I > wasn't expecting that. Let me look into it. Sorry for the hassle. It > was not intentional. Yes, if you used to use the SMTP relay server which did not require authentication for internal hosts, and now you use smtp.gmail.com with your broadcom.com username, the SMTP server will rewrite the From: to match the username used to authenticate with the server. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel