From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28DABC77B70 for ; Mon, 17 Apr 2023 08:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:From: References:CC:To:Subject:Date:Message-ID:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=QFHk3makBRsfObyS0bCZ5QTuet1zaCGyFK7tzzMx8so=; b=Ea7uNBNcjq5iJ9Tr03uL0baG7D KE2YIPnjuCEi9HNhGmBblgNfu0S5nXyB4IahQlGG/LYooHz8a3HwNSPOo1g6Rn3O/V2TiybmNu0qb MDaxvOQixwwwuiVyT8JBSfJI2xJfxwbri83mjqbGMI1VLfvOQ3+TUXYifacsJdCPRUwsU2tuSTK94 iTufErzStOioSBHXRrNanUZV/ndNzBXIHny7ZVy7aJX7scN7dukOoNCUw9u1rrju4ffDY36LbPzAv P9GliPIfPo6ozCCPYeQIcBp2WlUUhUqczGV8+fC0xdxIg5ByV+fA4G5EMsE8Rt4Vb2tcmhy6id+nG GeCvKCrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1poKYr-00FQRX-1J; Mon, 17 Apr 2023 08:50:09 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1poKYo-00FQQk-2U for linux-arm-kernel@lists.infradead.org; Mon, 17 Apr 2023 08:50:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681721406; x=1713257406; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=I00/n0vPRQWrG2BxV3A6OI3J2APOMroOD/UdeaJOvcc=; b=kHYk2wDMN4FAivL8Otc6F3yAMVA9XkdX+h4hyEcZ39surusT0ImCF7iY X1mCE+NdXLhmxiVz8PVLEjSOFvQpQ3XyMnGQOHG3pX7NLAw+HnfXjl7ca rPiVlF0l75/g1zIb61y1x6QRjuPTbB2v8+b8TXPkan1ba4ZwP6BwBASok K3PfBzNEXjpPqaysuBS+F7uEu8BtLbDvoYJOyPM+BQMQ1pb+gIkaYDaOp ZZGNW/8Xv5QwbhFEANGSi7SnUJThI5dYzIaojE7TsDNauRvcpB+0SB4B+ euGLXDhtvhExFXZx0TP0rOynhgz0M+D10RcwWdX/MiAbqCl+o/gTkKYfb g==; X-IronPort-AV: E=McAfee;i="6600,9927,10682"; a="329007344" X-IronPort-AV: E=Sophos;i="5.99,203,1677571200"; d="scan'208";a="329007344" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2023 01:50:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10682"; a="668035811" X-IronPort-AV: E=Sophos;i="5.99,203,1677571200"; d="scan'208";a="668035811" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 17 Apr 2023 01:50:03 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 17 Apr 2023 01:50:02 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 17 Apr 2023 01:50:02 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 17 Apr 2023 01:50:02 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 17 Apr 2023 01:50:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lhwBZQ1ZTHXMBXsIFFQCumBy0d1aG61mNrRHKXMSallnPE2dubs8Gd+eIho9Rw7TVaCDdMPOKZslcbiMEYXK/72ZJ3vP6yYuYsXKNtnz3/0v2h1JrHOX147dhEnsPIoPbjYiiuzdzzowJJ89i5I+Wp7c0WBkHhqm4bGP/UvbYFXUmfTSeTz+jD45ikv62p8URZBsRCLf/ktGKVwDaTAJZyf+4wahjT+WU9WjAQsvWV83r6BDnkgtbUbjEoPATGG6cqTqLrjf24HWCIScGMP1HL2fbIkWGHyetuz0Dw4+R/WAlVdhaufe2otev/w56l+u8c+YBI2afWMRrkBsAWmuGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3/kHQ3T5P4qiVzDWBJ/m0RsvetrRajSVjT8oA/g15Jc=; b=gOhrDyWZpIdEQ40yMAAdLqoPgrhb1p4yIQ5CgkIxnhKb+JztLbzEnbQhYhBWVY/jX7NO3NSOh+zoQ0YNpChceWBQdmcWNjraNgr4AlbZ5DLw8QM0zoiTwd0GaLp3VClYOnt42h868cDG7TcTtgUT22ZSXkKcCVOufxH1S64cx6WnXf5xFG9p2ZwLaw6vRfAuuVLe5BT015GbsBMh4KkOeNMcT1fV8aknCM/8wQlT2tGNufp2TiDz1F1utr0jKfqrL9WrLSYLRyJtQDoH3Q4Cdmqbb8f7H0R14CjMESu0Mn2n5Qf5ndxt/y1giCM7TpUiKj5PEuwXxqkIIYqrp34wGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by CH0PR11MB5492.namprd11.prod.outlook.com (2603:10b6:610:d7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Mon, 17 Apr 2023 08:49:55 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::f670:cacc:d75f:fcc4]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::f670:cacc:d75f:fcc4%7]) with mapi id 15.20.6298.045; Mon, 17 Apr 2023 08:49:55 +0000 Message-ID: <81f160ab-e66f-83f4-ad08-352454690119@intel.com> Date: Mon, 17 Apr 2023 16:49:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.10.0 Subject: Re: [RFC v2 PATCH 03/17] mm: Introduce try_vma_alloc_movable_folio() Content-Language: en-US To: Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , Yu Zhao CC: , References: <20230414130303.2345383-1-ryan.roberts@arm.com> <20230414130303.2345383-4-ryan.roberts@arm.com> From: "Yin, Fengwei" In-Reply-To: <20230414130303.2345383-4-ryan.roberts@arm.com> X-ClientProxiedBy: SGBP274CA0012.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::24) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|CH0PR11MB5492:EE_ X-MS-Office365-Filtering-Correlation-Id: d86ebe04-cd4f-4769-19d0-08db3f20b754 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hjTTqzwhP/SpAYp4aBhMqdGZcMcAs3sWrVUXLmrc84Q9qS0RSDe3GanNnJCWUbujuEAWXUxkarNx3NVE72LGHZRTUCteqzoF1OaqzC7I4N71woiqnDYHwGbIIrBL6ZgQjWn4HVEbSW9tp0UZ3MB1fRav9v+JgzsDf77YVRIOSTUSg5IETdWM7J/qxk63BGw4RqiJArJ6aopSARtK366Wf10NX8pEGZ0XhI1S9wcCTGWH+QR2o28QMNIbVD4bl4hHHLR1E8YPp3qhKbYHfZmkWDzIhmcyKqAG4pSj7DSGEVYQ4hZmPya1/Musljkqv6l3M+b9Gi1pwOTNTxjcAK4DPGCWjtcMHTsW9VGET2mTlIin1yj9LrMVNVuDGXIm857elLtX91gQISxx2oAR+mwXmjLfgmOyIgcii5Mak1zef6nMv++cJGrbl1Qecy/g7wbWwr3vIVp41tZ4ScpWf7vEY8pXdJL2Yn7wbYbNckt+sh0IR3hPuYnAII9zyUcHlH+eoDJ9mWURAsRwOww6lKlO7K6Ku9S/E8OsXTCoZwrM6fsDhNpHsDcIstGlfUSCGMN3+AUsbsftxHmbXMd+vdoPgi739gf65jW8X7CqHYnao+DCQdSR2lRXzsJF1iwA1ADnlJ5zwYZjAUSGttuOrdZSGg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(5660300002)(6486002)(66476007)(66556008)(2906002)(4326008)(66946007)(36756003)(86362001)(8936002)(38100700002)(41300700001)(478600001)(6666004)(82960400001)(8676002)(316002)(31696002)(110136005)(6506007)(6512007)(26005)(31686004)(53546011)(2616005)(66899021)(186003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmIzWk5vL3dvUzZIZG94ZFVid2JPZ3pzSnViNnYxSmF4ZXBBbVU2VktXNmtZ?= =?utf-8?B?TkVueGN6YjhCSi9CekpFUjV4Z3BvcDlwOTdmN2RwanVIcEppSVEzTFdSVGl0?= =?utf-8?B?dUhZdmdDZ043TDc0cDRROXpvMkYvbjV0Q0lVNG56QVZyZU9aVGlNb3IzUDZu?= =?utf-8?B?RXRUNmlBVWJXMGw0aDhDVHhUa1kvYXNnR00zbk1VQmdIYmNlWTI0Rm5QMCtt?= =?utf-8?B?TnJ0emxZZE5NYUU4NHh5TldzbHkycTFobWpTKzdISzhNL1l4T3UwRnRyRER1?= =?utf-8?B?VHpUaFZ2aG5oMVFvN2RMVVBmM1BVQ2ZQR2RGem9sSXpmL1lMN0ZpWktOM2Rr?= =?utf-8?B?cGgzSUI2OEJNQ1BHL0ZBajFUTWdMMTlFd2ZqbTR4L2doSWorbUg5blRRdHdm?= =?utf-8?B?cFdRdWxxcXpiUjNDTndiaWphNTdqR01TLzMycTF5d3ZxNnRvTlJVbmNtT0xV?= =?utf-8?B?bkNJVS9XZlozN3FJQjVYdjNGUXZ3NjZmR1hIeG1EREtLWU83UUpaS3oxNG41?= =?utf-8?B?S2FlVVlaK1U5eWNMNjZ6bTNCSTBOYUsxTDl3V1BQbEIzcjNQRmFyeVoyZWYw?= =?utf-8?B?Yk9FU0YySnJzOWh3NWlzd29TRWFCc1ZNRit1emdFMUREZGJHR3g5Q21BNFE2?= =?utf-8?B?TENaM1lLbVl5dXBsemJkM3VzZXgzT2RYdDZ6aHUzS0huR2Q0RTZTNi9tSW05?= =?utf-8?B?WC9zbHlBM3pQakZiL3N5aW9iUnVWb1FMTUdCV2MvR0U1S0Nha2RGUFExcWFC?= =?utf-8?B?WDA4WTcwTVQyUk1DZmgxeUJJUGVTSGxhb2luQmhJUitjNkJkK2h4WGtrTFpr?= =?utf-8?B?Yks4YkQ2bE9GNFhMQ214RGc2Mjg3QWNncnM4VVZxYVF1U1ZqNHZzdUdoOEJ3?= =?utf-8?B?YWlvVmRITnJuRUI2aXBRTEw4Sy93VDczZEpUOEM5enBHOU9taXcvVHFGYUh4?= =?utf-8?B?dmlJNS9SU3lPR1hTV2c5cWlvcWRFV0NacWhuUW5rRjlNbkhIVFJFdXNIODlw?= =?utf-8?B?L1VkRkhiUWoxVXpmbjQ5dzdlQ2NFYTRxc0hBUFo2Vi8rd3JrSlR2UVN2eGhq?= =?utf-8?B?bzdLUW5Md1dCWUpTWVJHNVV4UWV5cjBBcGFROXQ1M3hkM0lrS3dGUEVaZ1Bu?= =?utf-8?B?bHc1S29LTGtjUy9DN3I2TllHR1U0N29tNXFsRFJpTGZSUXcxV2plbXRDMGtP?= =?utf-8?B?K1JYWE1mSXNLd0J1Y1JmMGNSZkNOMU1vMm9hTWlZU1paNXdHcVZvYkdLbWRM?= =?utf-8?B?S2REZ3ozaVVJL0UzTzgwelBlTy9MclVxUEJlN2dPc1V3QllodGJsZjF5c0w4?= =?utf-8?B?eW5nWWZTcHEyWWtHSzdYL0l2OUd0bUd0a1NtQ094eDE0WWJrSWNpMDhCZSt1?= =?utf-8?B?RnlQUGw0b29xaThZVEhYbkZFdnV1Z0xGaFFrczM2ZUZvNVdHMlorVmNFZFhy?= =?utf-8?B?d1lFR0FDNDEvS2N0NytJYlplaXZlbEpEUytFS1ltYnREb1ExeExBcVR6RFJV?= =?utf-8?B?ZzdmOFU4d2NzNitFcHExRVFyRmNvSm1Fc2x0RXdEbGk4S2piYXlqNjk1OVox?= =?utf-8?B?ZDZvNWxpZ05YOVNqR1o3Um5DRUhodFhUdlladnptSCtOZW9yV1U5eE9WZysv?= =?utf-8?B?bUxONm1xZ2JaaHJ2dDRlQ3lxcnZOWURxU1JjRmdGcjM5Zlh1VU03TEtveGMx?= =?utf-8?B?S3o3bHRNcEd3aSsyQUZXeHY1VnBLNUNocDNYNjkxaXZkNVYwUXZaeFZ2WFJ5?= =?utf-8?B?UCt0NHUyeENGYXNKNWJRZTczT2VMUnpKQUE5TEplYVc3MkswaGdnUm1TZENj?= =?utf-8?B?T0FwY0lnN3V1dzJHNWMxVnQyby8zeUxkMmM5eEZzUHQybFYwb00vRkRoTmFL?= =?utf-8?B?N09lcjRvYVBsdm5mMXVCWWYxTXl2a0QySlB3RmRxcXJMOXI2UTloNUVVV1I0?= =?utf-8?B?VGkweFRJQmVZQjk0ZVNpYmppbmhyaFhEK29aMHp4empwVzF6YWtIQlJONXJI?= =?utf-8?B?dVlacmlTZkVNdnZkZmFEajAxOTlLRWhFbEJ4akpSTSt6cEVJdTNWTUZBbCtY?= =?utf-8?B?ZUZnWlVXVHpKU2N6WW1VMXBJWXBDUkxWTGdCVEVVL0piZXd4bHlrQWdvUVZ4?= =?utf-8?B?ODVscnJ6b2YycWRXY0hXaGxUeGd3YVB4Zmo5VWVjQTNDVm9oejMxS0JGQzVN?= =?utf-8?B?OHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: d86ebe04-cd4f-4769-19d0-08db3f20b754 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 08:49:55.3903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wo9kFN4Hec56OWJllx2yDVx/OWuhwohjr5wIgrSmdHa5uxdOV+w/LU60/V2wPpZuddQwTTBw+HR/XpYp6NmsvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5492 X-OriginatorOrg: intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230417_015006_884264_57AE743A X-CRM114-Status: GOOD ( 25.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/14/2023 9:02 PM, Ryan Roberts wrote: > Opportunistically attempt to allocate high-order folios in highmem, > optionally zeroed. Retry with lower orders all the way to order-0, until > success. Although, of note, order-1 allocations are skipped since a > large folio must be at least order-2 to work with the THP machinery. The > user must check what they got with folio_order(). > > This will be used to oportunistically allocate large folios for > anonymous memory with a sensible fallback under memory pressure. > > For attempts to allocate non-0 orders, we set __GFP_NORETRY to prevent > high latency due to reclaim, instead preferring to just try for a lower > order. The same approach is used by the readahead code when allocating > large folios. I am not sure whether anonymous page can share the same approach as page cache. The latency of new page cache is dominated by IO. So it may be not big deal to retry with different order some times. Retry too many times could bring latency for anonymous page allocation. Regards Yin, Fengwei > > Signed-off-by: Ryan Roberts > --- > mm/memory.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/mm/memory.c b/mm/memory.c > index 9d5e8be49f3b..ca32f59acef2 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -2989,6 +2989,39 @@ static vm_fault_t fault_dirty_shared_page(struct vm_fault *vmf) > return 0; > } > > +static inline struct folio *vma_alloc_movable_folio(struct vm_area_struct *vma, > + unsigned long vaddr, int order, bool zeroed) > +{ > + gfp_t gfp = order > 0 ? __GFP_NORETRY | __GFP_NOWARN : 0; > + > + if (zeroed) > + return vma_alloc_zeroed_movable_folio(vma, vaddr, gfp, order); > + else > + return vma_alloc_folio(GFP_HIGHUSER_MOVABLE | gfp, order, vma, > + vaddr, false); > +} > + > +/* > + * Opportunistically attempt to allocate high-order folios, retrying with lower > + * orders all the way to order-0, until success. order-1 allocations are skipped > + * since a folio must be at least order-2 to work with the THP machinery. The > + * user must check what they got with folio_order(). vaddr can be any virtual > + * address that will be mapped by the allocated folio. > + */ > +static struct folio *try_vma_alloc_movable_folio(struct vm_area_struct *vma, > + unsigned long vaddr, int order, bool zeroed) > +{ > + struct folio *folio; > + > + for (; order > 1; order--) { > + folio = vma_alloc_movable_folio(vma, vaddr, order, zeroed); > + if (folio) > + return folio; > + } > + > + return vma_alloc_movable_folio(vma, vaddr, 0, zeroed); > +} > + > /* > * Handle write page faults for pages that can be reused in the current vma > * > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel