From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38728C4338F for ; Fri, 30 Jul 2021 00:16:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0259F601FC for ; Fri, 30 Jul 2021 00:16:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0259F601FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4Zy5u3b6tBE2CAqZMvny4KLZmwHrYhYAFJo4NApHLNk=; b=iTntIv1JE39PV1zr2MSVZTvWHX bOX2uzGAGsgyrETrWySy9e7kLLAvFbs/rOI8Lf9Eby80FOIMMABBo62us9nFYLL+F+p+Pp7gNM5vB 5Bj4F+sSH4TZaYMg4RYcUudU/w2SR2zgjvCQZ0DyQvvMiTXqw62pfNv2EQLDs/ACw15udy71RRXeH Zp8EJRdB1tyfOBwalZLU4LEcw1GQxLVTwyi/X48GN9rjTib3bT8vMf5lVUd3iU08+QvntEbVDNfwa s1W8sBkFSi3HVypM6z9l36Cjc4++fCKCBmjSTeGiACjDtzwLV4f27ay6DKR9gtl4djpabR0SP67/i fbPLhGHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9G7A-006Usa-Hx; Fri, 30 Jul 2021 00:11:00 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9G76-006Ury-Nl for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 00:10:57 +0000 Received: by mail-pl1-x633.google.com with SMTP id u2so651037plg.10 for ; Thu, 29 Jul 2021 17:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KvNrFVgss6eSO6kUoQ3VU0X35CeoRY7KVDc86f4fQm4=; b=kOZQR14Uy3g//5gbl3xlpGsDHTkZtnRt2eygeLvJGcHjKB5XzT7Ldokpq0NHg1qAFQ xrUuJh8cOjV96IFiAb3OEqVzDWXY9A9Iz4H+WomwEZv8pWvjbfnAGH/WBA0megaHfwAb FrZmi2FAWLjncp47tvP1GZz6eGYY3U0P/lCKl8QgOFdgFjhPely2k0UWryrc85QzoocQ nxpsUlu9rex7WQydEd8E2OP286Wjz5qgZt5sbHFjX6+q3MgLSpSZBwlrr445ZibTmdHB qMvuvtM3WGGw1NEYtucOdcPeFgMgOFEVG362GtLpgC47HKmy1NEok10Kr4JNtYkChDnx FZaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KvNrFVgss6eSO6kUoQ3VU0X35CeoRY7KVDc86f4fQm4=; b=N29oOZ62xjIarfQr3/4EsXMc5pqeFjW2/3TvIm0yfRfokv3vjs4/BWEEoANec2+1G6 Z2kRDq8j0/95/Uq2y4STmxmmcEReUXRVhI6I+BHfv6X24vC7e2ikK0aRZudP0WjDgKn3 fkflj1qxPIMN+tzOksHXttlrPzhxxCBq9oEBaQY1Q9dhDsIorS9g6mayN+rEvDQqZkv/ qYfKq9+Qlfr6+JKc9vAygTGVaiuV3V/tDj2jCGWulV7Wnkd0w5TVLBs3e2a/cxD/eg/N KWDoEBLaMIv8yGEgP7zCvPnttc8oIZ24g50DhRseCl4M4EJgF+sEFpHMxrI76MuS9iiH 3Gbg== X-Gm-Message-State: AOAM530aG1J4Nj3vGiXRj0dKlJReQzC3613f5dieMnvT/SVAiJpTCOIK bf+HJ9oK0Qd6zvOclsqLy0s= X-Google-Smtp-Source: ABdhPJwE/niSh5UdF+w0QQdfBSjFatj+JALFmIVOdTcLe3nO62DxPf2VNDgpH154QI9H1E+xrQvSqA== X-Received: by 2002:a65:42c3:: with SMTP id l3mr698563pgp.377.1627603855087; Thu, 29 Jul 2021 17:10:55 -0700 (PDT) Received: from [10.67.49.140] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id f15sm5154339pgv.92.2021.07.29.17.10.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 17:10:54 -0700 (PDT) Subject: Re: [RFC-PATCH] net: stmmac: Add KR port support. To: Daniel Walker , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Russell King Cc: Balamurugan Selvarajan , xe-linux-external@cisco.com, "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210729234443.1713722-1-danielwa@cisco.com> From: Florian Fainelli Message-ID: <81fca68f-e0c4-ce02-6b2b-e5c22a0c3152@gmail.com> Date: Thu, 29 Jul 2021 17:10:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729234443.1713722-1-danielwa@cisco.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_171056_845901_9FECB8D3 X-CRM114-Status: GOOD ( 15.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/29/21 4:44 PM, Daniel Walker wrote: > From: Balamurugan Selvarajan > > For KR port the mii interface is a chip-to-chip > interface without a mechanical connector. So PHY > inits are not applicable. In this case MAC is > configured to operate at forced speed(1000Mbps) > and full duplex. Modified driver to accommodate > PHY and NON-PHY mode. > > Cc: xe-linux-external@cisco.com > Signed-off-by: Balamurugan Selvarajan > Signed-off-by: Daniel Walker You are not adding KR support per-se, you are just hacking the driver so it is happy with an unspecified phy_interface_t value and assuming 1000Mbits/sec, this is not going to work. Just add KR/backplane properly or use a fixed-link property hardcoded for 1000Mbits/sec and be done with it with no hacking, which would be just way better than what is proposed here. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel