From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76E89C25B0F for ; Sun, 14 Aug 2022 22:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+/326DDNB6nKMp/oY3EPAXBfsCdn5aYoZclEBGmJCfE=; b=4b1vW64ZHmTG6n LAPXNYieIcKkNs2bf5zAXrX6fo/Dr6esBns24aWKzzdNlkV8yfY0tkHHQCT5pOO2/+5b8IQgwB+id t0MvHIqOSTn0Fc4N9jPGSuGXfB6boOU5TgxwPOOh3PhFsM2vUYLZDBnK98J/KIQm794pOgo5QQ6Iv sihSZbwd8I7wlNldSBkEGQG654R5NURwNTRWvZX8Co5D6QsbwFMna9OKrckTPhEAP7n7A3L9HVslw lsq7bw+pBmQutCZQX355/rxl0bdMuddwEgxNbaRynSxtV067EneT7B1m2MDWuNmAd+r48O65AaNsb PRpYaar2LYFT7m/zVgdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNLfy-009OcZ-Mu; Sun, 14 Aug 2022 22:01:42 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNLfv-009Oat-NZ; Sun, 14 Aug 2022 22:01:41 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5540D5C0039; Sun, 14 Aug 2022 18:01:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 14 Aug 2022 18:01:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=undef.tools; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1660514496; x= 1660600896; bh=/N3ZJwMAuJKQJaLlb+5nhdHUlf08GWvC6v41/Xejl+U=; b=x lK5hEAvRjyvkoTXfINnBahnjIYJHP+GfNL0MaIZxCfWpEegPDjesCrG4oETdCh2T JpxLIWJh11b28A0E3qpAcdHzp5ng8BlJsPNF9zg/LIAC3JuSBfZOcVBPdxN/ALSZ JQLHpTH7nHHG6pD5kQO45vqgHj7BlVTf9CBIjGOVP56qfEdkz9OyWJSSJYjtgrJP 67ZAi59dU4sJX8z9EKTAgvNnA5Q8VCVOx6Hy5WBJ/pRZ30bhAC1bJivfIbDy2BVh QIsZItddkgpeY3Tj1V14QZgl+qes/mwCek38q/9NHWhvB5x6fc7Ho1nyNRMYYO32 VjZnrH3yc1VSoXc2SCQxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1660514496; x= 1660600896; bh=/N3ZJwMAuJKQJaLlb+5nhdHUlf08GWvC6v41/Xejl+U=; b=J NQaUkm4Fe/AlZMS5GBleTwq4sC7yCbf0SqagIxbXqpe1CXbbEkk/WBfeDz8bIQVp x4SgQD/pjUnvd2X0V5959jefvXqSkU/kiUyCjDBNJcKSJzQWYDVqLms0dXmP2a/I PZqaqyMRW1fvFYSlkBuRxWU/h8uwECfcuwzUYPZj7VnKnsieSi+zjyratj3qBlsz axPRn8Fzj/kI5Hg1wzGRJ5vHvZiNWW6nrGqQRQnEHR2FgXKXy8B80nO7bCZnmZQR Msjys/sU5YDzi8TobV8WXB8jCNHFXHoxgbqf7foeIog1s/SqCwufY1EVQPP1hiPe gsiZMveKvFlTmRFFY1pWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehuddgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflrghr rhgrhhcuifhoshgsvghllhcuoehkvghrnhgvlhesuhhnuggvfhdrthhoohhlsheqnecugg ftrfgrthhtvghrnhepvedtgeffledtjeegkeevfeegieevgffhveeuteduleeileetffel hfduheevhffgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepkhgvrhhnvghlsehunhguvghfrdhtohholhhs X-ME-Proxy: Feedback-ID: id76147eb:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 14 Aug 2022 18:01:30 -0400 (EDT) Message-ID: <821647de-be45-557a-e1eb-2e70e186f2d8@undef.tools> Date: Mon, 15 Aug 2022 08:01:52 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs Content-Language: en-AU To: Peter Geis Cc: Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Linux Media Mailing List , "open list:ARM/Rockchip SoC..." , arm-mail-list , Linux Kernel Mailing List , phone-devel@vger.kernel.org, Ondrej Jirman References: <20220814040806.7523-1-kernel@undef.tools> From: Jarrah Gosbell In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220814_150140_027879_15E8E1F4 X-CRM114-Status: UNSURE ( 9.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/14/22 23:12, Peter Geis wrote: >> ret = rga_parse_dt(rga); >> - if (ret) >> + if (ret) { >> dev_err(&pdev->dev, "Unable to parse OF data\n"); > If this can return EPROBE_DEFER, shouldn't this be dev_err_probe > instead of dev_err? Looking into it that does make more sense. I suspect it wasn't done this way originally because dev_err_probe isn't used elsewhere in rga.c. I'll send a v2 with that change shortly. Thanks for the review. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel