From: Markus Elfring <Markus.Elfring@web.de>
To: "Chen Ni" <nichen@iscas.ac.cn>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Niklas Cassel" <cassel@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Uwe Kleine-König" <ukleinek@debian.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
Date: Sun, 6 Oct 2024 09:39:21 +0200 [thread overview]
Message-ID: <821a7417-4f2a-42ed-9616-88a0c145fa5d@web.de> (raw)
In-Reply-To: <20240918074401.2221146-1-nichen@iscas.ac.cn>
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message in case
call?
> of a failure.
Were any static source code analysis tools involved in the detection
of the presented change possibility?
By the way:
Such a patch can be generated also by the means of the semantic patch
language (Coccinelle software) for example.
Regards,
Markus
prev parent reply other threads:[~2024-10-06 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 7:44 [PATCH] PCI: dw-rockchip: Remove redundant dev_err() Chen Ni
2024-09-18 8:21 ` Heiko Stuebner
2024-09-24 14:21 ` Manivannan Sadhasivam
2024-10-06 7:39 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=821a7417-4f2a-42ed-9616-88a0c145fa5d@web.de \
--to=markus.elfring@web.de \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=heiko@sntech.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=nichen@iscas.ac.cn \
--cc=robh@kernel.org \
--cc=ukleinek@debian.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox