From: stepanm@codeaurora.org (stepanm at codeaurora.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] arm: msm: Add MSM IOMMU support.
Date: Tue, 10 Aug 2010 12:22:08 -0700 (PDT) [thread overview]
Message-ID: <821ba2d399d553ea5f0398ef7b94e464.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <1281418597.1954.106.camel@Joe-Laptop.home>
> On Mon, 2010-08-09 at 20:42 -0700, stepanm at codeaurora.org wrote:
> I believe the current uses of pr_err in this module
> are unnecessary or could be converted to pr_debug.
>
> I think __func__/line aren't particularly useful.
>
> I prefer log messages prefixed with the module name.
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> and I'd convert all the current pr_err to pr_debug
> and convert the printk(KERN_ERR to pr_err(
>
> cheers, Joe
Thanks. Fixed in v4, which will go up in a few minutes.
prev parent reply other threads:[~2010-08-10 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 2:27 [PATCH v3] arm: msm: Add MSM IOMMU support Stepan Moskovchenko
2010-08-10 3:08 ` Joe Perches
2010-08-10 3:42 ` stepanm at codeaurora.org
2010-08-10 5:36 ` Joe Perches
2010-08-10 19:22 ` stepanm at codeaurora.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=821ba2d399d553ea5f0398ef7b94e464.squirrel@www.codeaurora.org \
--to=stepanm@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).