From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AED2C433F5 for ; Mon, 7 Feb 2022 10:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Arkg1plNkdttDW6Bp8MUJsOmD0r31XfQWFoGb1C7HOk=; b=aDyu4erXDabckz 9JHcXmhOOeaWrTEPjF9PhAEdUsNEChy5uOZrksWvr9wslQVTx2EQ7TQbE/g8BOr97kCaYWFxS68Rr I4Ky0rxzAQMpjjMeeihgv18VgSP0ckWNgUWOiFEfO3xk09+Z3tRoBqHwpeeYt7/YEChwbGslIQIUy WDNVuOky/OGo27XJytSXeMrJI5h9cBa2ashYfAc7Vl12Wjdtil3yyR4ELJE9otsNOATGUBd+zcwl+ wg+jpKKvZS0R3AhFcZh5tAVlJhw2knltmxBu08+cI0UHRG5nnfcqwIXmWTW70UMSyvI3sP19WQSRp PcMzZKoqmF5kM9Tl6m8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nH1NA-009qJI-Hx; Mon, 07 Feb 2022 10:35:52 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nH1N6-009qIg-2A for linux-arm-kernel@lists.infradead.org; Mon, 07 Feb 2022 10:35:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1644230148; x=1675766148; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Xm+zj6goisuqCJN2ekKk7zV6UfCUht5ppayoqpY1lLo=; b=TOVul1DDBBd2MCO69CZRt9h9bxhT9NSeU7KwTzucRmAoX7fdycwZFXpJ Ydx+l7fsHgCbzZFhFRXEeubHEAnpltS06H5wfVMO0qFIfborHp1TSb0/g pCp8G6jdqAFE74nj8PcOHj3G/gHDUIN3yJAsUtSHmi5AbqxY+vC6MzUNH AdOgEh3uh5wYj6vBrupMlxIXqBTM++8tzy3jJWKkvoKAOL3OSSdI3MTkp XAIKPVfzWpTANld1GoS9qTknsmsnez2y1PniTjZgDcabZT28zTtmeLDX8 tLhkSq8LfcNsKARA8K2fagi/rhOpmPgWqUhnnl67sgNLXj4vP8jGu5GJY Q==; X-IronPort-AV: E=Sophos;i="5.88,349,1635199200"; d="scan'208";a="21929419" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 07 Feb 2022 11:35:46 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 07 Feb 2022 11:35:46 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 07 Feb 2022 11:35:46 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1644230146; x=1675766146; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Xm+zj6goisuqCJN2ekKk7zV6UfCUht5ppayoqpY1lLo=; b=MmbSuvaegsMgPBJuepzfmivdIWkhZRna2n4Sqnjr58yzD+JhcLGtv8Da ueAxG3BIZGHNXvzzAeTZ8QVH4WXn5cJjpjy4YUVIdQpwJ+uWgdAvzuXRh s77PdtYuDJcdZ1qXZ+fqflP+SaMJfDHTVIDIwhuCktlW7wc3Y3xIWIxDC Fw0JQLpC7FvCC7knWNrsuxtrI3Bb5WSWQVWMvN+LVuAKsrVnOEKEzE3+J zgtoZdUei70cHA+trHpDLVTPEElSCXbxSHoV7Zxh0tkhtKVdfT6LM9Mmn ykTNl0643snNyPSqBd0QTm4MUkqjQsMYkzRPi9LYGetXrcxWAf4S3DMpO A==; X-IronPort-AV: E=Sophos;i="5.88,349,1635199200"; d="scan'208";a="21929418" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 07 Feb 2022 11:35:46 +0100 Received: from steina-w.localnet (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id DFB01280065; Mon, 7 Feb 2022 11:35:45 +0100 (CET) From: Alexander Stein To: Laurent Pinchart Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rui Miguel Silva , Dorota Czaplejewicz , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: (EXT) Re: [PATCH 7/8] media: imx: utils: Add more Bayer formats Date: Mon, 07 Feb 2022 11:35:45 +0100 Message-ID: <822120126.0ifERbkFSE@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20220204121514.2762676-1-alexander.stein@ew.tq-group.com> <20220204121514.2762676-8-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220207_023548_544104_805DE84A X-CRM114-Status: GOOD ( 26.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, Am Samstag, 5. Februar 2022, 04:31:36 CET schrieb Laurent Pinchart: > Hi Alexander, > > Thank you for the patch. > > On Fri, Feb 04, 2022 at 01:15:13PM +0100, Alexander Stein wrote: > > Without this the ioctl VIDIOC_ENUM_FMT will not list the 10/12/14-Bit > > Bayer formats. This in return results in > > "v4l2-ctl --set-fmt-video pixelformat='RG10'" failing to set the > > pixelformat as it is not enumerated as supported format. > > > > Signed-off-by: Alexander Stein > > Do IPUv3-based SoCs support 10-, 12- and 14-bit formats ? If so, > > Reviewed-by: Laurent Pinchart I'm no expert regarding IPUv3. But according to i.MX6D/Q RM Rev4 apparently there is difference between Bayer format or "Generic data" (CSI0_SENS_DATA_FORMAT: b011). Data width is set independently in CSI0_DATA_WIDTH where 10-, 12- and 14-bit is supported (even the odd ones in bewteen). I don't know if I got the right place, but [1] seems to do the mapping for IPUv3 what imx7_csi_configure() is doing for CSI on imx7/8. The MEDIA_BUS_FMT_Sxxxx14_1X14 formats are not added to the list yet though, but that is a different matter. Unless someone objects I'm going forwards with this patch. Regards, Alexander [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/ drivers/gpu/ipu-v3/ipu-csi.c#n302 > > --- > > This adds the following formats to `v4l2-ctl --list-formats` > > [...] > > > > [18]: 'BG10' (10-bit Bayer BGBG/GRGR) > > [19]: 'GB10' (10-bit Bayer GBGB/RGRG) > > [20]: 'BA10' (10-bit Bayer GRGR/BGBG) > > [21]: 'RG10' (10-bit Bayer RGRG/GBGB) > > [22]: 'BG12' (12-bit Bayer BGBG/GRGR) > > [23]: 'GB12' (12-bit Bayer GBGB/RGRG) > > [24]: 'BA12' (12-bit Bayer GRGR/BGBG) > > [25]: 'RG12' (12-bit Bayer RGRG/GBGB) > > [26]: 'BG14' (14-bit Bayer BGBG/GRGR) > > [27]: 'GB14' (14-bit Bayer GBGB/RGRG) > > [28]: 'GR14' (14-bit Bayer GRGR/BGBG) > > [29]: 'RG14' (14-bit Bayer RGRG/GBGB) > > > > [...] > > > > drivers/staging/media/imx/imx-media-utils.c | 72 +++++++++++++++++++++ > > 1 file changed, 72 insertions(+) > > > > diff --git a/drivers/staging/media/imx/imx-media-utils.c > > b/drivers/staging/media/imx/imx-media-utils.c index > > e0a256a08c3b..ea56c82d3b32 100644 > > --- a/drivers/staging/media/imx/imx-media-utils.c > > +++ b/drivers/staging/media/imx/imx-media-utils.c > > @@ -130,6 +130,78 @@ static const struct imx_media_pixfmt pixel_formats[] > > = {> > > .cs = IPUV3_COLORSPACE_RGB, > > .bpp = 8, > > .bayer = true, > > > > + }, { > > + .fourcc = V4L2_PIX_FMT_SBGGR10, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SBGGR10_1X10), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 10, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SGBRG10, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGBRG10_1X10), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 10, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SGRBG10, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGRBG10_1X10), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 10, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SRGGB10, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SRGGB10_1X10), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 10, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SBGGR12, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SBGGR12_1X12), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 12, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SGBRG12, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGBRG12_1X12), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 12, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SGRBG12, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGRBG12_1X12), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 12, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SRGGB12, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SRGGB12_1X12), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 12, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SBGGR14, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SBGGR14_1X14), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 14, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SGBRG14, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGBRG14_1X14), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 14, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SGRBG14, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGRBG14_1X14), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 14, > > + .bayer = true, > > + }, { > > + .fourcc = V4L2_PIX_FMT_SRGGB14, > > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SRGGB14_1X14), > > + .cs = IPUV3_COLORSPACE_RGB, > > + .bpp = 14, > > + .bayer = true, > > > > }, { > > > > .fourcc = V4L2_PIX_FMT_SBGGR16, > > .codes = IMX_BUS_FMTS( _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel