From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A84FCC433F5 for ; Sat, 30 Apr 2022 14:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xVaVUCIy9lzeFdU6P9GCfd2YH3QtekiS8Z4LqhsppRc=; b=fiDnePr+MfcHBM +XR3OlNXGNQToQAssWyktK3UyIovJ6LZSgwJixeH/ju7mMg6I3ZolP2CR4hdVnHyb/iMN8lV7k2Q2 BrPhmFhCAXklgWn48R6wba8UZJY+OXG/4aLLjVtGzGzhFcGrNfVAl3TgtMJOoWvi0L0YpAwejYWeh 6VwecwQY7zx7gCh2P2CSb06CBsZjYjI+/KY57/rlboxzGtis2kWjUrr+DrWxdL6KllH9BEBdvgpDT Q5uOELlsSDhto8cfTd/xpM18ip9BjurqGZopZi8U+xgME8SQFdgo8yivQxeIFcT4cu4CKmu7fCZVq mqfYyO//mqC23RKzQuzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nknqH-00ET3Q-6z; Sat, 30 Apr 2022 14:13:01 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nknqC-00ET1O-JO; Sat, 30 Apr 2022 14:12:58 +0000 Received: from wf0416.dip.tu-dresden.de ([141.76.181.160] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nknq3-0001c8-6F; Sat, 30 Apr 2022 16:12:47 +0200 From: Heiko Stuebner To: Sebastian Reichel , Linus Walleij Cc: Rob Herring , Krzysztof Kozlowski , Bartosz Golaszewski , Adrian Hunter , Ulf Hansson , Philipp Zabel , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@lists.collabora.co.uk, Jianqun Xu , kernel@collabora.com Subject: Re: [PATCHv1 13/19] pinctrl/rockchip: add rk3588 support Date: Sat, 30 Apr 2022 16:12:46 +0200 Message-ID: <8226003.NyiUUSuA9g@phil> In-Reply-To: References: <20220422170920.401914-1-sebastian.reichel@collabora.com> <20220422170920.401914-14-sebastian.reichel@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220430_071256_683272_7B5F1EB3 X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Freitag, 29. April 2022, 00:55:52 CEST schrieb Linus Walleij: > On Fri, Apr 22, 2022 at 7:09 PM Sebastian Reichel > wrote: > > > From: Jianqun Xu > > > > Add pinctrl support for RK3588. > > > > Signed-off-by: Jianqun Xu > > [merged in downstream fixes, simplified register lookup logic for better > > maintanence at the cost of a bit more static const memory and fixed some > > incorrect registers] > > Signed-off-by: Sebastian Reichel > > Patch applied, unless Heiko does some loud protesting it stays > in the tree. I'm never loud ;-) Patch looked ok overall as well. I guess at some future point someone will need to refactor the small "if rk3588" but that can be done when another slightly different user appears and we have a feeling what the common approach could look like. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel