From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D8A6C6FD1F for ; Tue, 14 Mar 2023 20:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t4u8B+m/Z+cqZhPpennZ7tbPreyDw62HiEb84A0gXWc=; b=JlU9m0s73I119N x6aCIEx7cVs0src07A/FosvjmHPsPo8/8/FaKQkGG6r5K7r9yYjO0IR22XrkgJf2oSTZbgMv3TdMW NQsRu7MMDYD5bCDhOxN4z0F+tFX0LXdFf1alVemR1HbUMC7ZWdrsiLDKnimBM4D8fQpBDgWBizyO4 gvhGQLNRWXveErOvNhr3NHzYbwLqn+wZzhfpVOM6tHE2JECtvo2p7z9nte8abjC+KXpYIXoFx1U0l lHQvgznoTPU1tWenMShem9v3W16dz0Oz273oA9aMS6f3+B7KBg9iDaoYIAwkjZWj1ez9xI5mZGS9I MXIjfBemJiNvqA2O0M4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcB0U-00BRxI-1V; Tue, 14 Mar 2023 20:12:26 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcB0I-00BRtz-2g for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 20:12:18 +0000 Received: by mail-ed1-x52b.google.com with SMTP id cn21so36790030edb.0 for ; Tue, 14 Mar 2023 13:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678824731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KRAW+s3YRlQq9ELNdyAribiRoHUxDdhi6TfZn0sTs4U=; b=an/WrmIBb1xG0QZHI4bFzwDDiU4LoZagCTuDLCMZq4SGTA7QhTyJMXewtP/nJt3R5j Bp1+mwcGA7Dgs7dXcMNTz3mpqWNSPMyuLxuFrSqIPlQ1ypJ+jw6SDassBderY+eXdIio YlqOr44qiXSz9eVxW7HMw3tEaEWNCfnNIdr9h9dAzQZ4IQaJRHF9tV7RJLOXej+ImfYr vb68azsqM2oTLBP5qoHGzXzzoVZPf1AS1jpi4FUo30KNscwR9reTSYz5+/WUoR0gEOWA SyjuEq/p+QWUWmpKLqn2+maQFSlm8aB7U/TgxJmQNAUN+9L3mxAMdbRcUQfxMgRA4WUZ YgLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678824731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KRAW+s3YRlQq9ELNdyAribiRoHUxDdhi6TfZn0sTs4U=; b=1e6TjyuD2Hx/KPEWrQZTSi8+/S2oOj2JV7SeOvFFDQwfaxr1gkjSLcH4+S3PgxoZbc bsJSYZrJ20NHmHCWVqendmr35N88eIRQyx2g+KTVaLJ+KjTxXXmFLzcJnOVeeO3kU3eF UQpPnsTvvOjf5vn4osNrA0Q/4DMkVBC21M2XaAUqXNIzJX5iejXX3sADkr+nxca9+4/a LqOk5bkotD2paTqk5QR1UJ57L4HnDy2QbTHAedbZDLL0SwsVtU645C46D1kMy8/vdj/2 uZdZFDhLh5eaoMdLXqUB7KCJ9fp/bFYuIbswNERbCcJYq3LIHGkDjYgCBzfqKYyVFPcX JMxg== X-Gm-Message-State: AO0yUKVgiRosU4JWdffPch/MU9aJIGmVHDE74lmbjAge9zmsV9w51pqu RjVV+JRaRHBIsn3+90dslVE= X-Google-Smtp-Source: AK7set/atfmmI/iiWSLj+6Q8qdeuejUSglqHN4Ir/kY6mIHUaNZh5/6ToQiam39SOdRa/z5WUQPoIA== X-Received: by 2002:a17:907:2d93:b0:8aa:33c4:87d5 with SMTP id gt19-20020a1709072d9300b008aa33c487d5mr4590746ejc.10.1678824731247; Tue, 14 Mar 2023 13:12:11 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id qa14-20020a170907868e00b008f702684c51sm1528290ejc.161.2023.03.14.13.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 13:12:10 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Mark Brown , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 75/87] spi: sun6i: Convert to platform remove callback returning void Date: Tue, 14 Mar 2023 21:12:09 +0100 Message-ID: <8231800.NyiUUSuA9g@jernej-laptop> In-Reply-To: <20230303172041.2103336-76-u.kleine-koenig@pengutronix.de> References: <20230303172041.2103336-1-u.kleine-koenig@pengutronix.de> <20230303172041.2103336-76-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_131215_019968_BF5B88E2 X-CRM114-Status: GOOD ( 21.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 03. marec 2023 ob 18:20:29 CET je Uwe Kleine-K=F6nig napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig > --- Acked-by: Jernej Skrabec Best regards, Jernej > drivers/spi/spi-sun6i.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > = > diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c > index 23ad052528db..43c29afea6bb 100644 > --- a/drivers/spi/spi-sun6i.c > +++ b/drivers/spi/spi-sun6i.c > @@ -683,7 +683,7 @@ static int sun6i_spi_probe(struct platform_device *pd= ev) > return ret; > } > = > -static int sun6i_spi_remove(struct platform_device *pdev) > +static void sun6i_spi_remove(struct platform_device *pdev) > { > struct spi_master *master =3D platform_get_drvdata(pdev); > = > @@ -693,7 +693,6 @@ static int sun6i_spi_remove(struct platform_device > *pdev) dma_release_channel(master->dma_tx); > if (master->dma_rx) > dma_release_channel(master->dma_rx); > - return 0; > } > = > static const struct of_device_id sun6i_spi_match[] =3D { > @@ -710,7 +709,7 @@ static const struct dev_pm_ops sun6i_spi_pm_ops =3D { > = > static struct platform_driver sun6i_spi_driver =3D { > .probe =3D sun6i_spi_probe, > - .remove =3D sun6i_spi_remove, > + .remove_new =3D sun6i_spi_remove, > .driver =3D { > .name =3D "sun6i-spi", > .of_match_table =3D sun6i_spi_match, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel