From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E0E3FD3776 for ; Wed, 25 Feb 2026 17:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3RYgv+ynJj3S1QIru3Hn9dqc29aPNWjUzmoSLU7r5Kw=; b=dyChKLlasMlxejuRhiXJ+G6Tnq dxjwVhN3lJP67QZkvbXMIPNWHWTd3F+T4ywPJsJDDeBwGEC6r39HHIfHyacbP93n9tt8p5V/Wny9a 1uryjX18VJvg27a8nCK4lt/9l5r7CEM6IUTiGZwK9wnWHoThKdHDoKmWYZ8ZJSS574qbGuRaNyXM+ TcYaYw0iSbcbS2g2/hkpeO4YPz3ITl12elJjKknlCtiKU5u6BmgDxKgMvP1e+ohrr+bwxkuluc9MA Quaw7kZeRw7rHENvNZVfWDLieOmHIWZy9ido13bqo2j70UY7g/WVyc2N6PCever0vBy0AFM1RzGsC tXs+Pw3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvIIu-00000004bBT-34W5; Wed, 25 Feb 2026 17:04:04 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvIIr-00000004b8i-3YBx; Wed, 25 Feb 2026 17:04:03 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1772038990; cv=none; d=zohomail.com; s=zohoarc; b=Stq7NiyxW5CF/ZYpj1nqvMDannoyZwlnMzQ/PgyeF0NaxkMVUlI68eDs/afuHnbr2+WHFmRQZxfJTlYWlLd0zyLWqjjWUVTxJnumFxAofhYeOXCqmvKvqp555F7wVXsQumH5tw1GduK4PpZ5MrE99aPbOnBScVHIW5+7cxFCsaM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772038990; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=3RYgv+ynJj3S1QIru3Hn9dqc29aPNWjUzmoSLU7r5Kw=; b=a5Oe0Ndnnz06KHDJo5Dq3J6MK/1KLjOuG3mwgwqqqQbKovJWasZ2MCpjlf8ey6OnHnCH4SKGA2z2D1avhxLtcyK+FRyYoZXnSih4UZM7quz5VNvfSBEPZ9pvoY+A2AMBB4eNwEzhaTesQui5FtYM0obtGOLyxS312/LjUHkL7vg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1772038990; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=3RYgv+ynJj3S1QIru3Hn9dqc29aPNWjUzmoSLU7r5Kw=; b=V3jgCVhIW8MxRWz+GFV+y8JHyIm3dWD68I3G+7EGdF+br4N512+++HwmFH7XXJyX VTX84XBJmyiXwt+qxWxRcDszqGbmzTaLyzaROG7CcMhxb7bXr21EUYFCQsl2vZalyv8 FARjC/W5DW9MnsdktyO2a03wVkp5f4pro6xFBbTQ= Received: by mx.zohomail.com with SMTPS id 1772038989356790.0109700812275; Wed, 25 Feb 2026 09:03:09 -0800 (PST) From: Nicolas Frattaroli To: Jani Nikula , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?UTF-8?B?S8O2bmln?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Andy Yan , Liviu Dudau , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Sandy Huang , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Liu Ying , Chen-Yu Tsai , Samuel Holland , Dave Stevenson , =?UTF-8?B?TWHDrXJh?= Canal , Raspberry Pi Kernel Maintenance , Maxime Ripard Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 14/14] drm/display: hdmi: Use drm_output_color_format instead of hdmi_colorspace Date: Wed, 25 Feb 2026 18:03:00 +0100 Message-ID: <8234454.EvYhyI6sBW@workhorse> In-Reply-To: <20260224-drm-rework-color-formats-v1-14-bebc76604ada@kernel.org> References: <20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org> <20260224-drm-rework-color-formats-v1-14-bebc76604ada@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260225_090401_924473_64CEDFDA X-CRM114-Status: GOOD ( 24.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday, 24 February 2026 11:58:53 Central European Standard Time Maxime Ripard wrote: > The hdmi_colorspace enum was defined to represent the colorspace value > of the HDMI infoframes. It was later used by some HDMI drivers to > express the output format they should be setting up. > > During the introduction of the HDMI helpers, it then was used to > represent it in the drm_connector_hdmi_state structure. > > However, it's always been somewhat redundant with the DRM_COLOR_FORMAT_* > defines, and now with the drm_output_color_format enum. Let's > consolidate around drm_output_color_format in drm_connector_hdmi_state > to facilitate the current effort to provide a global output format > selection mechanism. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/bridge/inno-hdmi.c | 6 +- > drivers/gpu/drm/bridge/ite-it6263.c | 2 +- > drivers/gpu/drm/display/drm_hdmi_helper.c | 7 +- > drivers/gpu/drm/display/drm_hdmi_state_helper.c | 52 ++++-- > drivers/gpu/drm/drm_bridge.c | 2 +- > drivers/gpu/drm/drm_connector.c | 14 +- > drivers/gpu/drm/mediatek/mtk_hdmi_v2.c | 8 +- > drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +- > drivers/gpu/drm/tests/drm_connector_test.c | 80 ++++----- > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 182 ++++++++++----------- > drivers/gpu/drm/vc4/vc4_hdmi.c | 18 +- > drivers/gpu/drm/vc4/vc4_hdmi.h | 2 +- > include/drm/display/drm_hdmi_helper.h | 3 +- > include/drm/drm_connector.h | 7 +- > 14 files changed, 205 insertions(+), 180 deletions(-) > > [... snip ...] > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 4f5b27fab475c7c733622eb8727927571f3fb8fe..171cd495976a3e16f201fd339d3d42a09dc3b63f 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > [... snip ...] > > @@ -1424,25 +1424,25 @@ drm_hdmi_connector_get_broadcast_rgb_name(enum drm_hdmi_broadcast_rgb broadcast_ > return broadcast_rgb_names[broadcast_rgb].name; > } > EXPORT_SYMBOL(drm_hdmi_connector_get_broadcast_rgb_name); > > static const char * const output_format_str[] = { > - [HDMI_COLORSPACE_RGB] = "RGB", > - [HDMI_COLORSPACE_YUV420] = "YUV 4:2:0", > - [HDMI_COLORSPACE_YUV422] = "YUV 4:2:2", > - [HDMI_COLORSPACE_YUV444] = "YUV 4:4:4", > + [DRM_OUTPUT_COLOR_FORMAT_RGB444] = "RGB", > + [DRM_OUTPUT_COLOR_FORMAT_YCBCR420] = "YUV 4:2:0", > + [DRM_OUTPUT_COLOR_FORMAT_YCBCR422] = "YUV 4:2:2", > + [DRM_OUTPUT_COLOR_FORMAT_YCBCR444] = "YUV 4:4:4", > }; > > /* > * drm_hdmi_connector_get_output_format_name() - Return a string for HDMI connector output format > * @fmt: Output format to compute name of > * > * Returns: the name of the output format, or NULL if the type is not > * valid. > */ > const char * > -drm_hdmi_connector_get_output_format_name(enum hdmi_colorspace fmt) > +drm_hdmi_connector_get_output_format_name(enum drm_output_color_format fmt) > { > if (fmt >= ARRAY_SIZE(output_format_str)) > return NULL; Almost unrelated nit: we might want to also `fmt < 0 ||` here, since the base type of enums is a signed int. I almost caught myself using this function as a way to quickly check if a supplied color format property from userspace was valid, which would've had some unpleasant consequences for the kernel's memory. Alternatively, I make my own switch-case based "is this a valid enum value" function. I probably should do that actually, but my laziness lead me to make sure we only have a single source of truth of what counts as a valid enum value. > > return output_format_str[fmt]; > [... snip ...] Thanks for your work on this series, I was afraid of getting rid of DRM_COLOR_FORMAT_* myself because I suspected it was going to be a fairly large refactor across every driver. Guess I was both right and wrong: it touches many files, but all the replacements are fairly simple. :) Kind regards, Nicolas Frattaroli