From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54529C64ED8 for ; Mon, 27 Feb 2023 11:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ia6Qn4OlDLYOZU04/IqpXh4nLDeK2LPUiSvVi2/Y8cU=; b=GLNr79Q+2E2o7U zGdYGS3t1AWn9ZS/ChcE39S54MHaA1pn1EUaFFEcSHCX4L6bJ6ZtBmIEDM+CeXll3zUHjmQ13167P JnNZAjo0Ra0Jfc5ntzVu/Se4mw6f4Jc9wfEgpRGN5/p1i7o98dujtiYQq9ep5E0R+CYxWrJ/MWdS/ 0tlEqoBqh+whgFn2qBcOsq38MZ4jkW1Pmlbt4iKkz2ZXHaNCWPV/LChvpPwyGj8SbhUEe8BosPks3 qBbJxw7qWU5zdX1PSTeTmlmiquRj+u20eBqyyOwDlwKRrBngNlEE9VN0hGpPKCBk7qmbVERIVNsIU CC7KqLTxlt3IuwfHH+gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWbpW-009Nhv-6k; Mon, 27 Feb 2023 11:38:06 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWbmX-009NOA-B4 for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 11:35:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1677497701; x=1709033701; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aZgd/jY/MM8eKQNs/+AK8AJM0a2tQcJSNHCU9ZHspnY=; b=KsYCx35Lz0btb/w2IylEhJbh+rfWr8PGQpmLAQNIqp4PlG0hCpWY2thR 4I8x/KxrNC2dNaUy6noCjEdKCSWXor5Lf/no3tToWI5vWIEr6N/KA5zhC 2KM5IE6IeXxVURS5XrBtMbxgVjXt99aeFPpxfAtD2XqIihfzeMqgxBJ3l 5yjnXH90wKR3JwC96aRtu5upSYzioeqKA1DghRCK7+zBiCwEdUgmh61Ym VvjXa2fIn8tiVr3ncydlIakeEmBu0vQPbUoTvmku1or4f9kClSeqbGUu8 wFIXIE6HySOM4aEBgN9W23ePU9gDOwO6Mr9DPdZ9xbtYXFdhbThtdnCcY A==; X-IronPort-AV: E=Sophos;i="5.97,331,1669071600"; d="scan'208";a="29333228" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 27 Feb 2023 12:34:59 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 27 Feb 2023 12:34:59 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 27 Feb 2023 12:34:59 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1677497699; x=1709033699; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aZgd/jY/MM8eKQNs/+AK8AJM0a2tQcJSNHCU9ZHspnY=; b=RBTaUdoC2MpiifS3kGb7A2AEwjBXvs8MY/sjLP7x2spLPJcYB/0ve6Fe g4idnfFhiUUEqIfdCyCCIUpzyHXffWvBsRDSeaxR5RsoEQbMHcxpJ+Sw9 15effmJ5u4zb6GoDz6vpRtW6nSx7tzU+6XsS++IzFs4mY2pbqg5J+6zXy eYEk1rFSucLqmidf+6l1zpWNu6xIfIPpQl/gjE7YQMOAsEeA5+jp6DIe9 hLExMqS616hHzXBqkEo3ZXH6oKR3bPGNfcx333avNHqpSkQBL2psq/+W9 t+B930+1WmbaGTyQbIlXmQ+E3FHmsNkNbyGCV6FUbYzioS0StgjenhA06 g==; X-IronPort-AV: E=Sophos;i="5.97,331,1669071600"; d="scan'208";a="29333226" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 27 Feb 2023 12:34:59 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 01A80280056; Mon, 27 Feb 2023 12:34:58 +0100 (CET) From: Alexander Stein To: Marco Felsch Cc: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Fabio Estevam , devicetree@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] arm64: dts: imx93: Add FlexSPI support Date: Mon, 27 Feb 2023 12:34:58 +0100 Message-ID: <8236590.NyiUUSuA9g@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230227105710.ty42l7txx4gpdkw5@pengutronix.de> References: <20230227104324.249343-1-alexander.stein@ew.tq-group.com> <20230227105710.ty42l7txx4gpdkw5@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_033501_789410_88459F34 X-CRM114-Status: GOOD ( 24.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marco, Am Montag, 27. Februar 2023, 11:57:10 CET schrieb Marco Felsch: > Hi Alexander, > = > On 23-02-27, Alexander Stein wrote: > > Add FlexSPI node for i.MX93. > > = > > Signed-off-by: Alexander Stein > > --- > > This is mainly taken from the downstream kernel with the clock order > > fixed and 'nxp,imx93-fspi' compatible removed. > > I do not know if it makes sense to add an imx93 specific compatible or > > not. imx8mn uses imx8mm only, but imx8mp has it's own. But the latter > > uses the same device data in the driver. > > = > > arch/arm64/boot/dts/freescale/imx93.dtsi | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > = > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > > b/arch/arm64/boot/dts/freescale/imx93.dtsi index > > 3c3d3d570d8c..1d71ca8d1f5a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > > @@ -458,6 +458,21 @@ flexcan2: can@425b0000 { > > = > > status =3D "disabled"; > > = > > }; > > = > > + flexspi1: spi@425e0000 { > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + compatible =3D "nxp,imx8mm-fspi"; > > + reg =3D <0x425e0000 0x10000>, = <0x28000000 0x10000000>; > = > The compatible should always be the first entry, followed by reg. Thanks for the feedback. I was wondering about this, but there is no = consistency within this file :( Best regards, Alexander > Regards, > Marco > = > > + reg-names =3D "fspi_base", "fspi_mmap"; > > + interrupts =3D ; > > + clocks =3D <&clk = IMX93_CLK_FLEXSPI1_GATE>, > > + <&clk = IMX93_CLK_FLEXSPI1_GATE>; > > + clock-names =3D "fspi_en", "fspi"; > > + assigned-clocks =3D <&clk = IMX93_CLK_FLEXSPI1>; > > + assigned-clock-parents =3D <&clk = IMX93_CLK_SYS_PLL_PFD1>; > > + status =3D "disabled"; > > + }; > > + > > = > > lpuart7: serial@42690000 { > > = > > compatible =3D "fsl,imx93-lpuart", = "fsl,imx7ulp-lpuart"; > > reg =3D <0x42690000 0x1000>; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel