From: Sven Peter <sven@kernel.org>
To: Janne Grunau <j@jannau.net>, Neal Gompa <neal@gompa.dev>,
Lee Jones <lee@kernel.org>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: macsmc: Initialize mutex
Date: Wed, 8 Oct 2025 16:20:57 +0200 [thread overview]
Message-ID: <82605ddd-d0d8-4449-8bb9-9f94b2bde734@kernel.org> (raw)
In-Reply-To: <20250925-macsmc-mutex_init-v1-1-416e9e644735@jannau.net>
On 25.09.25 22:33, Janne Grunau wrote:
> Struct apple_smc's mutex was not initialized before use. Surprisingly
> this only resulted in occasional NULL pointer dereferences in
> apple_smc_read() calls from the probe() functions of sub devices.
>
> Fixes: e038d985c9823 ("mfd: Add Apple Silicon System Management Controller")
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
Reviewed-by: Sven Peter <sven@kernel.org>
Thanks,
Sven
next prev parent reply other threads:[~2025-10-08 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 20:33 [PATCH] mfd: macsmc: Initialize mutex Janne Grunau
2025-09-27 2:28 ` Neal Gompa
2025-09-27 13:57 ` Markus Elfring
2025-10-01 9:55 ` Lee Jones
2025-10-01 11:13 ` Markus Elfring
2025-10-01 12:48 ` Lee Jones
2025-10-01 12:52 ` Markus Elfring
2025-10-08 13:57 ` Lee Jones
2025-10-08 14:20 ` Sven Peter [this message]
2025-10-21 15:09 ` [PATCH] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82605ddd-d0d8-4449-8bb9-9f94b2bde734@kernel.org \
--to=sven@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=j@jannau.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).