From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E76DCE79AA for ; Tue, 19 Sep 2023 17:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Lw8ESi7zbMqSw05Y4fHX2Zo7ctmEi2gtUx6Q3PeeHE=; b=MC/9tXA5npXnnO L24fIQaCE5/MFFH/AK2lfOUJkY3C6h7RUulRHKywyCtS756yrUjn/SiyQE/6Xo5MPtzqoa7XM2lF1 pAR4qVkxICmvQ3P36JAy3hdcWG4VkfJAdhNGk6ClhyFZqoM1Asqmuybp+xuZU4W9s1uvxUPqpXEF7 4XSKl5IUi0Z2hJMIDVoNM6ZBbejpDWJNCDBPCLPS2J4BUqNbBP73RijkW7eZyyHghxy0gidZ2qMOL pqW8u8BX/A0mGOPUWAGXnyVXfnOZfL6U4PDOvT8i17CotZHTqQwNlRc3f88boYLYS0JNF+LCueyWH TJRYeLQ+XyHfUMSs0pHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qieRF-000vmB-1a; Tue, 19 Sep 2023 17:23:05 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qieRC-000vji-2v for linux-arm-kernel@lists.infradead.org; Tue, 19 Sep 2023 17:23:04 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-99c3d3c3db9so814128266b.3 for ; Tue, 19 Sep 2023 10:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695144178; x=1695748978; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HcXUnksJwhyRAlze+kKPMXIvfRdnYvFyu340idGgApY=; b=Sp7bxXVYNdaIYgd4aOiyV0RJUWg8K+l4xf6qlUJ8CkHgMQg+SNuae16phV4YOlCzEI yg9MMLfVgguiyulcyaeYI286aQ+ypl8fLCMRkzOHDuVcZ8FFSZ4+2h4hnrpyEnYTym9T wS9h99bjIokhEcSIEdsGYwKBC88ZdUj46tUpoxB0VZRFg1Kiv9TCftNe9PUYmXKWD9qq RWxleNd8CkjdbtQsqOYgF0ZmB6REvJXZ3EkUc+1J5N6VGw9whY6AHp9wUwX/54dXVbM4 pnkHWzss3hebjJEVMu1NRDy86FNG0PSJ2QKD+LwgnhxMNKpBN5pdvp2q6g7fYUqMdZv5 GUIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695144178; x=1695748978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HcXUnksJwhyRAlze+kKPMXIvfRdnYvFyu340idGgApY=; b=ayv9DH7LebqWpg+ft+bc9tHUcGs9XnkZoGkHXESu2Su8+lk+cE+G8b/p6vz8cRPpQf pCy+ZdE7psUcliTJvP8boy/GrxwzONKeud09OcKGgjJq7yaiDasPBenXpxrbxnyvS7kE DU6FgdoS2tSuH3SJgkkKVnPq7Pl/UVU56/pX5IuWPvMRpEAlZ2NcG4NrPFsXEWUwdsHN HTlFw6j3G2wtCyFUrLq6b/vgxeH/7EiIupc5rXUJdfT2R+EgnKDYhIgBIaCcVXjQmXRd Ia6S7EdHWVlb0wbMnIFI79bEXmpkdN6dZKaPwPIOHIHuNv6r/sS0ZjPObEwMnP8vQAMI m8aA== X-Gm-Message-State: AOJu0YxS1jFgXoDqMOhcpWg2PFEhWp9CY3i5kmahuFqICLdzThb4lOdV awihmM4JEGuQvB4OYV6I6qE= X-Google-Smtp-Source: AGHT+IF1Q4adU0rIcBVlI48STfiiF389ivz0W8cymo4KGMc3SHlL5K2MmpfuORVbO6ik0/JbKkDBjw== X-Received: by 2002:a17:906:1de:b0:9ae:3f3a:828d with SMTP id 30-20020a17090601de00b009ae3f3a828dmr53646ejj.21.1695144177494; Tue, 19 Sep 2023 10:22:57 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id jp27-20020a170906f75b00b0099bd046170fsm8115171ejb.104.2023.09.19.10.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 10:22:57 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Andrew Lunn , Heiner Kallweit , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Samuel Holland , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 18/19] net: mdio: sun4i: Convert to platform remove callback returning void Date: Tue, 19 Sep 2023 19:22:55 +0200 Message-ID: <8276262.T7Z3S40VBb@jernej-laptop> In-Reply-To: <20230918195102.1302746-19-u.kleine-koenig@pengutronix.de> References: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> <20230918195102.1302746-19-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230919_102302_948952_24048C5D X-CRM114-Status: GOOD ( 23.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 18. september 2023 ob 21:51:01 CEST je Uwe Kleine-K=F6nig = napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() is renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej > --- > drivers/net/mdio/mdio-sun4i.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/drivers/net/mdio/mdio-sun4i.c b/drivers/net/mdio/mdio-sun4i.c > index f798de3276dc..4511bcc73b36 100644 > --- a/drivers/net/mdio/mdio-sun4i.c > +++ b/drivers/net/mdio/mdio-sun4i.c > @@ -142,7 +142,7 @@ static int sun4i_mdio_probe(struct platform_device > *pdev) return ret; > } > = > -static int sun4i_mdio_remove(struct platform_device *pdev) > +static void sun4i_mdio_remove(struct platform_device *pdev) > { > struct mii_bus *bus =3D platform_get_drvdata(pdev); > struct sun4i_mdio_data *data =3D bus->priv; > @@ -151,8 +151,6 @@ static int sun4i_mdio_remove(struct platform_device > *pdev) if (data->regulator) > regulator_disable(data->regulator); > mdiobus_free(bus); > - > - return 0; > } > = > static const struct of_device_id sun4i_mdio_dt_ids[] =3D { > @@ -166,7 +164,7 @@ MODULE_DEVICE_TABLE(of, sun4i_mdio_dt_ids); > = > static struct platform_driver sun4i_mdio_driver =3D { > .probe =3D sun4i_mdio_probe, > - .remove =3D sun4i_mdio_remove, > + .remove_new =3D sun4i_mdio_remove, > .driver =3D { > .name =3D "sun4i-mdio", > .of_match_table =3D sun4i_mdio_dt_ids, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel