From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCCB7E9270D for ; Thu, 5 Oct 2023 15:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8o0cMjM7K9CYcuAvdnWAGCkO7eGxsB4HqTsoh/62hgk=; b=Bu4Iv7kmaNg+2C /B2vPF+6sdy74yJ7Q2Y4xgU64LXc7QK1JiZvNTRbzlC+jakcgOd2geuvrCqRVSnP7Uxtn7FWw766z vYmo2igNxn9qronUGaiU9GqKlufscC54ylTjyVzP8j8J14CSsUz5Go3pgx1MZI4trqpSJXIe0Fu4o 4x6GrpkIUVrluvjBIwnNy3aAM0tpeoF3Zs5IbsSgl3zUps9L1sov7MJ3NdTWYKrwYqiWscTDSvpNR OIRdZBbCZmaXWS04MPxBsADzOK+QHGl0PLoK+DI80xYGIxYOVzdT37V9vNE7Ny7AJHZh37jMQXFu3 JECzF0GtycblYpop9C4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoQVw-003vOw-1L; Thu, 05 Oct 2023 15:43:48 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qoQVt-003vNr-32; Thu, 05 Oct 2023 15:43:47 +0000 Received: from i53875a3c.versanet.de ([83.135.90.60] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qoQVr-0006gu-Jp; Thu, 05 Oct 2023 17:43:43 +0200 From: Heiko Stuebner To: Sebastian Reichel , Benjamin Gaignard Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] arm64: dts: rockchip: rk3588is: Add AV1 decoder node Date: Thu, 05 Oct 2023 17:43:42 +0200 Message-ID: <8278535.T7Z3S40VBb@phil> In-Reply-To: <531ea6cc-83b5-4c88-90a3-576e2e38bf80@collabora.com> References: <20231005145420.169594-1-benjamin.gaignard@collabora.com> <2298521.ElGaqSPkdT@phil> <531ea6cc-83b5-4c88-90a3-576e2e38bf80@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231005_084346_005301_C7D6073C X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Donnerstag, 5. Oktober 2023, 17:39:18 CEST schrieb Benjamin Gaignard: > = > Le 05/10/2023 =E0 17:30, Heiko Stuebner a =E9crit : > > Am Donnerstag, 5. Oktober 2023, 17:12:10 CEST schrieb Sebastian Reichel: > >> Hi, > >> > >> On Thu, Oct 05, 2023 at 04:54:20PM +0200, Benjamin Gaignard wrote: > >>> Add node for AV1 video decoder. > >>> > >>> Signed-off-by: Benjamin Gaignard > >>> Signed-off-by: Sebastian Reichel > >> No need for my SoB. Instead have this one: > >> > >> Reviewed-by: Sebastian Reichel > >> > >> Also worth mentioning, that this Patch needs one small fix in the DT > >> binding (adding "resets") and one small fix in the driver for out of > >> the box AV1 support: > >> > >> https://lore.kernel.org/all/20231005144934.169356-1-benjamin.gaignard@= collabora.com/ > >> https://lore.kernel.org/all/20231005145116.169411-1-benjamin.gaignard@= collabora.com/ > > additionally the node name should be generic. > > The phandle can of course be av1d but the node > > name itself needs a change. > = > Does "video-codec-av1@fdc70000" sound good for you ? Nope ... please go with video-codec@fdc... I.e. see the other Rockchip soc dtsi for reference. Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel