From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A202C433F5 for ; Thu, 7 Apr 2022 20:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8iQgMCy7yB8XZ4BfRSPw0Dym9pxapG/CdL5d17IJHkg=; b=HrHFSZNCReYanx 1VnaVRytEepPX+8V7ae2s/daUq7elrBWRWE6fgVn7oJUW+6c6/kRECJ1q4YC6Y1qsA/niIQ9p7RWe aKsNKk90zwk6z4MCcoCK2UNxa0NrFH1cKnCUKGMdwo3iQUgi1PLsy+5t0DQpzCXOe8gB+nChKu9Oe 3hPlQI7xH2m+3ACwZTiJ8RC19mjx7bA6n9hBk8E6G0XmelLi8WoL3QWiC9Cog+sKPxvJKOPfCRr7h DW2vWJRfOt+yNQSfK5f1ZxLVdEGf4k1E3aogz/eqVzT87G/TfuqizYtkJgbl5n/nzoparW3VmHYOy 3YwiQQglrWwGfJB7yDzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncZCy-00E3Zi-Os; Thu, 07 Apr 2022 20:58:24 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncZCv-00E3WQ-60 for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 20:58:22 +0000 Received: by mail-ed1-x52b.google.com with SMTP id b15so7856482edn.4 for ; Thu, 07 Apr 2022 13:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gOv/51dHbvSvAxLzxG0YE6pJrgjLizkZFj88kA5U1Ts=; b=LtV+LimrEebMzUK1IOhvEXGb2ymNgMZl7qh+Db0K2zNRN9P2+inYAeLmBHYB2w6OkO mn/kik52wDH8tc8FUpvnPbCEntUH62DwQiMG6ydiIqlYKJmkEYvdOUC8WI9fYcl0ysB1 H6FwSKAovj274rvZkqlyUAzRkERYk49kh8aZUoMkYXZSgZxVakbuGIBuJ5MwSay6PeWy mzuQZ7aln0oPp2FhclYJyvKN5snzc2HBQQSTWgLAs7rRk1QNqx4VpUvRU2ENIa5w2Yxt 4cczopCH7g7pzQE8kYQ/fYdIrqeKWaHCjByr9giggQf34469Y2UAfBvapmZcmSD+hqiH /fjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gOv/51dHbvSvAxLzxG0YE6pJrgjLizkZFj88kA5U1Ts=; b=0EDMZk4I6MEubB80V008B8SNibF808Dpcyv8iv6DEylPZ34fSqazZOmv6wZVE8Wz/f m8k9TBdluHvtOwc7lJ9lk+zw9XJwCVmxK2pmfhiB1Z32FuwcD27+GSBjo1fypXNcknJI taIhArIAqiLzIP/fDR9SA6w2+MamuWU1BMfroxLHkO/w01yloiLl96oTnU26viddVDMR cNuYB2DvTuROwaMtQfe9uKlE7JcOx/3WlA/Z4HKGxwBPSEBz4JZnv2lK6Q/xb0V/g5V8 u4hpomMefSj+wHE31g4DkQlszNi1LWNxl6hQcFikqoMnzWzpnIYyvB3Vj+RhNo5pcNi+ +ibw== X-Gm-Message-State: AOAM5322qkaORM7NCp2OkQe6OOjn/hOBB2X/2rK2hK8+h/cpDoxjN7Gy tFeEX4lNzD1WRxFZi7qOIUFECQ== X-Google-Smtp-Source: ABdhPJzKZKgo7bJk0AYUXlwb2y8mbmmQYcn7Gd1R46cDu+04zIt7arhMKkYnlMab8y4eU6cP1/Q3hg== X-Received: by 2002:a05:6402:3604:b0:41c:c4e6:2988 with SMTP id el4-20020a056402360400b0041cc4e62988mr16115607edb.157.1649365097189; Thu, 07 Apr 2022 13:58:17 -0700 (PDT) Received: from [192.168.0.187] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id b11-20020a17090630cb00b006e83fb1e6b1sm738450ejb.100.2022.04.07.13.58.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 13:58:16 -0700 (PDT) Message-ID: <827e5f9c-13ef-08fb-d167-80c6c4ea5631@linaro.org> Date: Thu, 7 Apr 2022 22:58:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support Content-Language: en-US To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, fancer.lancer@gmail.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-12-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: <20220406233648.21644-12-brad@pensando.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_135821_295016_C110BBF9 X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/04/2022 01:36, Brad Larson wrote: > Add Pensando common and Elba SoC specific device nodes > > Signed-off-by: Brad Larson > --- > Change from V3: > - Changed to dual copyright (GPL-2.0+ OR MIT) > - Minor changes from review input Thank you for your patch. There is something to discuss/improve. (...) > +&i2c0 { > + clock-frequency = <100000>; > + status = "okay"; > + rtc@51 { > + compatible = "nxp,pcf85263"; > + reg = <0x51>; > + }; > +}; > + > +&spi0 { > + num-cs = <4>; > + cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>, > + <&porta 7 GPIO_ACTIVE_LOW>; > + status = "okay"; > + spi0_cs0@0 { Generic node name needed matching the class of a devicxe. > + compatible = "semtech,sx1301"; /* Enable spidev */ This comment is a bit odd... did you just use random compatible from spidev instead of defining proper compatible? > + #address-cells = <1>; > + #size-cells = <1>; Why address/size cells? > + spi-max-frequency = <12000000>; > + reg = <0>; Please put reg just after compatible. It's the most common pattern. > + }; > + > + spi0_cs1@1 { > + compatible = "semtech,sx1301"; > + #address-cells = <1>; > + #size-cells = <1>; > + spi-max-frequency = <12000000>; > + reg = <1>; > + }; > + (...) > + > + emmc: mmc@30440000 { > + compatible = "pensando,elba-sd4hc", "cdns,sd4hc"; > + clocks = <&emmc_clk>; > + interrupts = ; > + reg = <0x0 0x30440000 0x0 0x10000>, > + <0x0 0x30480044 0x0 0x4>; /* byte-lane ctrl */ > + cdns,phy-input-delay-sd-highspeed = <0x4>; > + cdns,phy-input-delay-legacy = <0x4>; > + cdns,phy-input-delay-sd-uhs-sdr50 = <0x6>; > + cdns,phy-input-delay-sd-uhs-ddr50 = <0x16>; > + mmc-ddr-1_8v; > + status = "disabled"; > + }; > + > + mssoc: mssoc@307c0000 { Generic node name. > + compatible = "syscon", "simple-mfd"; This does not look correct. Syscon is okay, but why do you need simple-mfd (there are no children here)? > + reg = <0x0 0x307c0000 0x0 0x3000>; > + }; > + }; > +}; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel