From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED40C04AB6 for ; Fri, 31 May 2019 22:26:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 914CD26FB7 for ; Fri, 31 May 2019 22:26:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bkINy+3k"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Hlmnc+h5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 914CD26FB7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D/5FoqG+jAMUmZGuw8ZNbqTdh0ZodMIvG9kagxIBSss=; b=bkINy+3k2A1uAo 0AqDExX6Zm97TyKcc5aXPRZjLfyYggiC1cISss6AlwNru1sKllVsDuxs997rVV7xq8ZMqef9xEaTz J+DnPgTc6KwB2MDpHk7vfppZKfLRCCbQbmHpdfpwHEq6CNrdRbx9lZO/V8pyvqkhKE0mD2OcinxvG iF0nXJK1cmAkuunV8EE78/Z0r98jnfKBrZL15Dob4nd00oYbOGUto1omJWB/Yzjcna2OlPw8ZypRf jacZVPrsyvwqQSivQuKYpx61RX1qNakECvXFolUvoKRANg6BbAZ4086qaa/d4L3R2+T1ET/a/QAub rHxtR1lYrvwx85CZfOSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWpyL-0005R0-Pw; Fri, 31 May 2019 22:26:01 +0000 Received: from mail-it1-x144.google.com ([2607:f8b0:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWpyI-0005Pe-0G for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 22:25:59 +0000 Received: by mail-it1-x144.google.com with SMTP id m141so18357560ita.3 for ; Fri, 31 May 2019 15:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jNO29A3eBJvwf2Vu9Oyg5E4jjTlIZetGj3NF5CjfGMc=; b=Hlmnc+h5861mci94IXNOb1Pm2K/0ArQ3l0KACnywjZOwv3P1ECcqa+VZ+zoiXhrRyS 91dnqz/NNnw7ufWxstEtybtxLBrHrKA/qei/0QaNIh1IkhzJieUH47QlzmN284PWCGCY jBB2Kjbb4wm8ZhY0Id2+ri0jTqSC8oFOMEcSb8HPhHhPSyzRNIqNbWWQdVXlEkx5Kmt5 nfaKo/Pjvo5vRWZzmGTWg/0xjYkxDVKxCASO7ynAFxG/yE//lxPCl3OwMSB5dAZSVR81 YEKWnHi8tnyQec0gqdbuW4E0tHdQ+NkDo/eO0Ex4cHfU8SiCnN3IA0lXzzIqlU3lWNLr /5gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jNO29A3eBJvwf2Vu9Oyg5E4jjTlIZetGj3NF5CjfGMc=; b=p9IxSRJlA0nnobuBf7cq40GM4caGXuiuzDXYmLV9ML0mFPG3WrxrdQRGBA26kRAOh+ 5On1z54dR3nh5sq622xrPQ4Kko35QN/FewVO2wUdkifIe2AztIgSqXTuB/4zqgQ7uBFt 6mJAqauTegNNNNeXJEZN9v9VS4p0+TDX4fg9Tn2F6npWyyomWZ5vf37+1WCPw46HXVOY SM10UZjtuD9aGnsctRwcdhufZIz4Nmpspo2ohn9wVq4DiGKs/iqsGkzCypLO96UJ2EQW Yfb6deSv7imT6gINXFfughD/fz+pW0Bn3WfPcUsa2VkyjLWU5BTGAj46Sf6xEBjanGgm D3+A== X-Gm-Message-State: APjAAAW1BhgMtQwl1lVYThb3QMLnIY0yM1O4Y1MuET0OIF5RTG/khsXm uGdePbRgVnoGV44nBPz4fSZ2qw== X-Google-Smtp-Source: APXvYqxn/8sjKyKDB1q/z3xyIFqbE0YwBOLGF5GhVsgmlK6s3ApK9hMQ4eWtlgBcJSrXjR9IMGygzA== X-Received: by 2002:a24:16c6:: with SMTP id a189mr8499974ita.179.1559341556857; Fri, 31 May 2019 15:25:56 -0700 (PDT) Received: from [172.22.22.26] (c-71-195-29-92.hsd1.mn.comcast.net. [71.195.29.92]) by smtp.googlemail.com with ESMTPSA id 194sm3015704itm.40.2019.05.31.15.25.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 15:25:56 -0700 (PDT) Subject: Re: [PATCH v2 03/17] soc: qcom: ipa: main code To: David Miller References: <20190531035348.7194-1-elder@linaro.org> <20190531035348.7194-4-elder@linaro.org> <20190531.145005.798440469894507477.davem@davemloft.net> From: Alex Elder Message-ID: <8295f702-2c3f-1fa3-0a4e-ebb51d5b03ee@linaro.org> Date: Fri, 31 May 2019 17:25:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190531.145005.798440469894507477.davem@davemloft.net> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_152558_051785_63EEDB84 X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, syadagir@codeaurora.org, ejcaruso@google.com, arnd@arndb.de, netdev@vger.kernel.org, ilias.apalodimas@linaro.org, linux-kernel@vger.kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, subashab@codeaurora.org, linux-soc@vger.kernel.org, abhishek.esse@gmail.com, cpratapa@codeaurora.org, benchan@google.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/31/19 4:50 PM, David Miller wrote: > From: Alex Elder > Date: Thu, 30 May 2019 22:53:34 -0500 > >> + void *route_virt; > ... >> + void *filter_virt; > ... > > If these are arrays of u64's, please declare them as "u64 *" instead of > the opaque "void *". Good idea. I hadn't paid attention to that. These tables are arrays of 64-bit addresses so it's better to represent them that way. Thanks. -Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel