From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C85F2C7EE22 for ; Mon, 15 May 2023 12:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RFSkYjJXXCNTzX3xYvIIVodFLCglyXxCBs6V/FSqGNI=; b=If+nUCGtoY6wPa dgyJV4cSX40FosuWVAQDhpNq9PjnsCUfdjZgTCBTPcJL+r0m+3zpxpsq/Bvp6QIyQgYGtq9ja6Hmw ikbYTB7dmBxYhfaa3vo3VYKkBjtMtPqCRWpOkXTs1GZcOmkJJ/H7HqgBEWAERRPrCkVVEkWqQUyNO 6HoOpxX1iiBUpWKSfZHC3WS3X+93dFKvFStIyUvT6n9C3xZ1piIh+fiDZMrTt5fBzVExh4LRRLHU7 GEM+ND2d3pffWbOB/rQPt9lSS2RDaBFewl+JrEqIbt24arL157JQWPGSNPZdGWNCSHsya1rksaN0W ZOCGWodyucHKuhjcJNkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyXNt-00286t-1a; Mon, 15 May 2023 12:33:01 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyXNm-00285f-0g for linux-arm-kernel@lists.infradead.org; Mon, 15 May 2023 12:32:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1684153974; x=1715689974; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BimgiWQfq8D4nb52g0I+bPET0u1s3lv+JZqzQj6qIno=; b=gtIUYUqqMBhqgRa/qT0mxoWAUCE10LzeFcsL1O9e8KDgroLZ4wTHOMe2 8hKCm2RCikVTn1dLKs/UqJNSTCIHWF+NJyPA6h996Ad/i6X2MUDRuzjwu 5nER7HUQe2qMIJfLFtCJqZCZpQGaHmqwUKggj6VDi0w5yarSUA3zuGCbk BF/+DvMYQsYIswP750JTb4Va4TJT7stcVOk9Q7RqIU++NYB0RFesoXPqf TufWjEP5HFh9PjJB7KkHhGkdAIR41ULFqPqMwUCzg+NFBC1A6ac3F/qLb nxEpoZIFPqenG9/B3Z4p428YwMmdtQDbZHDO5HvjUUqPr6N/+dglbalt9 A==; X-IronPort-AV: E=Sophos;i="5.99,276,1677538800"; d="scan'208";a="30909061" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 15 May 2023 14:32:51 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 15 May 2023 14:32:51 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 15 May 2023 14:32:51 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1684153971; x=1715689971; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BimgiWQfq8D4nb52g0I+bPET0u1s3lv+JZqzQj6qIno=; b=Uhx9ZJoo+INu8QcwC7bxfF2thoA422wNNp9gkGEdNggx5jcIQhQa7ai2 j62dkwlgsDgiRpSik9TVPnv/ntS44QlrS1yk1XPIISkNZvXNPO5vW0ESZ BdYStS0NDu2wnRq3ShHDOoCnQ/iy000cgT4mtKzjmG2T3wcD2duntID7q lU9/u0Zu2hC/SYW+W6SDa8GfYoGfVJMSCfMya9WZqUBEs0lwe5uymwagS vk1x0DTEMONOZIxCh0BiFMPs1vJKWZ7938Eb5SYlkhi5PXH+R5pJXdIez c1Uf4TZe5/Bfy60I++k1gRVsjllM+uT3SazYcW0gBqJF50PLCUtJ5kZ2q w==; X-IronPort-AV: E=Sophos;i="5.99,276,1677538800"; d="scan'208";a="30909060" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 15 May 2023 14:32:50 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id AA5D4280056; Mon, 15 May 2023 14:32:50 +0200 (CEST) From: Alexander Stein To: "Sverdlin, Alexander" Cc: "linux-imx@nxp.com" , "kernel@pengutronix.de" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "shawnguo@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" , "aisheng.dong@nxp.com" Subject: Re: [PATCH v3] i2c: lpi2c: cache peripheral clock rate Date: Mon, 15 May 2023 14:32:50 +0200 Message-ID: <8299946.T7Z3S40VBb@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20230310130815.562418-1-alexander.sverdlin@siemens.com> <1933234.tdWV9SEqCh@steina-w> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230515_053254_924989_D84AF6B4 X-CRM114-Status: GOOD ( 18.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, Am Montag, 15. Mai 2023, 14:04:10 CEST schrieb Sverdlin, Alexander: > Hello Alexander! > = > On Mon, 2023-05-15 at 11:11 +0200, Alexander Stein wrote: > = > > > [ 22.503179] other info that might help us debug this: > > > [ 22.503179] > > > [ 22.503183] Chain exists of: > > > [ 22.503183] prepare_lock --> rtc_pcf85063:594:(&config- > > > = > > > >regmap)->lock > > > = > > > --> i2c_register_adapter > > > [ 22.503183] > > > [ 22.503207] Possible unsafe locking scenario: > > > [ 22.503207] > > > [ 22.503210] CPU0 CPU1 > > > [ 22.503213] ---- ---- > > > [ 22.503216] lock(i2c_register_adapter); > > > [ 22.503225] = > > > lock(rtc_pcf85063:594:(&config- > > > = > > > > regmap)->lock); > > > = > > > = > > > [ 22.503235] = > > > lock(i2c_register_adapter); > > > [ 22.503244] lock(prepare_lock); > > > [ 22.503253] > > > [ 22.503253] *** DEADLOCK *** > > > = > > > Now lpi2c_runtime_resume will call into clk_prepare() which also > > > calls > > > clk_prepare_lock() (identical to clk_get_rate). > > > = > > > Best regards, > > > Alexader > > > = > > > = > > > > pm_runtime_set_autosuspend_delay(&pdev->dev, > > > > I2C_PM_TIMEOUT); > > > > pm_runtime_use_autosuspend(&pdev->dev); > > > > pm_runtime_get_noresume(&pdev->dev); > > = > > = > > With commit fa39065833db ("i2c: imx-lpi2c: avoid taking clk_prepare > > mutex in = > > PM callbacks") in place, the additional deadlock warning regarding > > runtime = > > resume is gone. > > So only the ordering issue needs to be addressed. > = > = > Unfortunately with both your (backported) and my patches applied I've > got a 3rd warning: > = > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > WARNING: possible circular locking dependency detected > 5.15.71+git8e43aee #1 Tainted: G O = > ------------------------------------------------------ > xxxxxxx/2238 is trying to acquire lock: > ffff0000040bda40 (&desc->request_mutex){+.+.}-{3:3}, at: > __setup_irq+0xbc/0x8bc > = > but task is already holding lock: > ffff000010ef1100 (i2c_register_adapter){+.+.}-{3:3}, at: > i2c_adapter_lock_bus+0x2c/0x3c > = > which lock already depends on the new lock. > = > = > the existing dependency chain (in reverse order) is: > = > -> #5 (i2c_register_adapter){+.+.}-{3:3}: > lock_acquire+0x68/0x84 > rt_mutex_lock_nested+0x88/0xe0 > i2c_adapter_lock_bus+0x2c/0x3c > i2c_transfer+0x58/0x130 > regmap_i2c_read+0x64/0xb0 > _regmap_raw_read+0x114/0x440 > _regmap_bus_read+0x4c/0x84 > _regmap_read+0x6c/0x270 > regmap_read+0x54/0x80 > pcf85063_probe+0xec/0x4cc > i2c_device_probe+0x10c/0x350 > really_probe+0xc4/0x470 > __driver_probe_device+0x11c/0x190 > driver_probe_device+0x48/0x110 > __device_attach_driver+0xc4/0x160 > bus_for_each_drv+0x80/0xe0 > __device_attach+0xb0/0x1f0 > device_initial_probe+0x1c/0x2c > bus_probe_device+0xa4/0xb0 > device_add+0x398/0x8ac > device_register+0x28/0x40 > i2c_new_client_device+0x144/0x290 > of_i2c_register_devices+0x18c/0x230 > i2c_register_adapter+0x1dc/0x6b0 > __i2c_add_numbered_adapter+0x68/0xbc > i2c_add_adapter+0xb0/0xe0 > lpi2c_imx_probe+0x3a4/0x670 > platform_probe+0x70/0xec > really_probe+0xc4/0x470 > __driver_probe_device+0x11c/0x190 > driver_probe_device+0x48/0x110 > __device_attach_driver+0xc4/0x160 > bus_for_each_drv+0x80/0xe0 > __device_attach+0xb0/0x1f0 > device_initial_probe+0x1c/0x2c > bus_probe_device+0xa4/0xb0 > deferred_probe_work_func+0xb8/0x110 > process_one_work+0x27c/0x6c4 > worker_thread+0x7c/0x450 > kthread+0x168/0x17c > ret_from_fork+0x10/0x20 > = > -> #4 (rtc_pcf85063:560:(&config->regmap)->lock){+.+.}-{3:3}: > lock_acquire+0x68/0x84 > __mutex_lock+0xa8/0x4d0 > mutex_lock_nested+0x48/0x54 > regmap_lock_mutex+0x1c/0x30 > regmap_read+0x44/0x80 > pcf85063_clkout_recalc_rate+0x34/0x80 > __clk_register+0x520/0x880 > devm_clk_register+0x64/0xc4 > pcf85063_probe+0x24c/0x4cc > i2c_device_probe+0x10c/0x350 > really_probe+0xc4/0x470 > __driver_probe_device+0x11c/0x190 > driver_probe_device+0x48/0x110 > __device_attach_driver+0xc4/0x160 > bus_for_each_drv+0x80/0xe0 > __device_attach+0xb0/0x1f0 > device_initial_probe+0x1c/0x2c > bus_probe_device+0xa4/0xb0 > device_add+0x398/0x8ac > device_register+0x28/0x40 > i2c_new_client_device+0x144/0x290 > of_i2c_register_devices+0x18c/0x230 > i2c_register_adapter+0x1dc/0x6b0 > __i2c_add_numbered_adapter+0x68/0xbc > i2c_add_adapter+0xb0/0xe0 > lpi2c_imx_probe+0x3a4/0x670 > platform_probe+0x70/0xec > really_probe+0xc4/0x470 > __driver_probe_device+0x11c/0x190 > driver_probe_device+0x48/0x110 > __device_attach_driver+0xc4/0x160 > bus_for_each_drv+0x80/0xe0 > __device_attach+0xb0/0x1f0 > device_initial_probe+0x1c/0x2c > bus_probe_device+0xa4/0xb0 > deferred_probe_work_func+0xb8/0x110 > process_one_work+0x27c/0x6c4 > worker_thread+0x7c/0x450 > kthread+0x168/0x17c > ret_from_fork+0x10/0x20 > = > -> #3 (prepare_lock){+.+.}-{3:3}: > lock_acquire+0x68/0x84 > __mutex_lock+0xa8/0x4d0 > mutex_lock_nested+0x48/0x54 > clk_prepare_lock+0x50/0xb0 > clk_prepare+0x28/0x50 > fec_runtime_resume+0x3c/0xe0 > pm_generic_runtime_resume+0x34/0x50 > __genpd_runtime_resume+0x38/0x90 > genpd_runtime_resume+0xa0/0x304 > __rpm_callback+0x50/0x1b0 > rpm_callback+0x40/0x80 > rpm_resume+0x448/0x6e0 > __pm_runtime_resume+0x50/0xc0 > fec_enet_mdio_read+0x48/0x190 > __mdiobus_read+0x48/0xb0 > mdiobus_read_nested+0x48/0x70 > mv88e6xxx_smi_dual_direct_read+0x2c/0x50 > mv88e6xxx_read+0x64/0xf0 > mv88e6xxx_g1_read+0x28/0x34 > mv88e6xxx_g1_irq_thread_work+0x50/0x17c > mv88e6xxx_irq_poll+0x28/0x50 > kthread_worker_fn+0x100/0x480 > kthread+0x168/0x17c > ret_from_fork+0x10/0x20 > = > -> #2 (&bus->mdio_lock/2){+.+.}-{3:3}: > lock_acquire+0x68/0x84 > __mutex_lock+0xa8/0x4d0 > mutex_lock_nested+0x48/0x54 > mdiobus_read_nested+0x38/0x70 > mv88e6xxx_smi_dual_direct_read+0x2c/0x50 > mv88e6xxx_read+0x64/0xf0 > mv88e6xxx_port_read+0x24/0x30 > mv88e6xxx_probe+0x250/0x7f0 > mdio_probe+0x3c/0x80 > really_probe+0xc4/0x470 > __driver_probe_device+0x11c/0x190 > driver_probe_device+0x48/0x110 > __device_attach_driver+0xc4/0x160 > bus_for_each_drv+0x80/0xe0 > __device_attach+0xb0/0x1f0 > device_initial_probe+0x1c/0x2c > bus_probe_device+0xa4/0xb0 > deferred_probe_work_func+0xb8/0x110 > process_one_work+0x27c/0x6c4 > worker_thread+0x7c/0x450 > kthread+0x168/0x17c > ret_from_fork+0x10/0x20 > = > -> #1 (&chip->reg_lock){+.+.}-{3:3}: > lock_acquire+0x68/0x84 > __mutex_lock+0xa8/0x4d0 > mutex_lock_nested+0x48/0x54 > mv88e6xxx_g1_irq_bus_lock+0x24/0x30 > __setup_irq+0x6e0/0x8bc > request_threaded_irq+0xf4/0x1b4 > mv88e6xxx_g2_irq_setup+0x1f0/0x2b4 > mv88e6xxx_probe+0x480/0x7f0 > mdio_probe+0x3c/0x80 > really_probe+0xc4/0x470 > __driver_probe_device+0x11c/0x190 > driver_probe_device+0x48/0x110 > __device_attach_driver+0xc4/0x160 > bus_for_each_drv+0x80/0xe0 > __device_attach+0xb0/0x1f0 > device_initial_probe+0x1c/0x2c > bus_probe_device+0xa4/0xb0 > deferred_probe_work_func+0xb8/0x110 > process_one_work+0x27c/0x6c4 > worker_thread+0x7c/0x450 > kthread+0x168/0x17c > ret_from_fork+0x10/0x20 > = > -> #0 (&desc->request_mutex){+.+.}-{3:3}: > __lock_acquire+0x12a4/0x20a0 > lock_acquire.part.0+0xe0/0x230 > lock_acquire+0x68/0x84 > __mutex_lock+0xa8/0x4d0 > mutex_lock_nested+0x48/0x54 > __setup_irq+0xbc/0x8bc > request_threaded_irq+0xf4/0x1b4 > devm_request_threaded_irq+0x88/0x104 > lpi2c_runtime_resume+0x70/0xe4 This looks like the NXP downstream kernel, requesting the IRQ from within = runtime resume. > pm_generic_runtime_resume+0x34/0x50 > __genpd_runtime_resume+0x38/0x90 > genpd_runtime_resume+0xa0/0x304 > __rpm_callback+0x50/0x1b0 > rpm_callback+0x74/0x80 > rpm_resume+0x448/0x6e0 > __pm_runtime_resume+0x50/0xc0 > lpi2c_imx_xfer+0x60/0xa5c > __i2c_transfer+0x174/0xa80 > i2c_transfer+0x68/0x130 > regmap_i2c_read+0x64/0xb0 > _regmap_raw_read+0x114/0x440 > regmap_raw_read+0x19c/0x28c > regmap_bulk_read+0x1b8/0x244 > at24_read+0x14c/0x2c4 > nvmem_reg_read+0x2c/0x54 > bin_attr_nvmem_read+0x8c/0xbc > sysfs_kf_bin_read+0x74/0x94 > kernfs_fop_read_iter+0xb0/0x1d0 > new_sync_read+0xf0/0x184 > vfs_read+0x154/0x1f0 > ksys_read+0x70/0x100 > __arm64_sys_read+0x24/0x30 > invoke_syscall+0x50/0x120 > el0_svc_common.constprop.0+0x68/0x124 > do_el0_svc+0x30/0x9c > el0_svc+0x54/0x110 > el0t_64_sync_handler+0xa4/0x130 > el0t_64_sync+0x1a0/0x1a4 > = > other info that might help us debug this: > = > Chain exists of: > &desc->request_mutex --> rtc_pcf85063:560:(&config->regmap)->lock --> > i2c_register_adapter > = > Possible unsafe locking scenario: > = > CPU0 CPU1 > ---- ---- > lock(i2c_register_adapter); > lock(rtc_pcf85063:560:(&config->regmap)- > = > >lock); > = > lock(i2c_register_adapter); > lock(&desc->request_mutex); > = > *** DEADLOCK *** > = > 4 locks held by xxxxxxx/2238: > #0: ffff000015a64488 (&of->mutex){+.+.}-{3:3}, at: > kernfs_fop_read_iter+0x74/0x1d0 > #1: ffff0000119e2400 (kn->active#58){.+.+}-{0:0}, at: > kernfs_fop_read_iter+0x7c/0x1d0 > #2: ffff0000119a26e8 (&at24->lock){+.+.}-{3:3}, at: > at24_read+0x8c/0x2c4 > #3: ffff000010ef1100 (i2c_register_adapter){+.+.}-{3:3}, at: > i2c_adapter_lock_bus+0x2c/0x3c > = > stack backtrace: > CPU: 1 PID: 2238 Comm: xxxxxxx Tainted: G O = > 5.15.71+git8e43aee #1 > Hardware name: Siemens PXC5.E24 (DT) > Call trace: > dump_backtrace+0x0/0x1d4 > show_stack+0x20/0x2c > dump_stack_lvl+0x8c/0xb8 > dump_stack+0x18/0x34 > print_circular_bug+0x1f8/0x200 > check_noncircular+0x130/0x144 > __lock_acquire+0x12a4/0x20a0 > lock_acquire.part.0+0xe0/0x230 > lock_acquire+0x68/0x84 > __mutex_lock+0xa8/0x4d0 > mutex_lock_nested+0x48/0x54 > __setup_irq+0xbc/0x8bc > request_threaded_irq+0xf4/0x1b4 > devm_request_threaded_irq+0x88/0x104 > lpi2c_runtime_resume+0x70/0xe4 It seems your (possible) deadlock is triggered along devm_request_irq() dur= ing = resume. As mainline just enables the clocks, there is nothing we can do here. Your = patch still is sensible, can you send a new version with the review address= ed? = Thanks. Best regards, Alexander > pm_generic_runtime_resume+0x34/0x50 > __genpd_runtime_resume+0x38/0x90 > genpd_runtime_resume+0xa0/0x304 > __rpm_callback+0x50/0x1b0 > rpm_callback+0x74/0x80 > rpm_resume+0x448/0x6e0 > __pm_runtime_resume+0x50/0xc0 > lpi2c_imx_xfer+0x60/0xa5c > __i2c_transfer+0x174/0xa80 > i2c_transfer+0x68/0x130 > regmap_i2c_read+0x64/0xb0 > _regmap_raw_read+0x114/0x440 > regmap_raw_read+0x19c/0x28c > regmap_bulk_read+0x1b8/0x244 > at24_read+0x14c/0x2c4 > nvmem_reg_read+0x2c/0x54 > bin_attr_nvmem_read+0x8c/0xbc > sysfs_kf_bin_read+0x74/0x94 > kernfs_fop_read_iter+0xb0/0x1d0 > new_sync_read+0xf0/0x184 > vfs_read+0x154/0x1f0 > ksys_read+0x70/0x100 > __arm64_sys_read+0x24/0x30 > invoke_syscall+0x50/0x120 > el0_svc_common.constprop.0+0x68/0x124 > do_el0_svc+0x30/0x9c > el0_svc+0x54/0x110 > el0t_64_sync_handler+0xa4/0x130 > el0t_64_sync+0x1a0/0x1a4 > = > So this doesn't look like an end of the story yet, unfortunately. > = > -- = > Alexander Sverdlin > Siemens AG > www.siemens.com -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel