From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22B43C10DCE for ; Tue, 5 Dec 2023 18:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UzUZ1CnCTCrqYotZFXfVWTgBn0BjpD7V9ChJEhg7Z88=; b=NZCvpl9q1eWtlt mN7C08OlskVwsHW6WmMN7u7wqGLAA8/Hxrb8vbHBQG+kzUwpLDofwxLQwgujoUp2SVvN9tD4QHK45 ZNSlpP2xavuoQX9WbL6R6Vy77H8UpmRfvi974KRb3NHsIijgyEknGI3i5pkWxIFRx327S1a4WRelZ VD2YX6FiWEgsxD4AFtdinNiDgfQAQ9g/VpMnbkqq/xrAB0hXWE6XktP08y/evaPG9gwMtBLyZ9EsK ilh1dmzObDmmca5fm6oNwq/K4h08W/kAX5Eta8Ycl3QP8SxgTIM7XoUxp44tWIecTKCloKA+yXuWW xJkw49qEtRQ8E89w/Dtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAaTs-008Cbw-2s; Tue, 05 Dec 2023 18:49:16 +0000 Received: from mout.gmx.net ([212.227.17.20]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAaTp-008CaB-0o for linux-arm-kernel@lists.infradead.org; Tue, 05 Dec 2023 18:49:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1701802150; x=1702406950; i=wahrenst@gmx.net; bh=TkcSaVwq/VL1dDGiyneCKlJYpA2NgsRgigcABwTCL4s=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=EY6aPxVMYa2figSosxjoL4lnrNMR3oU2ERb317FilTCoQvDCpbDdeTOdEs1s34qX 9rHXRU01LIM0Q5EhRdTIHJzCipewiZtYuVUItc8WU800SGN1WRxF4ZlFJqYF/oyID B1D22rBlq1uu02RrDM7BMtdcD2AEnIqaXUxN6W9c3R9gP4pVbVUG6jgUtXLj8D0MZ uyz/B4Ke/UDj92JqldKPLYRM4vQJBBm9I8KeBeDeGPG8vAxVSeEqMxC5wmxePyh6A jEWjJ9bCda0j6zucXYBz8/T2tz58Iu44d6+0ig1Nfwxs9PSF6/8c2wOCzuXnpSSGk BjnvasUPEjEEx6/adw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.130] ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MY6Cb-1qkuLr0VjR-00YUkv; Tue, 05 Dec 2023 19:49:10 +0100 Message-ID: <82b93cc9-556f-434f-a48e-2c2353fbcd09@gmx.net> Date: Tue, 5 Dec 2023 19:49:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] ARM: mxs: Do not search for "fsl,clkctrl" Content-Language: en-US To: Fabio Estevam , shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam References: <20231205144713.2053916-1-festevam@gmail.com> From: Stefan Wahren In-Reply-To: <20231205144713.2053916-1-festevam@gmail.com> X-Provags-ID: V03:K1:IuV7YgHt5/mxG6bRum2o/gWtkCnDwJkEWBnrUWv/2IppU00iHUY ri6rDIroeGv1U4VmPdsNACimiG9zv3hnQptU9HwbIAqt8tZnzTIIecd+h/2DhFIm63EXjEb OdRGZniiQWc4uDqiA2GlBCVOh0cT5OKbGSFRyjG3S8SDrI+hcnHseYBNfqDMDfWKAPHParV SaEZMXcRsO3CglyhpmJ6g== UI-OutboundReport: notjunk:1;M01:P0:MfiX+6dFIaE=;uATzgB5Abxny3ecosMfS7FNs/ts t0hmUjpRLE3bxTxcYoKcIKxWLWECZwNxIKT4W3TICgcpnOYO/LR9V75K9qNDQZbRetqUGYBOe WdiaqO8XLbx9u8jMXZ0iu6T/tNsuDbUny+bu5D6Sj2RToVv151uikVPvP6BQgghohm45V6HPc D9xpL5dAYvXks6zybGh2vU0HTHMeCac/jjryFGEI7nXl/Q0exkeHS9Uj/5I0yW6eG4deEwT+8 uQ7ythfmZ44MKH16UxiWtQEy4d6Yf/xlPIAi9gYuqhVfQB1tLBJudmFJ6h3+ZqaGrqdjv1Dr1 kw6saygxWNlCYdR0lS3hsd3GkwnJxofS0Quy/LFvCcGj9E56fosTE5qGTSN3Fd85/uqzV/YcG MANN7lJwRiLPGYoEVzHTNjKfqHlpieWnQIy3YQzdVMk3GsSC5MvwcS5LW5cZBsquxPTISnGIb 8/No3Tg+sJQqp9ChXTHQHQp48P2Gy5Vmx178D1SZKAj8nzOqFXpJLE2Ev4suvOPlQbT0SStB7 i88EYGr3G0rTzPBMD1IqSk4YleudWuq+0J0q534WnhC87bUn+lxsXGKGs/jY+Vto2DY6zIgRK IGhrQ7U0Y6H7zSj9b2FsoKZj63btprE2enrKJaieWxpRFaghNpV1vDkKXA+Sr7Axp6/BuBO1/ H+Lc9Ym3zq+nVphOPnkdAcaoPqQsHw2gyuqYa32Jt0zyGi9KdYVP0MTeRJ4rC9owwx6p3wc+E q7mOGt4Nyduu7jdxfq1nZQGJ+uW6b3bavc9o99dvKOlTFP3jNsVniOUuTFGbSbm5E5GSo8UCz nFmNuw04kPayTvoHuGdXJFHjcdRif4mkW/4OzrNVHe8zfRlu69Lgv55BrSgPVyeRCS9H7wnhd LKl+J7HfAxDYfkufi+4eb7rjmHC3lzSpehwDfvI+E9VXezrDoTUAusAqNhGVcxErWZmNjqGcW 4RG3vA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231205_104913_579612_B7FE663A X-CRM114-Status: GOOD ( 17.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabio, Am 05.12.23 um 15:47 schrieb Fabio Estevam: > From: Fabio Estevam > > The "fsl,clkctrl" compatible string is not documented. > > It is used only to find the base address of the clock controller. > > Instead of searching for an undocumented compatible string, search > for "fsl,imx23-clkctrl" and "fsl,imx28-clkctrl". > > Signed-off-by: Fabio Estevam > --- > arch/arm/mach-mxs/mach-mxs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c > index 3faf9a1e3e36..6e017fa306c8 100644 > --- a/arch/arm/mach-mxs/mach-mxs.c > +++ b/arch/arm/mach-mxs/mach-mxs.c > @@ -356,7 +356,9 @@ static int __init mxs_restart_init(void) > { > struct device_node *np; > > - np = of_find_compatible_node(NULL, NULL, "fsl,clkctrl"); > + np = of_find_compatible_node(NULL, NULL, "fsl,imx23-clkctrl"); > + if (!np) > + np = of_find_compatible_node(NULL, NULL, "fsl,imx28-clkctrl"); i'm fine with getting the rid off "fsl,clkctrl", but some lines below we search for "fsl,imx23-clkctrl" again to adjust reset_addr. Can we avoid this unnecessary search? > reset_addr = of_iomap(np, 0); > if (!reset_addr) > return -ENODEV; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel