From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 009A1C433FE for ; Fri, 21 Oct 2022 06:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QB4AJdFPEzjBgt8IGhpP5/bzK0VoETtnyEaf1kaurO4=; b=SrHGnGC6nojWnkNCQSgYEI9Ive Bh9Y0zpevwVphDRKOCPTXdxM9qfP6dfgPb3307u5tbIEVSQIrMSCpc6baDQ+snqOU4s88U4aFBEfA kMyhg2g+rKQt6jb2xj+0bPp0tuwd/LVbC5axkrwBQusgJao1ex13wf62B2Q/FMVClzTVtkat8sdBO 9xMqRryh7If3Q70cMJY8wSmyGj4VeCmxTSsG4l2DZ1fQmYfiWONUHrK4aYmB+w3NjNke7VqE4v9C1 kxNwlnsPeslgRKfbnDxf10RMMJTP2yRcKcqmo8UBP3JOPacAyThGX9U38/8vY1kUgNtrXiJBzycH7 8axYBoQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ollou-005lLd-FJ; Fri, 21 Oct 2022 06:47:52 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olloq-005lFT-DZ; Fri, 21 Oct 2022 06:47:49 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id A3C711884AB0; Fri, 21 Oct 2022 06:47:42 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 9C2CF250007B; Fri, 21 Oct 2022 06:47:42 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 87CB39EC000B; Fri, 21 Oct 2022 06:47:42 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Fri, 21 Oct 2022 08:47:42 +0200 From: netdev@kapio-technology.com To: Vladimir Oltean Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Ido Schimmel , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 net-next 10/12] net: dsa: mv88e6xxx: mac-auth/MAB implementation In-Reply-To: <20221020225719.l5iw6vndmm7gvjo3@skbuf> References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-11-netdev@kapio-technology.com> <20221018165619.134535-11-netdev@kapio-technology.com> <20221020132538.reirrskemcjwih2m@skbuf> <2565c09bb95d69142522c3c3bcaa599e@kapio-technology.com> <20221020225719.l5iw6vndmm7gvjo3@skbuf> User-Agent: Gigahost Webmail Message-ID: <82d23b100b8d2c9e4647b8a134d5cbbf@kapio-technology.com> X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_234748_647858_0E418BCA X-CRM114-Status: GOOD ( 14.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-10-21 00:57, Vladimir Oltean wrote: > On Thu, Oct 20, 2022 at 10:20:50PM +0200, netdev@kapio-technology.com > wrote: >> In general locked ports block traffic from a host based on if there is >> a >> FDB entry or not. In the non-offloaded case, there is only CPU >> assisted >> learning, so the normal learning mechanism has to be disabled as any >> learned entry will open the port for the learned MAC,vlan. > > Does it have to be that way? Why can't BR_LEARNING on a BR_PORT_LOCKED > cause the learned FDB entries to have BR_FDB_LOCKED, and everything > would be ok in that case (the port will not be opened for the learned > MAC/VLAN)? > I suppose you are right that basing it solely on BR_FDB_LOCKED is possible. The question is then maybe if the common case where you don't need learned entries for the scheme to work, e.g. with EAPOL link local packets, requires less CPU load to work and is cleaner than if using BR_FDB_LOCKED entries? >> Thus learning is off for locked ports, which of course includes MAB. >> >> So the 'learning' is based on authorizing MAC,vlan addresses, which >> is done by userspace daemons, e.g. hostapd or what could be called >> mabd. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel